From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6D932464F2 for ; Thu, 3 Apr 2025 11:26:14 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6626E4060A; Thu, 3 Apr 2025 11:26:14 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 140194060A for ; Thu, 3 Apr 2025 11:26:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1743672372; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1n6UCG5zAXBYC35w+2QD1Z9zh69/o6HHx/WVjlpyLZ0=; b=E2pxEOS+ZzxyO57BAQE0Y+2UT7vpmBSHjYT4Ze3tYAbDgoPIfObhhURNRxDJtATeh8q3gD KVEXFid1gYBb/R1aoxwbgfjqShoyyKHmyR4oZc/8Aioi8ar5bxP7UD7xjvR/BGjh42kIS9 imnb5aPJudBeXwUjZ3oiBESTSS/2IHg= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-620-n9hr1GRHPDesh0dqXXj-0w-1; Thu, 03 Apr 2025 05:26:11 -0400 X-MC-Unique: n9hr1GRHPDesh0dqXXj-0w-1 X-Mimecast-MFC-AGG-ID: n9hr1GRHPDesh0dqXXj-0w_1743672370 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-549948b27a7so288769e87.3 for ; Thu, 03 Apr 2025 02:26:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743672369; x=1744277169; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1n6UCG5zAXBYC35w+2QD1Z9zh69/o6HHx/WVjlpyLZ0=; b=Wdcw7qucDo7X4zULnzx0MqUvDWppSe73pHwOr5lUApqCaRznBJoC15wyUcynMekf6T m23Mm9PFlyiPTkXXu1oeZwZSjYpefPjBKZ+se71ANcP330JAYUdb6rpJUk16EBILu9PZ wdOCuAQwDUyRsuKbR/hClQddih0Mmsvp9ZmmLBt3H0wAMWH58xS/oFCrFYa0ENquFHd2 pZJR707ANyUcSXu/6F6dXGR+yQY2xCZV/XTOdjbP34Z6eGTdJj9y0rdXQ/P3gy/9WOXO 9aWxCW9YU3T2p9ZA9fh9WV/FL1ePT2V10pr1MYIasu9kc64EbViGXeeSQcFi3CHFeHiP JfKw== X-Forwarded-Encrypted: i=1; AJvYcCWzH5jCx1mwTCMjJ8A2lyb6XgRToSLOrfIqJl+Ny+lCQwhOhL0cACqEtbVHo2N9oTgLXJFIurc=@dpdk.org X-Gm-Message-State: AOJu0YzpddTgC3Xrb2lWF+abqnIFbgMHqTAPrW2C+ekUP99LAxhZw2f6 NjDdFO+Gq82qeFz3dwdl+9FRbNsoDR96U7GXOVEcQ0GlRrHE/aOrpmTaGbOO6d+h0CYXjZdDvw9 6oZlpPXWKpPdcGJNPgGiTdMVBd4EA8StZnOpfNZ4Fe/Ewc8WuknWm3fh76MAALOE58UY1hOslnL 5TYyseD7SZz8KpGhNBsf8= X-Gm-Gg: ASbGncvenrw05myh8fuuQHIUWMoh6imzIHQwFL0TPgBnTUIOUwysK1yQq0pIGkVH+KM ocuuzbaXlXWtSbRU+9neIpgvsH5XPm4z2t4F7bp8HPSMOrhEhDZZL18O+uRQ+5w7R3qx7Zr+BI0 s= X-Received: by 2002:a05:6512:39c1:b0:549:43f8:824 with SMTP id 2adb3069b0e04-54b10ecc1d0mr5335166e87.26.1743672369529; Thu, 03 Apr 2025 02:26:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGQHARP27wM0mBOrF4hLjlWePBb0u8ftSmFhSLWPmRj2RI6zyDitoTrge7L8LmDi1bfS9K7AyK8AlF1lTDuOWY= X-Received: by 2002:a05:6512:39c1:b0:549:43f8:824 with SMTP id 2adb3069b0e04-54b10ecc1d0mr5335158e87.26.1743672369135; Thu, 03 Apr 2025 02:26:09 -0700 (PDT) MIME-Version: 1.0 References: <20250402093309.10394-1-oleksandrn@interfacemasters.com> In-Reply-To: <20250402093309.10394-1-oleksandrn@interfacemasters.com> From: David Marchand Date: Thu, 3 Apr 2025 11:25:56 +0200 X-Gm-Features: AQ5f1JqNAGHIqSRgh9UfJZ44B8T0mmQ7w5719yVfBXvhSpv5MPl_Qwbxr0D0Q_Q Message-ID: Subject: Re: [PATCH] trace: fix out of bounds write in __rte_trace_mem_get To: Oleksandr Nahnybida , Sunil Kumar Kori Cc: Jerin Jacob , Tyler Retzlaff , dev@dpdk.org, stable@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: qUOFsS10kTc_yIzqM-jfOACOgl-pc8kSIxPKLUmXWqE_1743672370 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Wed, Apr 2, 2025 at 11:35=E2=80=AFAM Oleksandr Nahnybida wrote: > > Offset should be aligned first before checking if there is free space for > another write. > > Bugzilla ID: 1665 > Fixes: ebaee6409702 ("trace: simplify trace point headers") This commit ebaee6409702 ("trace: simplify trace point headers") just moved code around. I think the bug was present since the first implementation, so: Fixes: 032a7e5499a0 ("trace: implement provider payload") --=20 David Marchand