From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0CEDC4618D for ; Tue, 4 Feb 2025 13:45:24 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E323D4025D; Tue, 4 Feb 2025 13:45:23 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id B895B4025D for ; Tue, 4 Feb 2025 13:45:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738673122; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cJfL9SRr+Tu7mZIrKRUMhb6iqrPYXxG8M5rYaw5YqPQ=; b=EmQpu/zwE4GBo9gbLUeyET09Az694JENgJwpiZ6xc8ShbV9mqTGtQWRX/12Ekgmo+OnHD5 iwqZq21WcYN6jShXKJE6gn5H6FqB3hNeH8mrKxR9dpwO8DUK7HBp6j/Jigc7Aa6EBmwIJ7 PNshI9lmdj5eEXTox/PMGPEQEDmbQxc= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-100-cLUpdBb7MhmFp6a7KrwJlw-1; Tue, 04 Feb 2025 07:45:20 -0500 X-MC-Unique: cLUpdBb7MhmFp6a7KrwJlw-1 X-Mimecast-MFC-AGG-ID: cLUpdBb7MhmFp6a7KrwJlw Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-306007d101dso37074421fa.2 for ; Tue, 04 Feb 2025 04:45:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738673119; x=1739277919; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cJfL9SRr+Tu7mZIrKRUMhb6iqrPYXxG8M5rYaw5YqPQ=; b=QPepzJkPRZzRpzYVPtx1X4J347Y0HnAQBGmnHUOmn+9ZrQ0DDG8HPtR6bknJoLbiKp HTAsyCT1qt6Ia+Mle5tqbMFRjIn/VWQDKQoY/CM0TmSuw2bUdk1iTikmClm551IjquxG /EKAjDQfb6x729+id2rovRhxWaDkiEDnHxFiN6GOUdmti5RiDVJ1hKw0bPKF9ug2tKSY 5DM+/hkz6NBarxh61FeYgYXNqAEhcaOobT3NmjW3oE5MXwOTVVRrZbwuH3zTZhBd/ncK 2jUFozvXBzjAAgW0JPC9hXtmnEfzZH4C1J1pdXE5WDqFaGnMlD+JvX3HvKlXIKdGfs87 79xg== X-Forwarded-Encrypted: i=1; AJvYcCWnFRd2zo8n0ivrTsOPybiHg5rNQKmXEwBaf6unJumO4YPc/xeq6ceeaSVCl2bc8vwqkqry5Eo=@dpdk.org X-Gm-Message-State: AOJu0YzYaj7WjqXPT3MdUoZFWtq3Zy2xCnsOXYRujErxEYHSFVW2PdB4 /ehGWDjZao7Kww8gTgOzumX14YaWarR/7w+8yZYT3tGPflE7Mg3p2Tp49o9TDPxxShSAO4QB8M1 uGEQoPIoCpgU8KASAgwZnhtHLzqWZkZhlWDs1a28c0EtcsIOhGmV7DRyhBf/+bauCSHPpcKSiVA L05hgHat4s9GXxNKzWVgs= X-Gm-Gg: ASbGncsBCAMLxvMAMGHTvfQwkmCBjQcLfAQrd7/0wfXrMGZuMLkPjyApdRcm75fNdMn oKWRGJMBfnCCnWh9pOjl+hoVOu/+YcAIWDxLVO6UgOF/ADiWUTHUbbunDF/1XDPgW X-Received: by 2002:a05:651c:2121:b0:302:1fce:3938 with SMTP id 38308e7fff4ca-307968d42c1mr90535881fa.11.1738673119192; Tue, 04 Feb 2025 04:45:19 -0800 (PST) X-Google-Smtp-Source: AGHT+IEve8aRLHdO66xIC6a7pqmMhJX4kSaXJSZTu0wRCX6+pu4TXG7XIsyqBAkA3p9+n/mca7KOSSBuauAgoIWYjDw= X-Received: by 2002:a05:651c:2121:b0:302:1fce:3938 with SMTP id 38308e7fff4ca-307968d42c1mr90535761fa.11.1738673118796; Tue, 04 Feb 2025 04:45:18 -0800 (PST) MIME-Version: 1.0 References: <1738632218-5796-1-git-send-email-andremue@linux.microsoft.com> In-Reply-To: <1738632218-5796-1-git-send-email-andremue@linux.microsoft.com> From: David Marchand Date: Tue, 4 Feb 2025 13:45:07 +0100 X-Gm-Features: AWEUYZnH4wMAdQUK9iS_r8aS4A9Y26bnNtmvG1gnlWjLOomvwpS72Y-QSg_lCKI Message-ID: Subject: Re: [PATCH] stack: occasional crash due to uninitialized variable To: Andre Muezerie Cc: Honnappa Nagarahalli , Olivier Matz , Gage Eads , dev@dpdk.org, stable@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: sOriT2EYhDFWKbz8_T8LI3PTGKW7f8Wzm8jHi1AAu9M_1738673119 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Tue, Feb 4, 2025 at 2:24=E2=80=AFAM Andre Muezerie wrote: > > Variable "success" was not being initialized and there was a code > path where the last do/while loop in __rte_stack_lf_pop_elems > looked at the value of this variable before it was set to any. > > Compiling with msvc resulted in stack_lf_autotest sometimes crashing. > > The fix is to initialize the variable. This same fix was applied to > stack\rte_stack_lf_generic.h in the past but was missed here. > > Fixes: 7e6e609939a8 ("stack: add C11 atomic implementation") > Cc: stable@dpdk.org > > Signed-off-by: Andre Muezerie Indeed, good catch. Reviewed-by: David Marchand --=20 David Marchand