From: David Marchand <david.marchand@redhat.com>
To: Yunjian Wang <yunjian.wang@foxmail.com>
Cc: dev <dev@dpdk.org>, Stephen Hemminger <sthemmin@microsoft.com>,
dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] eal: fix missing include
Date: Thu, 9 Jul 2020 19:46:13 +0200 [thread overview]
Message-ID: <CAJFAV8xd+KROEFkDvwJAvYwz-r9zzaToYPiX7HYKz0CNX3Z9TQ@mail.gmail.com> (raw)
In-Reply-To: <20200621074929.317051C014@dpdk.org>
On Sun, Jun 21, 2020 at 9:49 AM Yunjian Wang <yunjian.wang@foxmail.com> wrote:
>
> This patch adds the missing include and fixes the build error:
> /dpdk/build/include/rte_uuid.h: In function 'rte_uuid_copy':
> /dpdk/build/include/rte_uuid.h:58:2: error: implicit declaration
> of function 'memcpy' [-Werror=implicit-function-declaration]
> memcpy(dst, src, sizeof(rte_uuid_t));
> ^~~~~~
>
> Fixes: 6bc67c497a51 ("eal: add uuid API")
> Cc: stable@dpdk.org
>
> Signed-off-by: Yunjian Wang <yunjian.wang@foxmail.com>
> ---
> lib/librte_eal/include/rte_uuid.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lib/librte_eal/include/rte_uuid.h b/lib/librte_eal/include/rte_uuid.h
> index 044afbdfa..dc86eb292 100644
> --- a/lib/librte_eal/include/rte_uuid.h
> +++ b/lib/librte_eal/include/rte_uuid.h
> @@ -15,6 +15,7 @@ extern "C" {
> #endif
>
> #include <stdbool.h>
> +#include <string.h>
>
> /**
> * Struct describing a Universal Unique Identifier
> --
> 2.18.1
>
A fix for this issue has been submitted before and made it to the main
branch this week.
https://git.dpdk.org/dpdk/commit/?id=edca6d883eb0137bc3caf7f93651a67360ebdf96
Thanks.
--
David Marchand
next parent reply other threads:[~2020-07-09 17:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200621074929.317051C014@dpdk.org>
2020-07-09 17:46 ` David Marchand [this message]
2020-06-21 7:49 Yunjian Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8xd+KROEFkDvwJAvYwz-r9zzaToYPiX7HYKz0CNX3Z9TQ@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=sthemmin@microsoft.com \
--cc=yunjian.wang@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).