From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 389E1A046B for ; Wed, 26 Jun 2019 09:37:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 29BD44F98; Wed, 26 Jun 2019 09:37:24 +0200 (CEST) Received: from mail-vs1-f67.google.com (mail-vs1-f67.google.com [209.85.217.67]) by dpdk.org (Postfix) with ESMTP id E82C14F98 for ; Wed, 26 Jun 2019 09:37:21 +0200 (CEST) Received: by mail-vs1-f67.google.com with SMTP id v129so923971vsb.11 for ; Wed, 26 Jun 2019 00:37:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yxGrdrCiC0GXilYdoOPFqhXa2ymijNhiIxRLT0/3Z9s=; b=pTpuTXvAOImtTaB/XFYzPEfNcf9deO7irSh/+gHDL/FdI0j1WyFnNN8Ur/pNwI5pAP iKgDXd6/hccuD4+202RBNxNx83a1yO9cShcpYNm5Oky9HTXxFOHLAzQF7Nw3hwhECLrC tDV3YUSmc6zHHWCrxknL6SPWz2cyLv7juXAzAPOXHY/78ujPjB2553E7gbw/HV78v62k u1ZcnWiP+aQSblrnI2sZVCFLc4h8NN6Bvj5Jd6LdA8YtiOs6qJBvvpM/q6eIG8dCvuN1 o+iOVwmwtC0M016i3PYc24EMzpZgj5+V2V5RDCs6fX1Xr9u7liv2RwnnpUoXEHk/RVTW 0l1w== X-Gm-Message-State: APjAAAXzp5s6XkSpFGnI7e2+IQToIFsW05av8YZnTJo3qiwZ2QfdYRh0 ScnqCgT4XETGGtPEbCptb4zlVp4tYV9zAz+YrnEIVg== X-Google-Smtp-Source: APXvYqysx6wTMcYXv49nAFpYWaqh9/AcsscWwTewZCcITfy9Glw/lpiWc9j6rgYv7q3qgy5+OTdDh9R4K9HZg1gOj3c= X-Received: by 2002:a67:f998:: with SMTP id b24mr2134912vsq.180.1561534641369; Wed, 26 Jun 2019 00:37:21 -0700 (PDT) MIME-Version: 1.0 References: <1561469937-16077-1-git-send-email-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Wed, 26 Jun 2019 09:37:10 +0200 Message-ID: To: Rasesh Mody Cc: "dev@dpdk.org" , "stable@dpdk.org" , Shahed Shaikh Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-stable] [EXT] [PATCH] net/qede: remove interrupt reconfigure in handler X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Wed, Jun 26, 2019 at 12:50 AM Rasesh Mody wrote: > >From: David Marchand > >Sent: Tuesday, June 25, 2019 6:39 AM > > > >---------------------------------------------------------------------- > >rte_intr_enable/rte_intr_disable configure the interrupt context on the > >kernel side (either uio or vfio). > >In VFIO case, calling it from the interrupt handlers triggers an unneeded > >interrupt handlers reconfiguration. > >During this reconfiguration window, the device can trigger interrupts > which > >are left unserviced. > > > >Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1654824 > >Fixes: 245aec289338 ("net/qede: fix legacy interrupt mode") > >Fixes: 2ea6f76aff40 ("qede: add core driver") > >Cc: stable@dpdk.org > > > >Signed-off-by: David Marchand > >--- > > Change looks good, thanks. > > Acked-by: Rasesh Mody > Something still bothers me about the meaning of rte_intr_enable()... Let me write a mail to a little more people :-) For now, let's put this patch on hold. -- David Marchand