From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 96B9A46B9B for ; Thu, 17 Jul 2025 10:36:48 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6EDF2400EF; Thu, 17 Jul 2025 10:36:48 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 85CBA400EF for ; Thu, 17 Jul 2025 10:36:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752741407; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nQf+PxUjFdgwuzR3b2ZEPam9LCd4Bs0MKU+U/5d1d/U=; b=Ut6OZmI+1sYyrO9QbKm2JhLagh+96zVTpOo/qka9BlDW5uEgekcihdaHsGUCMi4Gpxb8dH 2vMug9Jfgp1DfYhUzKH1bkjiw7RE9dSU4fbYZjQEgp4Z8ob2u85//LYxHiyE3/O6tEdn0l ifDPvHNPS6DuEwytRLf+xR4AUtaa8Qs= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-507-oycwycyhOvihZ-q1RzIksw-1; Thu, 17 Jul 2025 04:36:45 -0400 X-MC-Unique: oycwycyhOvihZ-q1RzIksw-1 X-Mimecast-MFC-AGG-ID: oycwycyhOvihZ-q1RzIksw_1752741404 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-554f7b19481so380662e87.0 for ; Thu, 17 Jul 2025 01:36:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752741403; x=1753346203; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nQf+PxUjFdgwuzR3b2ZEPam9LCd4Bs0MKU+U/5d1d/U=; b=v7ZpBo3vPWMpUCaUB1bwrD7MfftI0d1lOeh09CEbwhmrSr630nx1OepDDd3lOpF88t 4C/t/LoDnP5YIcdPFtqR/9DxgvZydfcJTWdro6cTWpq8YjWJLUUu/JbYIDn10cqrKxgs jrhEoviGTjHrGR6qVP+JoeDr49jbGWj+EXiWxsoKXR1m6WbESbn8zZOeQwZP+Ko2oaeV WQVJYJkigd9WlPgD7A89CvAWOlxHoUeMTVF9uVL/4Y/nroyKZtdaHfNSMtDE9R9KO+gV 56+i5D6vISNM4Cnve4FHr/TCNwDYSHk3atqD5uYfST0RhVfIm5l5F0saNqRhjbMmdZcM E8Og== X-Forwarded-Encrypted: i=1; AJvYcCUwAh7IT8VaIrXOGF5GV2457ACrrZdz2ec7awsja2PkDYp85oONVBe7Ix5VYqdTXl50vByPSUo=@dpdk.org X-Gm-Message-State: AOJu0Yxx+MrqoD9sDOrp/J25/Yh1kX5jkG3fjGjV5/mMRxGHdzSuP00Z QPSsj/oqjW4P9rOB3wD0ihLoBtDY4jGfyyaTzxVkgIpuabacek+TGkQ7fiaz+0IRHQrr3gJnkhb x40Ft5cV+kdOfa/J2CTJ8466SBZg9iQvpz9PGOpPV+u9giJn2RaNsoNTNckDhIuJ15KobnTalfj rsXDOIbk9081SXGgk0IapCbEU= X-Gm-Gg: ASbGncuP0oeQ8q48CSvV3sQP1FJkLC6JiXvMv71Edn4lVFyYMOm2gpQ6msarHaweuhv Vj5AdqG5muweKJnOgYCQMQZVXJYyBdH5eimiIAK5gyWYn+Yedrgf9KRVah2WF9O+Lu1Gdwc1F/H l+/wEKh2FZXIV6oX8b/6sT3c0= X-Received: by 2002:a2e:b5a4:0:b0:32a:826a:c9d9 with SMTP id 38308e7fff4ca-3308e365711mr11116871fa.5.1752741403494; Thu, 17 Jul 2025 01:36:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGo1+UMkawwbZwHQgjH6Y3v5T2t1gCIwTCDKsIOOoGJiOyWaNpwu/S7ChX4/VnMq9zKwHP1RFASA4cnnptCInM= X-Received: by 2002:a2e:b5a4:0:b0:32a:826a:c9d9 with SMTP id 38308e7fff4ca-3308e365711mr11116781fa.5.1752741402864; Thu, 17 Jul 2025 01:36:42 -0700 (PDT) MIME-Version: 1.0 References: <20250716173922.688476-1-bruce.richardson@intel.com> In-Reply-To: From: David Marchand Date: Thu, 17 Jul 2025 10:36:31 +0200 X-Gm-Features: Ac12FXwKtDIWsVOECt14hOq9bMZEU_r1vxzmuwP9tmjZskuCe_juikYdDHnjAJo Message-ID: Subject: Re: [PATCH] net/ice: fix assumption about tag placement order To: Bruce Richardson Cc: dev@dpdk.org, stable@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: v-FGk3qAtwh6Mc9Qd-oWITud5FPmVSVMRoe2FayAL5U_1752741404 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Thu, Jul 17, 2025 at 10:33=E2=80=AFAM Bruce Richardson wrote: > > On Thu, Jul 17, 2025 at 10:19:24AM +0200, David Marchand wrote: > > On Wed, Jul 16, 2025 at 7:39=E2=80=AFPM Bruce Richardson > > wrote: > > > > > > The specific placement of outer/inner VLAN tags in E810 and related N= ICs > > > is configurable. Therefore, remove the assumption that if the L2Tag2 > > > field is filled in, that the L2Tag1 must also be. Instead, check the > > > existing mbuf VLAN flags, and move tags and set flags as appropriate. > > > This fixes an issue where, with QinQ packets with different Tag ethty= pes > > > (0x88a8 vs 0x8100), we get an mbuf reporting two valid tags, but only > > > having had one tag stripped. > > > > > > Fixes: e0dcf94a0d7f ("net/ice: support VLAN ops") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Bruce Richardson > > > > The ice code seems copy/pasted from i40e. > > So I guess i40e is affected as well. > > > > I'll investigate more. These fixes I intend for 25.11 anyway, since I'd iavf has a similar helper. > rather not risk them late in the 25.07 release cycle. Yes, too late for the current release. --=20 David Marchand