From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 82D55A0487 for ; Mon, 1 Jul 2019 11:25:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 65F792BB5; Mon, 1 Jul 2019 11:25:07 +0200 (CEST) Received: from mail-vk1-f193.google.com (mail-vk1-f193.google.com [209.85.221.193]) by dpdk.org (Postfix) with ESMTP id 54CAF2BB5 for ; Mon, 1 Jul 2019 11:25:06 +0200 (CEST) Received: by mail-vk1-f193.google.com with SMTP id b64so2545975vke.13 for ; Mon, 01 Jul 2019 02:25:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1e/gCkfj1SQXA7qW6FIPGuxLwtNVSFYdLX2J4KlT05c=; b=BC+uLlUguqecU3WG0X3EU66snAE2ekeP35VxayFeHJWz/G6NL1N9ZqSwUs/wy+vrY0 xk6yRDwM6ORwsxOL+Qk3ymALkubgq3lfoL/4XOYHc+FcHFhvXi6SEkxfGAtKvwIJHuAU XCTmYVuzmPClRkXtq9iGqUcokxk6e7KPc21ovHp1FkjLvCo8Q5SeJ0BaJ3vGGmjxgpyp 8KTRPJvDOU7LQlb29SmmRY8NFJIcphn6AN8GbraP7HuGiQ3iTv+U0egY4mCty5r7gTvE AwjKgel67NGRedAifC7lbSxQ53gl4q1UW40+/I1WfGQval5bKQi1mb0DwRcOXpuS6yfH wCnQ== X-Gm-Message-State: APjAAAUNWE/VqyXypKxkVaXSNMrMbHbGifvP/5rDqggDFXSljrmWJyXj kDRY30Y1j5Sg8o8fjhIEbMwmIeOycC8MnQdCvcgA+Q== X-Google-Smtp-Source: APXvYqzG4cal/U1uiFFEZNbEHoA8y5mqIbmlNfMu6FREp6Qs8jWHbdb6mBKbASB668MAAWceeEV35mGggj0dsZP25yA= X-Received: by 2002:a1f:144:: with SMTP id 65mr7677540vkb.53.1561973105631; Mon, 01 Jul 2019 02:25:05 -0700 (PDT) MIME-Version: 1.0 References: <1561469937-16077-1-git-send-email-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Mon, 1 Jul 2019 11:24:54 +0200 Message-ID: To: Shahed Shaikh Cc: Rasesh Mody , "dev@dpdk.org" , "stable@dpdk.org" , "Burakov, Anatoly" Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-stable] [EXT] [PATCH] net/qede: remove interrupt reconfigure in handler X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Mon, Jul 1, 2019 at 11:15 AM Shahed Shaikh wrote: > > > >From: David Marchand > >Sent: Wednesday, June 26, 2019 1:07 PM > >To: Rasesh Mody > >Cc: dev@dpdk.org; stable@dpdk.org; Shahed Shaikh > >Subject: Re: [EXT] [PATCH] net/qede: remove interrupt reconfigure in > handler > > >On Wed, Jun 26, 2019 at 12:50 AM Rasesh Mody > wrote: > >>From: David Marchand > >>Sent: Tuesday, June 25, 2019 6:39 AM > >> > >>---------------------------------------------------------------------- > >>rte_intr_enable/rte_intr_disable configure the interrupt context on the > >>kernel side (either uio or vfio). > >>In VFIO case, calling it from the interrupt handlers triggers an unneeded > >>interrupt handlers reconfiguration. > >>During this reconfiguration window, the device can trigger interrupts > which > >>are left unserviced. > >> > >>Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1654824 > >>Fixes: 245aec289338 ("net/qede: fix legacy interrupt mode") > >>Fixes: 2ea6f76aff40 ("qede: add core driver") > >>Cc: mailto:stable@dpdk.org > >> > >>Signed-off-by: David Marchand > >>--- > >Change looks good, thanks. > >Acked-by: Rasesh Mody > > >Something still bothers me about the meaning of rte_intr_enable()... > >Let me write a mail to a little more people :-) > > >For now, let's put this patch on hold. > > Another question I have is, is it required to re-enable interrupt by PMD > at the end of interrupt handling by calling rte_intr_enable()? > Does DPDK core / vfio/uio module take care of re-enabling the interrupt > after the interrupt is handled? > This is exactly why I wanted to put this on hold. This patch is just wrong, auto NAK for me :-). I am currently reading the VFIO api and how UIO behaves to try and come with a common fix on the DPDK infrastructure side. -- David Marchand