From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 25888455FA for ; Sat, 13 Jul 2024 15:39:16 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0A7AD4025E; Sat, 13 Jul 2024 15:39:16 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id D9AC44003C for ; Sat, 13 Jul 2024 15:39:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1720877953; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8AqWFimeIx6mLwj5noyE2stDNQUsf5yT/9D1mY1k1K8=; b=VPXUCKI//UE2bEgF9u5TDwrw8C+pJB59xbBHTgjJjiSM4EA7XNkbtdtNIdH+ACyfyLitLB 0CqmjxGgw7/s4ISTaw6wqxDng5As8K3SMOglL73nweycnFqBJPPE6AqEEA+Au36VZIByXz KHmEICOTZ/OeP5oyaSBwCAFEsmNM8EE= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-246-Vn80FG9QMeq7tVPnup8oyA-1; Sat, 13 Jul 2024 09:39:11 -0400 X-MC-Unique: Vn80FG9QMeq7tVPnup8oyA-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-52e9cc6a99eso3150465e87.3 for ; Sat, 13 Jul 2024 06:39:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720877950; x=1721482750; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8AqWFimeIx6mLwj5noyE2stDNQUsf5yT/9D1mY1k1K8=; b=TIFo/rJHbIwjF9rTpdAHDwXJ2lMWqzO+tUcmUxPJlP7p/EtFrpqJs/l4rtNn8iHywQ 3U8HH51fvDBnPUzMAMgLdOuLoZKg3XwS/xUex6+oIQO6udMd6lGEgncH4SfDpVPTMC03 t32fpd0BmJOnJ+ZIc9Rlx7DVbQrxNLsaZmyfipvaheUsdj1WurRQQWQNuLgulDiOdGlm yzSOANszFAsb/aTcDJ/U/U7C373dDZ14fTHqP95NaDHVCzewh1+MqxzoJzOy4pZhgZSt yRY62qXDZ7lmUN/SAR6zJ2TbD0z3X7MPTDa6UKGPNuNhERlphEMTMr3Wjq07K1mwf0Nw DbbA== X-Forwarded-Encrypted: i=1; AJvYcCXQT6Pnxeuh+coPM5LvJJrKGpBAkJQumVuHNV0hC/aSYNAMBjiF+/my0Ua/0mKvZb9XSIal0OF5kO6X5v5a2x0= X-Gm-Message-State: AOJu0Yz+cKSGSG4VxbH51p7iv49Dhlce68jJ76EvZF/CgAwD4zcgI8uK u0Dpcui+t40s/Sq9dkj80obbZUkExuLdQ24mwB/NjzmsCFYvQnAJmtN36hJjxpQZD75Sdz4ean0 CMsUB2p0MB1h3Mz2wUsWndDoJJ6N/r9P6Ooiyl4g4FGZo6V4hgfibhrpXTMppv3c9dF9PIS6PNG jDILJMuEpmYbWFzrkKL8s= X-Received: by 2002:a05:6512:2350:b0:52c:987f:b355 with SMTP id 2adb3069b0e04-52eb99cc6abmr10429097e87.42.1720877950296; Sat, 13 Jul 2024 06:39:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHqDxRsTbZ1vVWUYcOst9o/L7CD+kdT9DWdZC2QsUCDzICwRtvmX9seCm0T0ImnOCVgYUYFIYdQRVNbK9qqrEA= X-Received: by 2002:a05:6512:2350:b0:52c:987f:b355 with SMTP id 2adb3069b0e04-52eb99cc6abmr10429079e87.42.1720877949901; Sat, 13 Jul 2024 06:39:09 -0700 (PDT) MIME-Version: 1.0 References: <20240712104528.308638-1-xuemingl@nvidia.com> <20240712110153.309690-1-xuemingl@nvidia.com> <20240712110153.309690-20-xuemingl@nvidia.com> In-Reply-To: <20240712110153.309690-20-xuemingl@nvidia.com> From: David Marchand Date: Sat, 13 Jul 2024 15:38:58 +0200 Message-ID: Subject: Re: patch 'telemetry: lower log level on socket error' has been queued to stable release 23.11.2 To: Xueming Li , Luca Boccassi , Kevin Traynor Cc: Christian Ehrhardt , Bruce Richardson , dpdk stable X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hello LTS maintainers, On Fri, Jul 12, 2024 at 1:04=E2=80=AFPM Xueming Li wr= ote: > diff --git a/lib/telemetry/telemetry.c b/lib/telemetry/telemetry.c > index 88d6410980..551bc92e9d 100644 > --- a/lib/telemetry/telemetry.c > +++ b/lib/telemetry/telemetry.c > @@ -381,7 +381,7 @@ client_handler(void *sock_id) > "{\"version\":\"%s\",\"pid\":%d,\"max_output_len\= ":%d}", > telemetry_version, getpid(), MAX_OUTPUT_LEN); > if (write(s, info_str, strlen(info_str)) < 0) { > - TMTY_LOG(ERR, "Socket write base info to client failed\n"= ); > + TMTY_LOG(DEBUG, "Socket write base info to client failed"= ); Xueming: There is a similar issue to what I reported for EAL, for this backport. In the main branch, we have TMTY_LOG_LINE() that appends a \n to the format string. But TMTY_LOG() in older branches (and as you can see in the context of this hunk) will not do this. To all LTS maintainers: Many libraries have been updated with similar changes (making the \n added by the log macros) in the main branch. I introduced new macros every time possible when doing those changes. The intent was that backports would trigger small conflicts and make the person backporting raise an eyebrow :-). For such small conflicts, some simple rules: - if the commit from main branch uses _LINE(.*, format, args), then it becomes (.*, format "\n", args) in the LTS branches, - if the commit from main branch uses another macro that does not exist in the LTS branch, there is a good chance a "\n" is missing too, And in doubt, just look at logs in the same file. This gives a quick hint in general. Note: backporting those macros could be an option too, but this could be some work as I suspect there will be a lot of conflicts. I went and double checked the rest of the 23.11-staging branch and it seems okay. --=20 David Marchand