From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dmarchan@redhat.com>
Received: from mail-vk1-f195.google.com (mail-vk1-f195.google.com
 [209.85.221.195]) by dpdk.org (Postfix) with ESMTP id 7929914EC
 for <stable@dpdk.org>; Thu, 17 Jan 2019 13:32:33 +0100 (CET)
Received: by mail-vk1-f195.google.com with SMTP id b18so2228067vke.2
 for <stable@dpdk.org>; Thu, 17 Jan 2019 04:32:33 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=NEZwkhqEsJVdAvsXCrHoGuFm4vkWbz/r4m4Ozzg0SNw=;
 b=hh1lAORsPPdDoInC72uUDoGhPCCNY/vxZQ5wPyI/0D2N6uI6xVItdnm7d7ug6K1EiL
 C58hZc7TSSx5X72osTBb7CcGAQhCpxn5rNbWT+3zw1SB4Y4QggusoWsyYOyVk5I+k4ql
 +3+ebMdLr+KjminIa/k1rW/G8OiGreqUvIVCL6LfNM7oJj9MXq6URIFlMEuAsdPIXplP
 2qKkU3+ozLcf0RBztOLDdZTq7KLcEhXUQBHZxkfS8kf6XYjTgtIdUXxSpWemrK2I3s/h
 Y9ve2JfGJj3yuZuAOJcYpCWektJwxz1+jSP2x5jNCqf7tGCZAnrloRZ/eZmEy/czqaPF
 OujA==
X-Gm-Message-State: AJcUukdU+ojecPKy5W4+dfcQA4zH/PYjFdYEdoSqiFXK84f2HpX8lnsX
 OUpEmDvhhWGAdjwkT0K3H5f34czt3mGmLJbhHEmSgw==
X-Google-Smtp-Source: ALg8bN77yLO3+ThStgaL7JJ7BZ+TO1c/ikGoikhfU3gh/UUnTSqZogVDhuehB3d7EoK9wSr5guCoUGcldXzUS66/T5w=
X-Received: by 2002:a1f:b58d:: with SMTP id e135mr5463389vkf.86.1547728352604; 
 Thu, 17 Jan 2019 04:32:32 -0800 (PST)
MIME-Version: 1.0
References: <1547216106-13680-1-git-send-email-hari.kumarx.vemula@intel.com>
 <1547727192-25126-1-git-send-email-hari.kumarx.vemula@intel.com>
 <20190117121916.GA319108@bricha3-MOBL.ger.corp.intel.com>
In-Reply-To: <20190117121916.GA319108@bricha3-MOBL.ger.corp.intel.com>
From: David Marchand <david.marchand@redhat.com>
Date: Thu, 17 Jan 2019 13:32:21 +0100
Message-ID: <CAJFAV8y2QJr6w87_S_3eks8bYoDKB70asHoVdCx=8+ZxvBCBtw@mail.gmail.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: Hari Kumar Vemula <hari.kumarx.vemula@intel.com>, dev@dpdk.org,
 reshma.pattan@intel.com, 
 "Yigit, Ferruh" <ferruh.yigit@intel.com>, jananeex.m.parthasarathy@intel.com, 
 dpdk stable <stable@dpdk.org>
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v6] eal: fix core number
	validation
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
 <mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
 <mailto:stable-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 17 Jan 2019 12:32:33 -0000

On Thu, Jan 17, 2019 at 1:19 PM Bruce Richardson <bruce.richardson@intel.com>
wrote:

> On Thu, Jan 17, 2019 at 12:13:12PM +0000, Hari Kumar Vemula wrote:
> > When incorrect core value or range provided,
> > as part of -l command line option, a crash occurs.
> >
> > Added valid range checks to fix the crash.
> >
> > Added ut check for negative core values.
> > Added unit test case for invalid core number range.
> >
> > Fixes: d888cb8b9613 ("eal: add core list input format")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Hari Kumar Vemula <hari.kumarx.vemula@intel.com>
> > Reviewed-by: David Marchand <david.marchand@redhat.com>
> > --
> > v6: Changed testcase order
> > v5: Corrected unit test case for -l option
> > v4: Used RTE_MAX_LCORE for max core check
> > v3: Added unit test cases for invalid core number range
> > v2: Replace strtoul with strtol
> >     Modified log message
> > ---
> >  lib/librte_eal/common/eal_common_options.c |  9 +++-
> >  test/test/test_eal_flags.c                 | 61 ++++++++++++++--------
> >  2 files changed, 45 insertions(+), 25 deletions(-)
> >
> Is this patch related to, or does it fix Bugzilla #19?
>
> https://bugs.dpdk.org/show_bug.cgi?id=19


Separate issue, from my pov.
I would say the issue happens with a dpdk process that has no cpu available
wrt CONFIG_RTE_MAX_CORES.
eal_auto_detect_cores() then removes all cores from cfg->lcore_role[], then
eal_adjust_config() an incorrect master lcore is chosen at
cfg->master_lcore = rte_get_next_lcore(-1, 0, 0); ?


-- 
David Marchand