From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BB45145E56 for ; Mon, 9 Dec 2024 08:01:56 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B53564025D; Mon, 9 Dec 2024 08:01:56 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 6A27B4025D for ; Mon, 9 Dec 2024 08:01:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733727714; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MBUMvHFLaZR2TFKE/suVbaAauq7oplbn3pSOwI2MsXw=; b=X8sn7yCwX4XBt8q4ZmRR4WfXAw528MHjkjEn8/kAeiMKtJpML2jJrrrAN+aonND7h6913a fhpojrGlNO/X7rO3nlesCsW4Vp2MixrZxhltSfZh7VQ6nBvUlLgqEhc0iDkhPqSzqZjCgl H6axsBUY6+W1pP6w4/mM/nAkDxnFVAs= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-279-OROrhKF4NgyzapgGKvFnoA-1; Mon, 09 Dec 2024 02:01:53 -0500 X-MC-Unique: OROrhKF4NgyzapgGKvFnoA-1 X-Mimecast-MFC-AGG-ID: OROrhKF4NgyzapgGKvFnoA Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-300150a9b48so19979641fa.1 for ; Sun, 08 Dec 2024 23:01:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733727712; x=1734332512; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MBUMvHFLaZR2TFKE/suVbaAauq7oplbn3pSOwI2MsXw=; b=DdoV5CY+ZuQKidpzABuuvF6C8PjGHeGVt27ilPQRWl7n71QUiOqdZq/oD38R6h/ONl NU/8GVB9/LHsKyUMHO1VpQIIc5IGT66Q6RJzLJ0VSkQsrPW4mK1cdtQuvN4pZlXFLdlr RF/ampfVKibgDEyrEo8sbID7I4DdRXSPi9UGeRD1YWF/acr2a5dgsnI9Y+E4XgRR8Z8V ENpxbjtGOB9cQ3FzDAvujjlXPIUQOkNDqgdm9odM2ad17DKdE328fvFj3IxggfN97kRc RRjhfn0HAlm2aCi3df0U6MTkqWVdbXTdwiw4Zj2EY7S5nbI278BU6o43HNoFMAFnEmsh M7cw== X-Forwarded-Encrypted: i=1; AJvYcCW2J54HlwS5VMQ8JxGJ3QRx/siCm2gwDWpUTqogtOjxa41TIW5FIMGXRg2JB2Ham+VUN6AxYlY=@dpdk.org X-Gm-Message-State: AOJu0YwMwyEevIb/wwtaER0Nke68vDQcAOiY9WXw68vk6VkW2Ie5Rofj JRt2ZvadpPWnARi8A6kV3Ap7BCZWuqEJuFKX4My5Ctf9V0nFro0rEeE31uGVkol+ebg0+HhpCsu 6lD5U2kBUgOqHg/Jm7gFcTM6UgSiBoGXZgYSuXxuNVYxxAMmwF75P36TVmBF4EFb+HX1BZh9q6x VUf8Go7GP0gOEMD+QFW1o= X-Gm-Gg: ASbGncsI4YQOdHBCS/XKgZCYcc47dyu/bqSFhLDdwnKRXOb+qmkdnv98uaL+jaBxiS4 k8l/W/HSLVk+M0uSXBp7KVrWOWVPZDsx4mQ== X-Received: by 2002:a05:6512:b1c:b0:53e:389d:8ce4 with SMTP id 2adb3069b0e04-53e389d8e1cmr2981943e87.34.1733727712103; Sun, 08 Dec 2024 23:01:52 -0800 (PST) X-Google-Smtp-Source: AGHT+IEeBHk7yXAmkvATWJ+mQPqyAMn7FWCHa1Ufy5U05H2jp3JdcGdZsIhVLC3NfDl5HItRbypiuIRJmb9rm0qBh3c= X-Received: by 2002:a05:6512:b1c:b0:53e:389d:8ce4 with SMTP id 2adb3069b0e04-53e389d8e1cmr2981916e87.34.1733727711043; Sun, 08 Dec 2024 23:01:51 -0800 (PST) MIME-Version: 1.0 References: <20241127171916.690404-1-ktraynor@redhat.com> <20241127171916.690404-69-ktraynor@redhat.com> In-Reply-To: <20241127171916.690404-69-ktraynor@redhat.com> From: David Marchand Date: Mon, 9 Dec 2024 08:00:00 +0100 Message-ID: Subject: Re: patch 'power: fix mapped lcore ID' has been queued to stable release 21.11.9 To: Kevin Traynor Cc: Sivaprasad Tummala , Konstantin Ananyev , Huisong Li , dpdk stable X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 4anHK6oYPWINzoPl5IquAWTlaDC57uoaelY_7UWGT3g_1733727712 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Wed, Nov 27, 2024 at 6:22=E2=80=AFPM Kevin Traynor = wrote: > Diff of the applied patch vs upstream commit (please double-check if no= n-empty: > --- > --- - 2024-11-27 17:17:40.435934249 +0000 > +++ 0069-power-fix-mapped-lcore-ID.patch 2024-11-27 17:17:38.26226= 9565 +0000 > @@ -1 +1 @@ > -From 5c9b07eeba55d527025f1f4945e2dbb366f21215 Mon Sep 17 00:00:00 2001 > +From 939535ca3bed8f1c9013baba9691ca356cca6d3b Mon Sep 17 00:00:00 2001 > @@ -5,0 +6,2 @@ > +[ upstream commit 5c9b07eeba55d527025f1f4945e2dbb366f21215 ] > + > @@ -25 +26,0 @@ > -Cc: stable@dpdk.org > @@ -31,8 +32,8 @@ > - app/test/test_power_cpufreq.c | 21 ++++++++++++++++++--- > - lib/power/power_acpi_cpufreq.c | 6 +++++- > - lib/power/power_amd_pstate_cpufreq.c | 6 +++++- > - lib/power/power_common.c | 23 +++++++++++++++++++++++ > - lib/power/power_common.h | 1 + > - lib/power/power_cppc_cpufreq.c | 6 +++++- > - lib/power/power_pstate_cpufreq.c | 6 +++++- > - 7 files changed, 62 insertions(+), 7 deletions(-) > + app/test/test_power_cpufreq.c | 21 ++++++++++++++++++--- > + lib/power/power_acpi_cpufreq.c | 6 +++++- > + lib/power/power_common.c | 23 +++++++++++++++++++++++ > + lib/power/power_common.h | 1 + > + lib/power/power_cppc_cpufreq.c | 6 +++++- > + lib/power/power_pstate_cpufreq.c | 6 +++++- > + lib/power/rte_power_pmd_mgmt.c | 4 ++-- > + 7 files changed, 59 insertions(+), 8 deletions(-) > @@ -41 +42 @@ > -index 619b2811c6..edbd34424e 100644 > +index 4d013cd7bb..051b9036dc 100644 > @@ -74 +75 @@ > -@@ -498,4 +500,17 @@ test_power_cpufreq(void) > +@@ -487,4 +489,17 @@ test_power_cpufreq(void) > @@ -93 +94 @@ > -index abad53bef1..ae809fbb60 100644 > +index 402ed8c99b..1bb74bdca6 100644 > @@ -101,16 +102 @@ > -+ POWER_LOG(ERR, "Cannot get CPU ID mapped for lcore %u", l= core_id); > -+ return -1; > -+ } > -+ > - /* Check and set the governor */ > - if (power_set_governor_userspace(pi) < 0) { > -diff --git a/lib/power/power_amd_pstate_cpufreq.c b/lib/power/power_amd_= pstate_cpufreq.c > -index 4809d45a22..2b728eca18 100644 > ---- a/lib/power/power_amd_pstate_cpufreq.c > -+++ b/lib/power/power_amd_pstate_cpufreq.c > -@@ -383,5 +383,9 @@ power_amd_pstate_cpufreq_init(unsigned int lcore_id) > - } > - > -- pi->lcore_id =3D lcore_id; > -+ if (power_get_lcore_mapped_cpu_id(lcore_id, &pi->lcore_id) < 0) { > -+ POWER_LOG(ERR, "Cannot get CPU ID mapped for lcore %u", l= core_id); > ++ RTE_LOG(ERR, POWER, "Cannot get CPU ID mapped for lcore %= u", lcore_id); A final \n is missing in the format string. > @@ -123 +109 @@ > -index 590986d5ef..b47c63a5f1 100644 > +index 1e09facb86..e2a8c33604 100644 > @@ -132 +118 @@ > -@@ -205,2 +206,24 @@ out: > +@@ -203,2 +204,24 @@ out: > @@ -143 +129 @@ > -+ POWER_LOG(ERR, > ++ RTE_LOG(ERR, POWER, Probably the same here, and other occurences in this patch. --=20 David Marchand