From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3E9FCA04B1 for ; Mon, 23 Nov 2020 19:35:20 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 08EBB160; Mon, 23 Nov 2020 19:35:19 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id 4F8B9160 for ; Mon, 23 Nov 2020 19:35:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606156515; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7xjC9d0hd4kF2cMo5LoWjKhpDPLYI782ufwY6fyy0VM=; b=LY/5Aik0SKABiOmHrwMCWJLv/oit/sSOcxJbAKFtlEkVUnOmn8ZJ3PehLYmsbOqPWNorMW bIWAy3tJCsDAHr6YKc+MBC1eqzqy/CrthI7xn4g367Pa5DpgEilCd94lYi7WoCqQ/0mILV XV3MgkDydQAaMmg3veh29zN3mJ+s2VA= Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-447-nNnk0OTYPOmeG3ObBd9BXQ-1; Mon, 23 Nov 2020 13:35:14 -0500 X-MC-Unique: nNnk0OTYPOmeG3ObBd9BXQ-1 Received: by mail-vk1-f198.google.com with SMTP id x134so8341513vkd.17 for ; Mon, 23 Nov 2020 10:35:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7xjC9d0hd4kF2cMo5LoWjKhpDPLYI782ufwY6fyy0VM=; b=NtEIkT7Ri9lWDDHc1msdadcQrT/Fk4Sj3MuID+osGiq/ue65BdpRTnvYu8LBoQ6W1D MLAbTBotK3HCHbRQ2Wbdw+xIpxFozQGb6EWhztIOfOf2F3fdXSvhFnn5NncIJMvishsm hKfB7jENNJWGEe0CtwoN9YdF78yxDP5GRqhDDkeE2pYlIdxmfq8k5M+zWpUazrEc6jNr LnYnmeTPelw+I6DqOjFDcl2erxr7Ztxf75Ec7XN9EmSAC2ph7HD0w3ix4sjVBW/cpjDj 0jyPm/ssDR+pb0OjcA060rWHJ8loUnQaXFnzOMpKke4t3hRlQ4VYHgyhEelJWIUZSRJG n5fg== X-Gm-Message-State: AOAM532gpk5o2j7BphBYoON1WIqwf+X+w8/I9UHD+MU0g+8YguEsRJsC s858qfUE9+4fz3zuijL832MtFMQqcPnd2GvieugBlbBX9L7Xw85ZNA0NO10ii7oBu7tOjRXSDMG mjIp179xlzlJRfIQpyVcvPLg= X-Received: by 2002:ab0:2e9:: with SMTP id 96mr894666uah.87.1606156513609; Mon, 23 Nov 2020 10:35:13 -0800 (PST) X-Google-Smtp-Source: ABdhPJw4EL6mxNg/hbrjaFp1LhfZOCpuWWWCYg6kMyVmgickroXuIkWTYv0LJDZ1mHsIcudMdDGCwtCf9E2rflzE6WM= X-Received: by 2002:ab0:2e9:: with SMTP id 96mr894628uah.87.1606156513322; Mon, 23 Nov 2020 10:35:13 -0800 (PST) MIME-Version: 1.0 References: <20201123171222.79398-1-ktraynor@redhat.com> <20201123171222.79398-17-ktraynor@redhat.com> In-Reply-To: <20201123171222.79398-17-ktraynor@redhat.com> From: David Marchand Date: Mon, 23 Nov 2020 19:35:02 +0100 Message-ID: To: Kevin Traynor Cc: Ferruh Yigit , Qi Zhang , Andrew Rybchenko , Igor Romanov , dpdk stable Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] patch 'app/testpmd: fix MTU after device configure' has been queued to LTS release 18.11.11 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Mon, Nov 23, 2020 at 6:13 PM Kevin Traynor wrote: > From 922feed76bd5d8fe06b95a56afabd3a95987b047 Mon Sep 17 00:00:00 2001 > From: Ferruh Yigit > Date: Fri, 13 Nov 2020 11:44:00 +0000 > Subject: [PATCH] app/testpmd: fix MTU after device configure > > [ upstream commit 1c21ee95cf5298fe7b6a8b7d8a997ff3c402a08f ] > > In 'rte_eth_dev_configure()', if 'DEV_RX_OFFLOAD_JUMBO_FRAME' is not set > the max frame size is limited to 'RTE_ETHER_MAX_LEN' (1518). > This is mistake because for the PMDs that has frame size bigger than > "RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN" (18 bytes), the MTU becomes > less than 1500, causing a valid frame with 1500 bytes payload to be > dropped. > > Since 'rte_eth_dev_set_mtu()' works as expected, it is called after > 'rte_eth_dev_configure()' to fix the MTU. > It may look redundant to set MTU after 'rte_eth_dev_configure()', both > with default values, but it is not, the resulting MTU config can be > different in the device based on frame overhead of the PMD. > > And instead of setting the MTU to default value, it is first get via > 'rte_eth_dev_get_mtu()' and set again, this is to cover cases MTU > changed from testpmd command line. > > 'rte_eth_dev_set_mtu()', '-ENOTSUP' error is ignored to prevent > irrelevant warning messages for the virtual PMDs. > > Fixes: af75078fece3 ("first public release") > > Signed-off-by: Ferruh Yigit > Reviewed-by: Qi Zhang > Acked-by: Andrew Rybchenko > Tested-by: Igor Romanov Hey Kevin, This patch has been reverted in rc5. -- David Marchand