From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0DB14A0A02 for ; Wed, 5 May 2021 18:16:04 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0617240040; Wed, 5 May 2021 18:16:04 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 0D12641108 for ; Wed, 5 May 2021 18:16:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620231361; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0AfYC8jUnpvYO+W+Na9D42rkyZWGYVE6MwPKlvWBQbk=; b=Mk7U4pbEUt2HFcnI8j7d78lXu0+NarBWJlxMh9NtA0q6lvSwNmNdG0lfFw+pi6TLSZ9VMj FcgKTr1h50RP98Bx2jV+/lZLP45zcl4CzY+k4vNPFSoqVViMfbxj5MPr1QEZjPyN+8I8jr OhCxdlU/cm3ALlpEbBqc/zBY+yc2HSg= Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com [209.85.217.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-499-kirs2pHdPGuBanBvBZRDdw-1; Wed, 05 May 2021 12:15:59 -0400 X-MC-Unique: kirs2pHdPGuBanBvBZRDdw-1 Received: by mail-vs1-f69.google.com with SMTP id k8-20020a67c2880000b029022833ef2244so1300617vsj.18 for ; Wed, 05 May 2021 09:15:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0AfYC8jUnpvYO+W+Na9D42rkyZWGYVE6MwPKlvWBQbk=; b=I12OMh7x9oEuBfK6tNc8ItDZzS+XN+MuOCTV2Ss/vG6J/+34or4j6D1kXtFCN7xrRn MeBMfdw57SMKFwQTuYs1DY5A8ov8m3rzlTPmJbJs6tsP5cFQwTlIRSliwYRdtQEJzGsc g4z3nhzz+LBOZlpLlwq6JXjA7xcQiaVd0Zzb/QZGVFrENceBgDMKOGmoM9EPLAk3u/EI 3UlRe5/OuiRXcI4jiJRQzIPl47DYp6GxRQ60+tuVnYdnMC1y2PEUg6LahmWDKFYYT70d izEsTwQ9nKYO0egW6tOgRolRb36btEgXNc864Ug1t5wWsjwmOcXyj5laUiGSHKM7b3lA 5/ew== X-Gm-Message-State: AOAM532+TICTqy/UzxtLHmB+RKHexbEMRRQWj6fgYll/WF2A5MihwzSw qziY6m0IyJWmqEUTy5rHH5g2+Vf/7AUSS43c6Q2pr9QDw/uBLTwAnc4H3azctfmqUqiCOOcDlFX RbVBTW2kb15gScqIvZdJYLZI= X-Received: by 2002:a67:6b41:: with SMTP id g62mr8479885vsc.5.1620231358925; Wed, 05 May 2021 09:15:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyPoesX51VLC/yO+b3drGRO77IXFYWWD9MumzF6HtstkzHT0/wcC7DbHg4S9qJMhOMH5LLqTEzleCTxBG/aThA= X-Received: by 2002:a67:6b41:: with SMTP id g62mr8479864vsc.5.1620231358776; Wed, 05 May 2021 09:15:58 -0700 (PDT) MIME-Version: 1.0 References: <20210505152248.253496-1-ciara.power@intel.com> In-Reply-To: From: David Marchand Date: Wed, 5 May 2021 18:15:47 +0200 Message-ID: To: Bruce Richardson Cc: Ciara Power , dev , dpdk stable Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] [PATCH] telemetry: fix accessing callbacks list using lock X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Wed, May 5, 2021 at 5:36 PM Bruce Richardson wrote: > > On Wed, May 05, 2021 at 03:22:48PM +0000, Ciara Power wrote: > > The list_commands() function accessed the callbacks list, > > but did not take the lock. This may have caused inconsistencies if > > callbacks were being registered at the same time. > > This is now fixed to lock before iterating the list, > > and unlock afterwards. > > > > Fixes: f38748736eb2 ("telemetry: add default callback commands") > > Cc: stable@dpdk.org > > > > Reported-by: David Marchand > > Signed-off-by: Ciara Power > Acked-by: Bruce Richardson Applied, thanks. -- David Marchand