From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 604D8A056C for ; Wed, 4 Mar 2020 10:37:41 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2D7792C4F; Wed, 4 Mar 2020 10:37:41 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 940AE2C4F for ; Wed, 4 Mar 2020 10:37:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583314658; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SvFLDypuF8DmILxlBFRFN+v0rP/UM2scB6FMXyOsiW8=; b=LbCwp67Uid5Qw7lmp6oIjARY7M5dMZT5yRbGgAyJMfB25ZN7M0NrOb7wT9KwdIFELGB5dN qmnbukWjKeW7RVfPlNSmmCu/3I/0vtGEuct6VNya4Sq/WlEVoIT+9yJ5SZloP06M5F/YxO lFUF46C/UjSMeHag3h9n7EgDkJebYKY= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-293-9pQ-JaZQOcuiLt2XqfOH-w-1; Wed, 04 Mar 2020 04:37:35 -0500 X-MC-Unique: 9pQ-JaZQOcuiLt2XqfOH-w-1 Received: by mail-vk1-f199.google.com with SMTP id n8so491570vke.13 for ; Wed, 04 Mar 2020 01:37:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RAT30+oh/+/5GfM1Vcv5MyeFAT49EGIETLJCsuDDecA=; b=N8mJ7w+My+gLwpXGkFaVjiEC1QtNXl5TLts57+2xGe+5S/jFf+yIgkSeBTfQbw4vF8 dj6pnMwUG4yPpBpc1EKQW9IdxUMH95CNUmn+FDHHRazokmH8vfk/dqOPorX8QQRCEBDd 7pjzwRn86Wiz68K185HMs7HQyaiGYTL7w3mLOMZAMUbndyC2ZzVCHzAV12Ft1pcriUqQ NSJiDWhqn4F0PnnUI1S+MyXPoW4ssyVgKXFTHsYXuJ5rR1lJgNo3o2ffKnazOrhjMtAM Brm13EFqDZhKXW25ZYK8e0/GyZeMJjs9M2/AmAEV9+c1bNwS83b0jMg9ALL7Eu2qhHM4 rvjA== X-Gm-Message-State: ANhLgQ2lk5VWymD9QLyGi9ovnRa8S5USo+3mNMN2LxX5bGVvvXLLn09p IicSXxVfeB/E2xOv5xpATCQrICfd37r+wyt+xxf0Iew907l0wLqCAhYkbFlNj5S5DFoNrQo1qG7 zvHyBmLgi1TC3qn7RcjNy95g= X-Received: by 2002:ab0:2801:: with SMTP id w1mr907589uap.87.1583314655198; Wed, 04 Mar 2020 01:37:35 -0800 (PST) X-Google-Smtp-Source: ADFU+vv5mT12aKme9KlDbBLvM0WQ2gO+ifHR26JpE9iX4SUSDIsNv4wppdN2/iCZtJAmKsjvZ7G5St3t++qtI9J/LmY= X-Received: by 2002:ab0:2801:: with SMTP id w1mr907581uap.87.1583314654883; Wed, 04 Mar 2020 01:37:34 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: David Marchand Date: Wed, 4 Mar 2020 10:37:23 +0100 Message-ID: To: Timothy Redaelli Cc: dev , dpdk stable X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH 0/3] examples: fix building with GCC 10 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Wed, Feb 5, 2020 at 2:47 PM Timothy Redaelli wrot= e: > > GCC 10 defaults to -fno-common, this means a linker error will now be > reported if the same global variable is defined in more than one > compilation unit. > > See https://gcc.gnu.org/gcc-10/porting_to.html for more informations. > > I didn't put -fcommon to CFLAGS since: > Compiling with -fno-common is useful on targets for which it provides > better performance, or if you wish to verify that the program will work > on other systems that always treat uninitialized variable definitions > this way. > from gcc man page For the series, Acked-by: David Marchand --=20 David Marchand