From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 161DEA0530 for ; Wed, 5 Feb 2020 14:26:54 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E30FB1C1C6; Wed, 5 Feb 2020 14:26:53 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 5C2211C199 for ; Wed, 5 Feb 2020 14:26:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580909211; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dgz5R5AJURl7F6O1Sfh0FaGHFeXQcvTs0MftVNWVzg0=; b=etwev5b8MlPF96QtmDQUQd0gj4+85iD41w1iJnkyundriDiK9SNfbPovsqYvBabnCXkPD9 EgmUT1cTWIJp43XGDP7wgWM4zZnK7pexhXllHKz/CDszxFKpA/u36D5vYk/ZbKc9rZSPhJ DnX3wL0kJ7pvXleZqQXAcqGGE8UnAUY= Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-420-8q_GnedoMPGcOB539Wi0jw-1; Wed, 05 Feb 2020 08:26:48 -0500 Received: by mail-vk1-f197.google.com with SMTP id j25so617573vkn.3 for ; Wed, 05 Feb 2020 05:26:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gkKSHUf9bTwzcjw+eSRcSyqtVQj+C8HUvhNbLYeRm48=; b=nqAy7YyXRKFx1vVX7QDRjIBGcW2PZIkvpCHvH1UK8XVP1+qPWcqxDbWcuLHw3dPXri xKU4Op7aKXi5X1FN0+X7Axm8dSh5F6vjIrheC1fKTy9bSYidk43Qnwe2beZZP77FYJxt 76VYHi9oe6K5MHg0+TapfdJjpsXQTZLNqHZU6Len+gidz+JYTMjvn9rY4pRuJeaXMt6c 6tee5YoTie7ArONnaaiAFPeVVk3Bn3Am3o0sm85Qw6qERE0qwyFxyl/R+mf8tVeVgDll wBwjc/+1Th85vRIaw/+UqXs1WB4mxwZKBkOugF9M7TC0RjQK9OAg/k8sWEZH4jJPPFw+ Vwyg== X-Gm-Message-State: APjAAAXqMiPQy0Mac9lnmnt4Tcrs0kYdAh+pesXRcWtSyYey3VJSJEvw sb6U7YwRPYJ5TWidu4mDOuNNVZjCRDndFzfggCqzlisFNQrauF4osmTLkMpGOvTxszr22RL1nVc /WL3klroR5B1zvYoIyv+rM2U= X-Received: by 2002:a67:f1ca:: with SMTP id v10mr21618936vsm.180.1580909207533; Wed, 05 Feb 2020 05:26:47 -0800 (PST) X-Google-Smtp-Source: APXvYqzX6JbCJG1MSatGa0YOlaTq3wJ6aMW2pKEtcM9vI5SiA56HYNfRCl1VbaJjwWJRR0pnSzUbTKP9/JEX2/PsrDU= X-Received: by 2002:a67:f1ca:: with SMTP id v10mr21618925vsm.180.1580909207273; Wed, 05 Feb 2020 05:26:47 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: David Marchand Date: Wed, 5 Feb 2020 14:26:35 +0100 Message-ID: To: Timothy Redaelli Cc: dev , Cristian Dumitrescu , dpdk stable X-MC-Unique: 8q_GnedoMPGcOB539Wi0jw-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-stable] [PATCH 3/3] app/test-pipeline: fix building with GCC 10 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Wed, Feb 5, 2020 at 1:51 PM Timothy Redaelli wrot= e: > > GCC 10 defaults to -fno-common, this means a linker error will now be > reported if the same global variable is defined in more than one > compilation unit. > > Fixes: 48f31ca50cc4 ("app/pipeline: packet framework benchmark") > Cc: cristian.dumitrescu@intel.com > Cc: stable@dpdk.org > Signed-off-by: Timothy Redaelli > --- > app/test-pipeline/config.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/app/test-pipeline/config.c b/app/test-pipeline/config.c > index 28ac9fcc0..42c6ed9b2 100644 > --- a/app/test-pipeline/config.c > +++ b/app/test-pipeline/config.c > @@ -42,7 +42,7 @@ > > #include "main.h" > > -struct app_params app; > +extern struct app_params app; app is already declared as extern in main.h. -- David Marchand