[PATCH] net/tap: remove log when running without multiprocess

[PATCH] net/tap: remove log when running without multiprocess

[David Marchand]

In case DPDK is started with multiprocess disabled (like in OVS), there
is no reason to log an error on multiprocess aspects.

Note: the only caller of this helper does not check the return value.

Fixes: c36ce7099c21 ("net/tap: fix to populate FDs in secondary process")
Cc: stable@dpdk.org

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 drivers/net/tap/rte_eth_tap.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index 730f1859bd..7a8a98cddb 100644
--- a/drivers/net/tap/rte_eth_tap.c
+++ b/drivers/net/tap/rte_eth_tap.c
@@ -769,7 +769,7 @@ tap_link_set_up(struct rte_eth_dev *dev)
 	return 0;
 }
 
-static int
+static void
 tap_mp_req_on_rxtx(struct rte_eth_dev *dev)
 {
 	struct rte_mp_msg msg;
@@ -791,13 +791,10 @@ tap_mp_req_on_rxtx(struct rte_eth_dev *dev)
 	msg.num_fds = dev->data->nb_rx_queues;
 
 	err = rte_mp_sendmsg(&msg);
-	if (err < 0) {
+	if (err < 0 && rte_errno != ENOTSUP) {
 		TAP_LOG(ERR, "Failed to send start req to secondary %d",
 			rte_errno);
-		return -1;
 	}
-
-	return 0;
 }
 
 static int
-- 
2.52.0

Re: [PATCH] net/tap: remove log when running without multiprocess

[David Marchand]

On Mon, 5 Jan 2026 at 13:37, David Marchand <david.marchand@redhat.com> wrote:
>
> In case DPDK is started with multiprocess disabled (like in OVS), there
> is no reason to log an error on multiprocess aspects.
>
> Note: the only caller of this helper does not check the return value.
>
> Fixes: c36ce7099c21 ("net/tap: fix to populate FDs in secondary process")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>

I chose to simply silence this warning, though I think something is
wrong with the sync mechanism.
Secondary processes should be the one requesting fds, instead of the
primary process broadcasting to all.


-- 
David Marchand

Re: [PATCH] net/tap: remove log when running without multiprocess

[Stephen Hemminger]

On Mon, 5 Jan 2026 13:50:31 +0100
David Marchand <david.marchand@redhat.com> wrote:

> On Mon, 5 Jan 2026 at 13:37, David Marchand <david.marchand@redhat.com> wrote:
> >
> > In case DPDK is started with multiprocess disabled (like in OVS), there
> > is no reason to log an error on multiprocess aspects.
> >
> > Note: the only caller of this helper does not check the return value.
> >
> > Fixes: c36ce7099c21 ("net/tap: fix to populate FDs in secondary process")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>  
> 
> I chose to simply silence this warning, though I think something is
> wrong with the sync mechanism.
> Secondary processes should be the one requesting fds, instead of the
> primary process broadcasting to all.
> 
> 

Queued to next-net