From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0BED3A04B5 for ; Wed, 4 Dec 2019 13:31:28 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8C6871BE83; Wed, 4 Dec 2019 13:31:27 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 0F0841BE83 for ; Wed, 4 Dec 2019 13:31:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575462686; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Mw7f3kvjHpkIutKqd9RBUiplhMyhrxAO0peBeLNUS5k=; b=BxjE0iorbmJ6qBgYnzuXuFSav6TLaPiZii81+/oWSa3VCDuKSpsnwN2NaBhmkZDTIts3gy nUtGoXCqjeEl2EspXA0VSRzW1BrVRpVxcCjZlisGYXsOLCsY83ibR+nH6SCoxwTAh0i7DS NFpdiQtJeNsS09/ilVMLqzH1E59FFbk= Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-377-o8WCrd_zOSG47qM4d-nx5A-1; Wed, 04 Dec 2019 07:31:24 -0500 Received: by mail-vk1-f197.google.com with SMTP id b2so1025042vke.8 for ; Wed, 04 Dec 2019 04:31:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Mw7f3kvjHpkIutKqd9RBUiplhMyhrxAO0peBeLNUS5k=; b=Dttru6XO/zt4b9l6RlEUTBcIAdWPoRodS5yLIra/D6EyTg1+90+2XgoT1/+bG8MwL0 WeRhFtsdPz+DeIPY/hDQfepXnYfzDNhJ9JM/JT5H+6vy47Oz5sZ6pEgCs1bZHxRaaO7X OBltQaNm9Q39EPIOBdP468ilrK+2sCWhIQ6wf4uIpsvKbbMqIKe9kpSTFD+ikpayVO4r Jj69fgxACX8mX6SfGKEAUjmHxjDGhVAAfZcEQbAuwv47UY20VlzMtOOMB/MtmCiEe9/B zFr4bKoBdO4/VKihRDxEyZxMFSugNrtQvn6e1hkUA/ku5/DIs8YroNcaFUCLVLyXDMFg MlSw== X-Gm-Message-State: APjAAAXGjGiuKRE1GBjqZ176BPB6joskY3uRo0VYXxib2FQfH1nOMPt1 mMkIt7Vn9SowC85ZuEfCKVdQ08AiUJOqEpEsAoSaQyuLOr4eJmT/yYcxyCV3JabY1FLLHlgx0o4 W8+HWDH699YXPnbrzhRJB/kQ= X-Received: by 2002:ab0:3495:: with SMTP id c21mr2257967uar.86.1575462683828; Wed, 04 Dec 2019 04:31:23 -0800 (PST) X-Google-Smtp-Source: APXvYqzs31pjEKcWum6FPBWthTokc3U8JGWF6SW83jxU1mF2BFcyTorV5MECV4s2RGL01dbAklbzy+8coBz0wfgucAM= X-Received: by 2002:ab0:3495:: with SMTP id c21mr2257928uar.86.1575462683211; Wed, 04 Dec 2019 04:31:23 -0800 (PST) MIME-Version: 1.0 References: <20191127223232.26404-1-stephen@networkplumber.org> In-Reply-To: From: David Marchand Date: Wed, 4 Dec 2019 13:31:11 +0100 Message-ID: To: Andrew Rybchenko Cc: Stephen Hemminger , dev , dpdk stable X-MC-Unique: o8WCrd_zOSG47qM4d-nx5A-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] eal: fix unitialized data warning X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Wed, Dec 4, 2019 at 1:17 PM Andrew Rybchenko wrote: > > On 12/4/19 2:12 PM, David Marchand wrote: > > Fixed title s/unitialized/uninitialized/ > > > > On Wed, Nov 27, 2019 at 11:32 PM Stephen Hemminger > > wrote: > >> > >> Valgrind reports that eal interrupt thread is calling epoll_ctl > >> with uninitialized data. Trivial to fix by initializing it. > > > > Added a note on it being a Valgrind false positive. > > > > > >> Fixes: af75078fece3 ("first public release") > >> Cc: stable@dpdk.org > > > >> Signed-off-by: Stephen Hemminger > > Acked-by: David Marchand > > > > Applied, thanks. > > It breaks build on RHEL 7.6 gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-36): > > lib/librte_eal/linux/eal/eal_interrupts.c: In function > =E2=80=98eal_intr_thread_main=E2=80=99: > lib/librte_eal/linux/eal/eal_interrupts.c:1048:9: error: missing > initializer for field =E2=80=98events=E2=80=99 of =E2=80=98struct epoll_e= vent=E2=80=99 > [-Werror=3Dmissing-field-initializers] > struct epoll_event ev =3D { }; > ^ > In file included from lib/librte_eal/linu/eal/eal_interrupts.c:15:0: > /usr/include/sys/epoll.h:89:12: note: =E2=80=98events=E2=80=99 declared h= ere > uint32_t events; /* Epoll events */ > ^ Erf, indeed, I ran the tests on a different system than my laptop... Need more coffee, those initializers are always a pain. I'll go with a memset. Best first commit for a release, I suppose. -- David Marchand