From: David Marchand <david.marchand@redhat.com>
To: Thomas Monjalon <thomas@monjalon.net>, Luca Boccassi <bluca@debian.org>
Cc: Neil Horman <nhorman@tuxdriver.com>,
Ferruh Yigit <ferruh.yigit@intel.com>,
Ray Kinsella <mdr@ashroe.eu>,
Cristian Dumitrescu <cristian.dumitrescu@intel.com>,
dpdk stable <stable@dpdk.org>, dev <dev@dpdk.org>,
Eelco Chaudron <echaudro@redhat.com>,
Kevin Traynor <ktraynor@redhat.com>,
Ian Stokes <ian.stokes@intel.com>,
Ilya Maximets <i.maximets@ovn.org>
Subject: Re: [dpdk-stable] [PATCH] meter: move RFC4115 trTCM APIs as none experimental
Date: Fri, 17 Jan 2020 09:27:45 +0100 [thread overview]
Message-ID: <CAJFAV8yRFM2zeTUw+AK8M2c7wNVJ10g1nfQOmTpGykXBve+bCg@mail.gmail.com> (raw)
In-Reply-To: <6957820.jRhZ6ZUK3Y@xps>
On Thu, Jan 16, 2020 at 3:38 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 16/01/2020 13:42, Ferruh Yigit:
> > On 1/16/2020 11:54 AM, Neil Horman wrote:
> > > On Thu, Jan 16, 2020 at 12:25:06PM +0100, David Marchand wrote:
> > >> On Tue, Dec 17, 2019 at 2:08 PM Eelco Chaudron <echaudro@redhat.com> wrote:
> > >>>
> > >>> Moved RFC4115 APIs to none experimental as they have been there
> > >>> since 19.02. Also, these APIs are the same as the none RFC4115 APIs.
> > >>>
> > >>> Signed-off-by: Eelco Chaudron <echaudro@redhat.com>
> > >>
> > >> There is a discussion on the OVS ml at the moment to get these symbols
> > >> in the stable ABI for 19.11.
> > >> I want to understand how this would be done.
> > >>
> > >> - I take this patch in 20.02, these symbols are added in the 20.0.1 ABI.
> > >> On the other hand, the 19.11 release maintains the 20.0 ABI.
> > >>
> > >> Does it mean the backport adds these symbols with the 20.0 version in
> > >> the 19.11 branch?
> > >> Or is 20.0.1 version acceptable / a thing we want?
>
> We cannot have the symbol with different versions in different releases,
> otherwise the compatibility is broken when upgrading.
> So we have no choice, the symbol must have version 20.0.1
> in release 19.11.1, as in release 20.02.
Indeed, good point.
> > >> - These symbol already existed in the 20.0 ABI, versioned as EXPERIMENTAL.
> > >> We can go and remove these entries since we are not bound to preserve
> > >> the experimental APIs.
> > >> But, on the other hand, nothing should prevent us from keeping some
> > >> aliases so that the symbols versioned EXPERIMENTAL are still available
> > >> to existing users.
> > >>
> > > I would say that choice is up to you. If you want to alias them to be nice to
> > > prior users, thats fine by me. But experimental means experimental, and so users
> > > have to be prepared to rebuild when things change, even if that change is
> > > changing the version from experimental to a concrete version.
> > >
> >
> > I would prefer to keep the alias and don't break the existing users, specially
> > for the case experimental API is becoming mature without change.
>
> I agree, it's cool to be nice :)
Luca, opinion?
--
David Marchand
next prev parent reply other threads:[~2020-01-17 8:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 13:07 Eelco Chaudron
2019-12-17 13:52 ` Dumitrescu, Cristian
2020-01-20 15:17 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2020-01-16 11:25 ` [dpdk-stable] " David Marchand
2020-01-16 11:54 ` Neil Horman
2020-01-16 12:42 ` Ferruh Yigit
2020-01-16 14:38 ` Thomas Monjalon
2020-01-17 8:27 ` David Marchand [this message]
2020-01-17 10:46 ` [dpdk-stable] [dpdk-dev] " Luca Boccassi
2020-01-22 13:55 ` [dpdk-stable] " Ray Kinsella
2020-01-30 16:33 ` Ray Kinsella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8yRFM2zeTUw+AK8M2c7wNVJ10g1nfQOmTpGykXBve+bCg@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=bluca@debian.org \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=echaudro@redhat.com \
--cc=ferruh.yigit@intel.com \
--cc=i.maximets@ovn.org \
--cc=ian.stokes@intel.com \
--cc=ktraynor@redhat.com \
--cc=mdr@ashroe.eu \
--cc=nhorman@tuxdriver.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).