From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9BAEFA04DD for ; Fri, 23 Oct 2020 18:32:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 717F95937; Fri, 23 Oct 2020 18:32:36 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id 79B835A5E for ; Fri, 23 Oct 2020 18:32:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603470752; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Mb/Pd19SEFEJF2zFE6UjTkTmFYaliHyAk/Jk44bP0fA=; b=NoL0+gUrluVR/OsUZB7Tww6zNqXKkfhvubR/beWx7QZbq8lSkhrIlGviyVj6bQ9S63MYtf k8OtxSF1/mLxbHTVppP127eCFXRbem20/xT3BVFRHv2Za2w/4uFhNYnoXoJ9JmLZesoT9d 1OtWU/aSXM49L+EA5DhyJRSbDrQf96s= Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-580-ioM0C7bFM_us89mPPSYtWw-1; Fri, 23 Oct 2020 12:32:28 -0400 X-MC-Unique: ioM0C7bFM_us89mPPSYtWw-1 Received: by mail-vs1-f71.google.com with SMTP id z190so513513vsz.22 for ; Fri, 23 Oct 2020 09:32:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Mb/Pd19SEFEJF2zFE6UjTkTmFYaliHyAk/Jk44bP0fA=; b=UGWcg9Zap9JMSJ2vMdtxUFsYMmphtejKn9GfkSGS863V31De9v5ArnKDeET5tMFNXX wSPDNb1CKBpJ8N/n/EN+p8sglTwGNpK5QMenAaTc3CKBHhAV171FP2/ZUCl8NN49iful 2OGRkYSeglx5pOD38cZD7sEJPH6ZpM3fkSh51hhixgD2a0k10hWzHzIibuNyBFnTIIik qOK6Od4LZBNaMIcQRWOOSZldvo3NiFFbM/8twWtALmQ7S+vgS2UJJHDuqG+Kc+TQ1vXv dCdQANRDDIHN+Roa2UqGgM2w6TDhtyOlHxupFWx/PbNI3Eg4AsAlQrCQFkcoiIvDlzNL Yb0w== X-Gm-Message-State: AOAM533dM3cPo28Ji5UvRqEVswCKlq5zzCxACaUvSQxBI5xJb1ruEa/S sbgW2OqXcgWuN8g++F/gJJDpgsmOpPJXhaURfR54loofg7U16RYp3ysUb5i8cJEeyGsVZkLBoyT g0DveL1lxSGsl9c+TjT466qA= X-Received: by 2002:a67:2fca:: with SMTP id v193mr2466136vsv.18.1603470747667; Fri, 23 Oct 2020 09:32:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyt8Y/bdiRh187dKHcIxhHSPG+xY/uz/crfVisDwj/o4J2XVIs1O2kf2ITWCFoKeTYFHV7zLG1afhKiBrybrsU= X-Received: by 2002:a67:2fca:: with SMTP id v193mr2466116vsv.18.1603470747438; Fri, 23 Oct 2020 09:32:27 -0700 (PDT) MIME-Version: 1.0 References: <20201023154457.26776-1-didier.pallard@6wind.com> In-Reply-To: <20201023154457.26776-1-didier.pallard@6wind.com> From: David Marchand Date: Fri, 23 Oct 2020 18:32:16 +0200 Message-ID: To: Didier Pallard Cc: dev , dpdk stable , John Griffin , Fiona Trahe , Deepak Kumar Jain , Olivier Matz , Adrien Mazarguil Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] [PATCH] common/qat: add missing kmod dependency X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Salut Didier, On Fri, Oct 23, 2020 at 5:45 PM Didier Pallard wrote: > > Dependency on kmod needed to manage crypto devices is missing > in qat crypto pmd. > > Cc: stable@dpdk.org > Fixes: 0880c40113ef ("drivers: advertise kmod dependencies in pmdinfo") The Fixes: tag goes first, then Cc:, then empty line. > Signed-off-by: Didier Pallard > --- > drivers/common/qat/qat_device.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/common/qat/qat_device.c b/drivers/common/qat/qat_device.c > index b050ce20e4fc..9fa142b5e5bb 100644 > --- a/drivers/common/qat/qat_device.c > +++ b/drivers/common/qat/qat_device.c > @@ -423,3 +423,4 @@ qat_comp_dev_destroy(struct qat_pci_device *qat_pci_dev __rte_unused) > > RTE_PMD_REGISTER_PCI(QAT_PCI_NAME, rte_qat_pmd); > RTE_PMD_REGISTER_PCI_TABLE(QAT_PCI_NAME, pci_id_qat_map); > +RTE_PMD_REGISTER_KMOD_DEP(QAT_PCI_NAME, "* igb_uio | uio_pci_generic | vfio-pci"); > -- > 2.20.1 > Reviewed-by: David Marchand There are some other drivers that have the issue. If there is a volunteer, we have other drivers with the same issue (but probably worth double checking): $ git grep -l 'drv_flags = RTE_PCI_DRV_NEED_MAPPING' drivers/ |xargs dirname |sort -u|while read dir; do dir=${dir%%/base}; git grep -q RTE_PMD_REGISTER_KMOD_DEP $dir || echo $dir; done drivers/baseband/acc100 drivers/baseband/fpga_5gnr_fec drivers/baseband/fpga_lte_fec drivers/common/qat # done drivers/event/octeontx drivers/event/skeleton drivers/mempool/octeontx drivers/net/avp drivers/net/hinic drivers/net/octeontx drivers/regex/octeontx2 -- David Marchand