From: David Marchand <david.marchand@redhat.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Hemant Agrawal <hemant.agrawal@nxp.com>,
Ferruh Yigit <ferruh.yigit@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] examples/l3fwd: use correct IP reserved address range
Date: Thu, 7 Nov 2019 21:52:47 +0100 [thread overview]
Message-ID: <CAJFAV8yUFsYhATKwbf+TGwW9C8n-BoF1O_BN=7sXmsESp0oijA@mail.gmail.com> (raw)
In-Reply-To: <VI1PR0401MB254118876C3B75B9E2FFC04689790@VI1PR0401MB2541.eurprd04.prod.outlook.com>
Stephen,
Do we want to fix testpmd?
$ git grep 192.*18 origin/master -- app/test-pmd/
origin/master:app/test-pmd/txonly.c:uint32_t tx_ip_src_addr = (192U <<
24) | (18 << 16) | (0 << 8) | 1;
origin/master:app/test-pmd/txonly.c:uint32_t tx_ip_dst_addr = (192U <<
24) | (18 << 16) | (0 << 8) | 2;
Commit bf5b2126bf44 ("app/testpmd: add ability to set Tx IP and UDP parameters")
I will take this patch on the example, for now.
On Wed, Nov 6, 2019 at 6:36 AM Hemant Agrawal <hemant.agrawal@nxp.com> wrote:
>
> > -----Original Message-----
> > From: dev <dev-bounces@dpdk.org> On Behalf Of Stephen Hemminger
> > Sent: Tuesday, November 5, 2019 9:39 PM
> > To: dev@dpdk.org
> > Cc: Stephen Hemminger <stephen@networkplumber.org>; Ferruh Yigit
> > <ferruh.yigit@intel.com>
> > Subject: [dpdk-dev] [PATCH] examples/l3fwd: use correct IP reserved
> > address range
> >
> > The original patch used incorrect subnet range for testing.
> >
> > Fixes: 37afe381bde4 ("examples/l3fwd: use reserved IP addresses")
>
> [Hemant] better to also add Cc: stable@dpdk.org
Yes.
> Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
Applied, thanks.
--
David Marchand
next prev parent reply other threads:[~2019-11-07 20:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191105160921.6951-1-stephen@networkplumber.org>
2019-11-06 5:36 ` Hemant Agrawal
2019-11-07 20:52 ` David Marchand [this message]
2019-11-08 3:24 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8yUFsYhATKwbf+TGwW9C8n-BoF1O_BN=7sXmsESp0oijA@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).