From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2079A4648F for ; Thu, 27 Mar 2025 09:18:13 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E54C240261; Thu, 27 Mar 2025 09:18:12 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id C2C1B40261 for ; Thu, 27 Mar 2025 09:18:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1743063491; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YmHGwFM+7NEgYiE0eDjX0UsO71Fmy7Ihw/Unq0xnL0Q=; b=euBlwoVkGGr8QQI4DDiTwdkayjpRCh/dfdMHunKY6CcvSzX28CX+yEFZOyFP/ESdFnU68a 0IJ1sbE18hTCgoTLiCkdXV2ZX31vxngvo/iO8axlzs9SqqSQgB32jbImjDDVxFCUh8jYFU /MwEoJm1OEN4wIagKYd3RuMxzEcVn5A= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-65-5XgceUncNDicpGynIDNhDA-1; Thu, 27 Mar 2025 04:18:10 -0400 X-MC-Unique: 5XgceUncNDicpGynIDNhDA-1 X-Mimecast-MFC-AGG-ID: 5XgceUncNDicpGynIDNhDA_1743063489 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-549927ec579so333606e87.3 for ; Thu, 27 Mar 2025 01:18:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743063488; x=1743668288; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YmHGwFM+7NEgYiE0eDjX0UsO71Fmy7Ihw/Unq0xnL0Q=; b=Nz4ojqd/Ra1KN6FaDwaF/wYCJqu827+n6stOxkVru4i8mvMvSFnMw1nVbhdolSUN2G xFvQB5mSzX2b2rrOEMXAALV4nRyu/LtgE1UH5CK6sYSy5hFsYLtuNbYqcMLUoyk3kFmj bI+muwxP8+aFmHN24NTGO3jfENLDR++T8HhE6BxvjpHOIpyEGsQ4H4qrW+Omzy9liiBG vYrTUyU4F6exhGrNBTk02WLmZFlsfQJD4Y2d0ojQhOGJ5az47O7vMIw1OxFLbYuf1p0W J54SNN8bqQFz3gO479S4CxqiS9o0Sx/qogEyPltWiTilb30a1fLQ77bbKyu9TR0fj+/w RtRw== X-Forwarded-Encrypted: i=1; AJvYcCXxES5B0eYyAKwP2BT1Dr8VxWaA2E1b6Nv1/8oqSicus45mG1CCoJsD54wmo+NzV7WHPbvzJwo=@dpdk.org X-Gm-Message-State: AOJu0YypH1OrmPtRoPQwA9Ry151fyBB/khu/7T6ByxVXBN+zNhjmnQqN gXIzJE7cMP7xP9t6TDv4lEnSreGf3bFrtFbVyQF5EiNKq+ACVpmREHLwTE4SAMUCIqHxqFvFn6T 2gvBp3M5N0ZESsTKhZD5qGkV07ZRpMJO+g2hN153zFzBRq2bBss+3HpdoPijRQOasfEIv963X0d hq014Ktq9r2k0jbMTDny8= X-Gm-Gg: ASbGncswjd2CPsujZCNmu3pdW8Js1kyX8YfrLhCEeE158NbHDBiNNWLtLHG/CvvNb6s pPbsrm47DEI56Ib9FuBE2olvq+ZHhLPO8825Gor9FSi9JZbsDFpEsf1cQT95F0hEaTn4d8+4Nuk A= X-Received: by 2002:a05:6512:1054:b0:545:3031:40aa with SMTP id 2adb3069b0e04-54b011cdc88mr885947e87.9.1743063488390; Thu, 27 Mar 2025 01:18:08 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFfe1aYwmftAWd3/Mdmwixu9tfebtMftB/I+M7vi1z3UxjAtSWh0c9bohh6E0/wegobNzC43uO9KUAqXrkKaGA= X-Received: by 2002:a05:6512:1054:b0:545:3031:40aa with SMTP id 2adb3069b0e04-54b011cdc88mr885931e87.9.1743063487946; Thu, 27 Mar 2025 01:18:07 -0700 (PDT) MIME-Version: 1.0 References: <20250326103928.1189243-1-david.marchand@redhat.com> In-Reply-To: <20250326103928.1189243-1-david.marchand@redhat.com> From: David Marchand Date: Thu, 27 Mar 2025 09:17:56 +0100 X-Gm-Features: AQ5f1JpQIz3aHO0HSngTwZzIMI1q9ZWSxEQQatop0G1XVQ7_0Nc72qRe0Rzs9-Y Message-ID: Subject: Re: [PATCH] acl: fix build with GCC 15 on aarch64 To: Konstantin Ananyev , Bruce Richardson , Wathsala Vithanage Cc: dev@dpdk.org, bluca@debian.org, stable@dpdk.org, David Christensen X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: qymi9zghT19pwxn2mTc2hpoaUy1WaEWqQngsCSxribY_1743063489 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi guys, On Wed, Mar 26, 2025 at 11:40=E2=80=AFAM David Marchand wrote: > > Caught in OBS for Fedora Rawhide on aarch64: > > [ 198s] In file included from ../lib/acl/acl_run_neon.h:7, > [ 198s] from ../lib/acl/acl_run_neon.c:5: > [ 198s] In function =E2=80=98alloc_completion=E2=80=99, > [ 198s] inlined from =E2=80=98acl_start_next_trie=E2=80=99 at > ../lib/acl/acl_run.h:140:24, > [ 198s] inlined from =E2=80=98search_neon_4.isra=E2=80=99 at > ../lib/acl/acl_run_neon.h:239:20: > [ 198s] ../lib/acl/acl_run.h:93:25: error: =E2=80=98cmplt=E2=80=99 may b= e used > uninitialized [-Werror=3Dmaybe-uninitialized] > [ 198s] 93 | if (p[n].count =3D=3D 0) { > [ 198s] | ~~~~^~~~~~ > [ 198s] ../lib/acl/acl_run_neon.h: In function =E2=80=98search_neon_4.is= ra=E2=80=99: > [ 198s] ../lib/acl/acl_run_neon.h:230:27: note: =E2=80=98cmplt=E2=80=99 = declared here > [ 198s] 230 | struct completion cmplt[4]; > [ 198s] | ^~~~~ > > The code was resetting sequentially cmpl[].count at the exact index that > later call to alloc_completion uses. > While this code seems correct, GCC 15 does not understand this (probably > when applying some optimisations). > > Instead, reset cmpl[].count all at once in acl_set_flow, and cleanup the > various vectorized implementations accordingly. > > Bugzilla ID: 1678 > Cc: stable@dpdk.org > > Signed-off-by: David Marchand No pressure, but could you have a look? This is for fixing some build issue in the CI (affecting main, at least). --=20 David Marchand