From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B8173A0C47 for ; Tue, 6 Jul 2021 15:50:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A97C0413A2; Tue, 6 Jul 2021 15:50:52 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 9A154413A2 for ; Tue, 6 Jul 2021 15:50:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625579450; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sr67QlDvyUxSO5IitUJkXK30DFgHUXf+phlY2xTr7xM=; b=AA3VinJ+CX3x1XSDePVnymLzMTR7U4Lrq7Eo03aX13u9Aaha9B0hrUGj6GzeO5H2qHVhTk rDYydf4+XJTFixj9fmBBPYAUD1+l23oHWNF7HbxgLMnA4S3mo8+fnoGo7vajnQ1Ap0L69o F1E+vZTGY5waa8XtkPkB+t4sKuL5YD8= Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-259-Yb4xC1HrPViAU1EzhDYm8Q-1; Tue, 06 Jul 2021 09:50:47 -0400 X-MC-Unique: Yb4xC1HrPViAU1EzhDYm8Q-1 Received: by mail-vs1-f70.google.com with SMTP id e10-20020a0561020dcab02902889728ef8eso2100149vst.14 for ; Tue, 06 Jul 2021 06:50:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sr67QlDvyUxSO5IitUJkXK30DFgHUXf+phlY2xTr7xM=; b=Vis3xAeZropAZK95y9s/BU1VOExy7pO6V6LFKWbIgrlcBankzE83x5QqgJIIJeunK1 ZVY9mrwiXbpV5cAfx4Bxw3pF9Xb2MQYHdR6A6EfRaOJvpVA08bDOUWjNCGjXJqK9whW2 2GWymILWuTxzL/v0CFcgaKRc3GZ7pazokNXkdu/c71dWrhmQVcytLGM2JQwIsI1c9Lbl xk90P7jm4r7c9Hkg1lQJO/1o4wAzRej5KaVkYTtgCDUvK8yd08fIAORc9anVyO7pgHIT GTD04McUKpDpKONAefY6ZgCScVoMuFimBQOw3redf9SrLZ6dkE8I72ulluoLY0lVAcPH v8bg== X-Gm-Message-State: AOAM533txe0tJqu2K0mAYZ/nxJFvEYUc3TfkNaf+wQqbswsXCA56eT5I nVW06MkNdA/iisTcqX/+m7/MmWYZrwcTIe1Rbtr0MzDQhM5DRHVqido8TmroDi5VRQhV8qC+XC5 Ts0kFsGvdDiQdlsfFF24Juhs= X-Received: by 2002:a1f:26cd:: with SMTP id m196mr13638899vkm.9.1625579447225; Tue, 06 Jul 2021 06:50:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzKqtvAxRWy1mJliw8H39hrr6Jgt5HEf7Nuz66JYgiANay1cW+ywkZtijfy7u5xVbEbjxMvCz8wlihJXFLpHz8= X-Received: by 2002:a1f:26cd:: with SMTP id m196mr13638874vkm.9.1625579446991; Tue, 06 Jul 2021 06:50:46 -0700 (PDT) MIME-Version: 1.0 References: <20210706085643.5088-1-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Tue, 6 Jul 2021 15:50:35 +0200 Message-ID: To: "Wang, Haiyue" Cc: "dev@dpdk.org" , "stable@dpdk.org" , "Yang, Qiming" , "Zhang, Qi Z" , "Stillwell Jr, Paul M" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] [PATCH] net/ice: fix memzone leak when firmware is missing X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Tue, Jul 6, 2021 at 2:53 PM Wang, Haiyue wrote: > > In such a case a single label should be enough, right? > > Yes, since pf->proto_xtr = NULL can be 'freed' safely. Ah ok, I thought proto_xtr was initialised earlier and I had missed the ice_pf_sw_init() call. I'll go with your suggestion. Thanks. -- David Marchand