From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DF0C4471F1 for ; Mon, 12 Jan 2026 08:59:01 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D2463406B6; Mon, 12 Jan 2026 08:59:01 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id D0D9C40693 for ; Mon, 12 Jan 2026 08:58:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768204739; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=q1A5KlktpdoNrAKG3u7rmMX3ThyuH1/hkv7v5pocO+c=; b=e2woua/FjCllYh76udIh/Gt2fH/c6wyGVIWDc5aA34TrMWdwYLU/WEhtqfNbIXKhLzSgTF 69l/wbq5soPamIJRSvsZALTcgR1fLgjahQY6xTSGrRC+yAVF+ZM2HxmhpivmtkcF3Ftdoy pAfzjJyyJkq8gba8p508WjiSt+4mCtY= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-383-vfq_ZfKvMFqx2fbp8AV8FQ-1; Mon, 12 Jan 2026 02:58:55 -0500 X-MC-Unique: vfq_ZfKvMFqx2fbp8AV8FQ-1 X-Mimecast-MFC-AGG-ID: vfq_ZfKvMFqx2fbp8AV8FQ_1768204734 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-59b6fb01675so5650651e87.2 for ; Sun, 11 Jan 2026 23:58:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768204734; x=1768809534; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=q1A5KlktpdoNrAKG3u7rmMX3ThyuH1/hkv7v5pocO+c=; b=Q3UhfXnX75HP3smj6yN2RdEch+IyuebUbDkJIPD5FW85P5mDUNK7/6VFKkn5JAuJ/m jF8eGwNrIGeddngBZJISIwq25mgQ42Owq3wdusydG1W705hX2jtKG25Divh0acNwp8Nm H1WSezfC5+FiKs2cL6qe4Lbhtf7s3yxke7sIdYKo/YqBipmlGjgQjCbksSqoen3lJSwJ f2TK63tT7YaaC2yPXAl6NwsUpbOV5IxNoFeJgac7VElVZHcTdKNRyedwYhHtUdRQyqI1 ej71Bef73U/AgirHK82KgFiAPbYJkWgrD6J9c4vjXX76ZqY7/cW9Aodq3npKJhlufL7B BTVQ== X-Forwarded-Encrypted: i=1; AJvYcCVehNbddRDVnBRWMhhVGRDpw07pXxkDckB7qzLnR+kKRj52qHPlGTlORMkl3K9Yt65wBuuArMM=@dpdk.org X-Gm-Message-State: AOJu0YxfLCUPcGsV8S1mlMCnY39UVsoyiaCOOm4lfqS1fbUCJ5nUOKMB 7SuFNQRKYLv7g5PfGD9Cr08GDo2oXDS8xxgGykVFTvV3lWmm2lI09S89A2EbBZhg2lCWZ4iAZ7k +cz3WTk4U1QH2cDaaCDTavwKYVIW5/t3N8CAaaqZuVQa+Wyc0k1+pS/6cWjZmoTcZMOizgGp1oc A/I5ufeA/tVMJjY4Kq6pjxLHM= X-Gm-Gg: AY/fxX4JX+YJyPQrPcVh+zPmlqW/2veBdRcDRUg7fQ7Yipfd++9NrGP6KaceXJ2cDJz KDidZVQyza8HpVv1iT18lw155JurIXRauMbwAndvA7NuD0Jx8VpOky1X6g/wAlphdJ3Zp7i1QFQ KR6lCtZanuSo2d2nXPA6L6eT9Vj2nZYOxr8LNH1YckeBNBn2Ow/2rSImUwaezOHX29iiex X-Received: by 2002:a05:6512:3d08:b0:595:9d6b:1178 with SMTP id 2adb3069b0e04-59b6f048a3emr5837432e87.40.1768204734241; Sun, 11 Jan 2026 23:58:54 -0800 (PST) X-Google-Smtp-Source: AGHT+IH149JquUcnokgn5nXZAzYgBOEECbUJ2xeAwkyNMebxquwQOsFY2gx1P8T7akiIXQNpA9AsKXLoQw4VaGYYPyU= X-Received: by 2002:a05:6512:3d08:b0:595:9d6b:1178 with SMTP id 2adb3069b0e04-59b6f048a3emr5837416e87.40.1768204733845; Sun, 11 Jan 2026 23:58:53 -0800 (PST) MIME-Version: 1.0 References: <20260105125441.50447-1-david.marchand@redhat.com> <20260111170350.6fa88e03@phoenix.local> In-Reply-To: <20260111170350.6fa88e03@phoenix.local> From: David Marchand Date: Mon, 12 Jan 2026 08:58:42 +0100 X-Gm-Features: AZwV_Qg8_iP70SRd-FdAPdFVuG9zFkYUfiaxXGH8GDGQOZ38sPUTbUB4u__8GBE Message-ID: Subject: Re: [PATCH] net/af_xdp: fix external mbuf transmit To: Stephen Hemminger , =?UTF-8?Q?Morten_Br=C3=B8rup?= Cc: dev@dpdk.org, stable@dpdk.org, Ciara Loftus , Maryam Tahhan , Xiaolong Ye , Kevin Laatz , Thomas Monjalon X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: rdTAlfz1dxoHuJwrY4FGaIFB5lZBHYI-vjyZ2opR2wU_1768204734 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hello, On Mon, 12 Jan 2026 at 02:04, Stephen Hemminger wrote: > #### Warning (Minor) > > **Implicit boolean comparison:** The `RTE_MBUF_DIRECT(mbuf)` macro returns an integer-like value (0 or non-zero). Per DPDK guidelines, explicit comparison with zero is preferred for integers: > > ```c > // Suggested (strict interpretation): > if (RTE_MBUF_DIRECT(mbuf) != 0 && mbuf->pool == umem->mb_pool) { > ``` > > However, this macro is semantically boolean and is commonly used in direct form throughout DPDK. This is a stylistic preference, not a blocking issue. All callers in DPDK are using this macro as a boolean, and I found no opensource project doing differently. I would either fix the macro or change nothing at all. -- David Marchand