From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B7A17A034C for ; Wed, 21 Dec 2022 11:50:34 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A8F3642D1D; Wed, 21 Dec 2022 11:50:34 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id B1D3942D19 for ; Wed, 21 Dec 2022 11:50:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1671619832; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fre2/V3Ir8mRcnlZ3dXGdHzyVQl07DlEuZ4UcKLf48o=; b=Nii35cVqX4VDPEkDNXsyPirZYpcWfzS2TD2mRHwwHWGuRTOffaeQBnpQ9/EHEdHfwSJbAx p7FOwpDU+LziDbovkLqeqRZyaRrTJowf3fQ7RkqL5KI2NDdRBWAr6OOzZgavbLbK80og24 ah7+CJWTavva+oTBPgRdl6Zq9Hj9Ztw= Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-445-7wN_69qVMCWoTijsDpWkoQ-1; Wed, 21 Dec 2022 05:50:29 -0500 X-MC-Unique: 7wN_69qVMCWoTijsDpWkoQ-1 Received: by mail-pf1-f197.google.com with SMTP id u3-20020a056a00124300b0056d4ab0c7cbso8238805pfi.7 for ; Wed, 21 Dec 2022 02:50:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fre2/V3Ir8mRcnlZ3dXGdHzyVQl07DlEuZ4UcKLf48o=; b=YY479/1Cg/yryRa1TUySz2+T3KFWnt1cVJ8Wk85bHY6JNMGgBgcHVb5m/cknrELVzz CgqETQdxnoXmVNGgO13WWjqNZ5uMbrzxfcf/Ha+GW/rkzLb5KicQ2thOJ8hp5tIHbaW9 2cz5Rh5xfMA5XrJkNyneZQcnZi/kkEZh/pS9RYsbTO+x7uNzaMe1tQpOsw6K78c/zqQF nMRcYATuyEW2Tk9yDKMPIK/5eiZbJYlt8E8RL5J8qVkvoEHj/WAfBm0wCn0rCPGWLxsv 2PophmqtN6rRHoXgXCH5X9vUBZ12+TI1VZbYtzhNfZqrODivIBFCsM9Uzl9WoCeX4j3G KhVA== X-Gm-Message-State: AFqh2kqyvm7ySH/cVngPHU3ZmgBX24YGyppKsSnc+gj01AHgTEowCOVw ZFwEQB6hMelSGaH0nqdSPINJFQLv7CwT/v0+mlfPXlx5UKc0oiM0Z6wYp+mci8iNh0ZghHi5PUy jyDkZFESkCkIFadXoz3k3sNE= X-Received: by 2002:a63:6501:0:b0:479:4c30:9cb4 with SMTP id z1-20020a636501000000b004794c309cb4mr76215pgb.426.1671619828132; Wed, 21 Dec 2022 02:50:28 -0800 (PST) X-Google-Smtp-Source: AMrXdXv7/M5/MrmzIWP1Wif2yCzG7jwS4xvI4CwbFwtLNv5SkX7ZNpWjP7sVAwgBNJKrhUNRdZiK6G+v+85AJR4T/QI= X-Received: by 2002:a63:6501:0:b0:479:4c30:9cb4 with SMTP id z1-20020a636501000000b004794c309cb4mr76199pgb.426.1671619827848; Wed, 21 Dec 2022 02:50:27 -0800 (PST) MIME-Version: 1.0 References: <20221117065726.277672-1-kaisenx.you@intel.com> <3ad04278-59c0-0c60-5c8c-9e57f33bb0de@amd.com> In-Reply-To: From: David Marchand Date: Wed, 21 Dec 2022 11:50:16 +0100 Message-ID: Subject: Re: [PATCH] net/iavf:fix slow memory allocation To: "You, KaisenX" Cc: Ferruh Yigit , "dev@dpdk.org" , "Burakov, Anatoly" , "stable@dpdk.org" , "Yang, Qiming" , "Zhou, YidingX" , "Wu, Jingjing" , "Xing, Beilei" , "Zhang, Qi Z" , Luca Boccassi , "Mcnamara, John" , Kevin Traynor X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Wed, Dec 21, 2022 at 10:12 AM You, KaisenX wrote= : > > -----Original Message----- > > From: David Marchand > > Sent: 2022=E5=B9=B412=E6=9C=8820=E6=97=A5 18:33 > > To: You, KaisenX > > Cc: Ferruh Yigit ; dev@dpdk.org; Burakov, Anatoly > > ; stable@dpdk.org; Yang, Qiming > > ; Zhou, YidingX ; Wu, > > Jingjing ; Xing, Beilei ;= Zhang, > > Qi Z ; Luca Boccassi ; Mcnamara= , > > John ; Kevin Traynor > > Subject: Re: [PATCH] net/iavf:fix slow memory allocation > > > > On Tue, Dec 20, 2022 at 11:12 AM You, KaisenX > > wrote: > > > > I tried to play a bit with a E810 nic on a dual numa and I can't se= e > > > > anything wrong for now. > > > > Can you provide a simple and small reproducer of your issue? > > > > > > > > Thanks. > > > > > > > This is my environment: > > > Enter "lscpu" on the command line: > > > NUMA: > > > NUMA node(s): 2 > > > NUMA node0 CPU(S) : 0-27,56-83 > > > NUMA node1 CPU(S) : 28-55,84-111 > > > > > > List the steps to reproduce the issue: > > > > > > 1. create vf and blind to dpdk > > > echo 1 > /sys/bus/pci/devices/0000\:ca\:00.0/sriov_ numvfs > > > ./usertools/dpdk-devbind. py -b vfio-pci 0000:ca:01.0 2. launch > > > testpmd ./x86_ 64-native-linuxapp-clang/app/dpdk-testpmd -l 28-48 -n = 4 > > > -a 0000:ca:01.0 --file-prefix=3Ddpdk_ 525342_ 20221104042659 -- -i > > > --rxq=3D256 --txq=3D256 > > > --total-num-mbufs=3D500000 > > > > > > Parameter Description: > > > "-l 28-48":The range of parameter values after "-l" must be on "NUMA > > node1 CPU(S)" > > > "0000:ca:01.0":inset on node1 > > - Back to your topic. > > Can you try this simple hack: > > > > diff --git a/lib/eal/common/eal_common_thread.c > > b/lib/eal/common/eal_common_thread.c > > index c5d8b4327d..92160c7fa6 100644 > > --- a/lib/eal/common/eal_common_thread.c > > +++ b/lib/eal/common/eal_common_thread.c > > @@ -253,6 +253,7 @@ static void *ctrl_thread_init(void *arg) > > void *routine_arg =3D params->arg; > > > > __rte_thread_init(rte_lcore_id(), cpuset); > > + RTE_PER_LCORE(_socket_id) =3D SOCKET_ID_ANY; > > params->ret =3D pthread_setaffinity_np(pthread_self(), sizeof(*= cpuset), > > cpuset); > > if (params->ret !=3D 0) { > > > Thanks for your advice. > > But this issue still exists after I tried. Ok, I think I understand what is wrong... but I am still guessing as I am not sure what your "issue" is. Can you have a try with: https://patchwork.dpdk.org/project/dpdk/patch/20221221104858.296530-1-david= .marchand@redhat.com/ Thanks. --=20 David Marchand