From: David Marchand <david.marchand@redhat.com>
To: Lance Richardson <lance.richardson@broadcom.com>
Cc: Declan Doherty <declan.doherty@intel.com>,
Pablo de Lara <pablo.de.lara.guarch@intel.com>,
dev <dev@dpdk.org>, dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH] app/test: fix IPv6 header initialization
Date: Mon, 5 Jul 2021 10:22:11 +0200 [thread overview]
Message-ID: <CAJFAV8z0D1ZJkzHoE6+u9LMZOj_QTrtJFTpMdX5vK9TPifWU7Q@mail.gmail.com> (raw)
In-Reply-To: <20210326163732.763862-1-lance.richardson@broadcom.com>
On Fri, Mar 26, 2021 at 5:37 PM Lance Richardson
<lance.richardson@broadcom.com> wrote:
>
> Fix two issues found when writing PMD unit tests for HW ptype and
> L4 checksum offload:
>
> - The version field in the IPv6 header was being set to zero,
> which prevented hardware from recognizing it as IPv6. The
> IP version field is now set to six.
> - The payload_len field was being initialized using host byte
> order, which (among other things) resulted in incorrect L4
> checksum computation. The payload_len field is now set using
> network (big-endian) byte order.
>
> Fixes: 92073ef961ee ("bond: unit tests")
> Cc: stable@dpdk.org
>
> Signed-off-by: Lance Richardson <lance.richardson@broadcom.com>
Reviewed-by: David Marchand <david.marchand@redhat.com>
Applied, thanks.
--
David Marchand
prev parent reply other threads:[~2021-07-05 8:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 16:37 Lance Richardson
2021-05-11 14:31 ` David Marchand
2021-05-11 14:42 ` Lance Richardson
2021-06-21 12:40 ` Lance Richardson
2021-06-21 12:49 ` David Marchand
2021-07-05 8:22 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8z0D1ZJkzHoE6+u9LMZOj_QTrtJFTpMdX5vK9TPifWU7Q@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=lance.richardson@broadcom.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).