From: David Marchand <david.marchand@redhat.com>
To: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
Cc: Maxime Coquelin <maxime.coquelin@redhat.com>,
"dev@dpdk.org" <dev@dpdk.org>, Chenbo Xia <chenbox@nvidia.com>,
Fan Zhang <fanzhang.oss@gmail.com>,
Jay Zhou <jianjay.zhou@huawei.com>,
Anoob Joseph <anoobj@marvell.com>,
Akhil Goyal <gakhil@marvell.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [EXTERNAL] Re: [v6 1/5] vhost: skip crypto op fetch before vring init
Date: Fri, 28 Feb 2025 09:48:25 +0100 [thread overview]
Message-ID: <CAJFAV8zDrLGrjk2F5EXqzGJUytQdnFnv5b1y5xr01TfYj0dRLA@mail.gmail.com> (raw)
In-Reply-To: <BY3PR18MB470536F2A1329EE6732E332CCBCD2@BY3PR18MB4705.namprd18.prod.outlook.com>
On Thu, Feb 27, 2025 at 7:07 PM Gowrishankar Muthukrishnan
<gmuthukrishn@marvell.com> wrote:
> > > Ha, and also you should be able to remove:
> > > __rte_no_thread_safety_analysis /* FIXME: requires iotlb_lock? */ in
> > > vhost_crypto_process_one_req() once implemented.
> > >
> >
> Removing it would break compilation for thread safety flag.
> http://mails.dpdk.org/archives/test-report/2025-February/857515.html
>
> It is due to local vc_req that is passed to func that requires iotlb lock
> In vc_req->vq. Even though vc_req->vq is locked vq, GCC does not allow it, as I understand.
*cough* clang.
>
> vc_req = &data_req;
> vc_req->desc_idx = desc_idx;
> vc_req->dev = vcrypto->dev;
> vc_req->vq = vq;
The annotations won't handle this wrapping in the vc_req object.
Just pass a vq object rather than the vc_req (which I don't see little
point in having in the first place..) and adjust annotations.
--
David Marchand
next prev parent reply other threads:[~2025-02-28 8:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1740594750.git.gmuthukrishn@marvell.com>
2025-02-26 18:43 ` Gowrishankar Muthukrishnan
2025-02-27 9:15 ` Maxime Coquelin
2025-02-27 9:19 ` Maxime Coquelin
2025-02-27 13:15 ` [EXTERNAL] " Gowrishankar Muthukrishnan
2025-02-27 18:07 ` Gowrishankar Muthukrishnan
2025-02-28 8:48 ` David Marchand [this message]
2025-02-28 9:40 ` Maxime Coquelin
2025-02-28 13:59 ` Gowrishankar Muthukrishnan
2025-02-28 15:16 ` Maxime Coquelin
2025-02-28 13:53 ` Gowrishankar Muthukrishnan
2025-02-26 18:43 ` [v6 3/5] examples/vhost_crypto: fix user callbacks Gowrishankar Muthukrishnan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8zDrLGrjk2F5EXqzGJUytQdnFnv5b1y5xr01TfYj0dRLA@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=anoobj@marvell.com \
--cc=chenbox@nvidia.com \
--cc=dev@dpdk.org \
--cc=fanzhang.oss@gmail.com \
--cc=gakhil@marvell.com \
--cc=gmuthukrishn@marvell.com \
--cc=jianjay.zhou@huawei.com \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).