From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ED7AE462E3 for ; Fri, 28 Feb 2025 09:48:41 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E68CB4028C; Fri, 28 Feb 2025 09:48:41 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 7937D4028C for ; Fri, 28 Feb 2025 09:48:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740732520; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E/fbpxWzOFzwciGIUlJYHSSbfm3GwdAT4uOaIwUFPEk=; b=SdceWFgjKNe53MWx7yOkxXON22buSkxBTi6Dk1vd4bmwYRX20Q2NIr6M1BhMUAA//5d2Uy 3j6pbIF+8e3/RldQwmZFNHJomPwr3r1kHf+6JQJ1FABdavPWJ9sWLyJ9Hq8DK8GBG5Sa/Q pSgZks/DVl+ERio1/PSd6Q+OcTeQEk8= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-581-qznKCpmrN9S1p7zTcJm6XQ-1; Fri, 28 Feb 2025 03:48:38 -0500 X-MC-Unique: qznKCpmrN9S1p7zTcJm6XQ-1 X-Mimecast-MFC-AGG-ID: qznKCpmrN9S1p7zTcJm6XQ_1740732517 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-54954f6d613so132805e87.3 for ; Fri, 28 Feb 2025 00:48:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740732517; x=1741337317; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=E/fbpxWzOFzwciGIUlJYHSSbfm3GwdAT4uOaIwUFPEk=; b=RO5q6ScjwyxRxZtkjyUlYxVi4mggZtce7D2H7/dcjo8CufebMtuvMC5ai2pFXU9z5j aWliF829OOosEd1XVErFSQUvJ8xGd8QbgUaBrr0AsUNg61U79x6G2lRC03stvxM1KQXC BGGfhUrgZw1G8I81s3q+wSLOK/6QXawlYdmXJrANM1zJCqVg9sY/2UsYiApRqTrWz57O D3Nf6FMsF0kPPG/tIZT6VPQbn/00sFHGCHOLkJA4BeHPVX9xDV0S9a1OzW+sXvUm4bvw YbpvyJc9bK8Q+rkQ93Z3xsGL8L6N0mLjSbuwJtu0ESYtqoxHmjPObJdmO1VmtfWi2irU 6jRw== X-Forwarded-Encrypted: i=1; AJvYcCW32A78umcpmH+Z7joo9Uc0RJs3q9G/cTYGdQehfZTswL+UIZximBRZnIPNJ81yBKUkk3ybvuM=@dpdk.org X-Gm-Message-State: AOJu0YzbiJZqu9knnO3RyzIhndAJJJB0WWuiuQ46qkJMWVQ3eIdRBjm8 VrUL3Gkf9SOt913qTdZludSWy6Fy4m8pjOSRofJ/cIQcAAcJbQFj5HbDlG7dos1YjYLVDdU3fzi eHWDEniTM24oHt8fksL7UNQ0zF9HT+A+U0B8M6v/daecHOa/tOjUTbxG4Ybi98N7zSg9Eq/NP01 nXuKR/jOf0XF9TO+N69nE= X-Gm-Gg: ASbGncuoLYwhO8Lb01YIBcjn6XHfsCt8n6yMKRIIrOQ5+dl84sNib13J/OG2y3MCjBu xAXo5w71Ax+qlwF+ggefZV5K0EG7X7TstPZHWP2KbGqApdTjxfaMQh75fpOg4ZCR+PQISGSSEzY Q= X-Received: by 2002:a05:6512:398e:b0:545:8a1:5377 with SMTP id 2adb3069b0e04-5494c1168cfmr891057e87.2.1740732516798; Fri, 28 Feb 2025 00:48:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IGX5okV75kr8463O5cQCYlFZNsBEFPWOuFt9InfryErxywPnzlI3PsWS54S9uvFsa7mjinryq9NQhSbEmZNeZY= X-Received: by 2002:a05:6512:398e:b0:545:8a1:5377 with SMTP id 2adb3069b0e04-5494c1168cfmr891049e87.2.1740732516440; Fri, 28 Feb 2025 00:48:36 -0800 (PST) MIME-Version: 1.0 References: <0784f44b63f6161ac8716644acfea979704eca39.1740594750.git.gmuthukrishn@marvell.com> <81fac570-cdd7-45f7-b209-ce999d5c3d0e@redhat.com> In-Reply-To: From: David Marchand Date: Fri, 28 Feb 2025 09:48:25 +0100 X-Gm-Features: AQ5f1JpmKAZ0p6PNxTjh5Y084Ow-fhna6zab9kXLXnu4b7S-M65lLIb1qI3FARY Message-ID: Subject: Re: [EXTERNAL] Re: [v6 1/5] vhost: skip crypto op fetch before vring init To: Gowrishankar Muthukrishnan Cc: Maxime Coquelin , "dev@dpdk.org" , Chenbo Xia , Fan Zhang , Jay Zhou , Anoob Joseph , Akhil Goyal , "stable@dpdk.org" X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: UEQ_Kf5Ui8Ivdva45Uf29GlUz4B78OGYWGODmhMsHms_1740732517 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Thu, Feb 27, 2025 at 7:07=E2=80=AFPM Gowrishankar Muthukrishnan wrote: > > > Ha, and also you should be able to remove: > > > __rte_no_thread_safety_analysis /* FIXME: requires iotlb_lock? */ in > > > vhost_crypto_process_one_req() once implemented. > > > > > > Removing it would break compilation for thread safety flag. > http://mails.dpdk.org/archives/test-report/2025-February/857515.html > > It is due to local vc_req that is passed to func that requires iotlb lock > In vc_req->vq. Even though vc_req->vq is locked vq, GCC does not allow it= , as I understand. *cough* clang. > > vc_req =3D &data_req; > vc_req->desc_idx =3D desc_idx; > vc_req->dev =3D vcrypto->dev; > vc_req->vq =3D vq; The annotations won't handle this wrapping in the vc_req object. Just pass a vq object rather than the vc_req (which I don't see little point in having in the first place..) and adjust annotations. --=20 David Marchand