patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH] doc/guides: fix reference to x32 architecture
@ 2020-10-22  8:01 David Marchand
  2020-10-22  8:25 ` Bruce Richardson
  0 siblings, 1 reply; 3+ messages in thread
From: David Marchand @ 2020-10-22  8:01 UTC (permalink / raw)
  To: dev; +Cc: thomas, bruce.richardson, stable

There is no CONFIG_RTE_ARCH_X86_64_32.
The original intention was probably to refer to x32.

Fixes: 36032e46be40 ("doc: add coding style")
Cc: stable@dpdk.org

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 doc/guides/contributing/design.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/guides/contributing/design.rst b/doc/guides/contributing/design.rst
index 5fe7f63942..54dad08846 100644
--- a/doc/guides/contributing/design.rst
+++ b/doc/guides/contributing/design.rst
@@ -47,7 +47,7 @@ Per Architecture Sources
 The following config options can be used:
 
 * ``CONFIG_RTE_ARCH`` is a string that contains the name of the architecture.
-* ``CONFIG_RTE_ARCH_I686``, ``CONFIG_RTE_ARCH_X86_64``, ``CONFIG_RTE_ARCH_X86_64_32`` or ``CONFIG_RTE_ARCH_PPC_64`` are defined only if we are building for those architectures.
+* ``CONFIG_RTE_ARCH_I686``, ``CONFIG_RTE_ARCH_X86_64``, ``CONFIG_RTE_ARCH_X86_X32`` or ``CONFIG_RTE_ARCH_PPC_64`` are defined only if we are building for those architectures.
 
 Per Execution Environment Sources
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-- 
2.23.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [PATCH] doc/guides: fix reference to x32 architecture
  2020-10-22  8:01 [dpdk-stable] [PATCH] doc/guides: fix reference to x32 architecture David Marchand
@ 2020-10-22  8:25 ` Bruce Richardson
  2020-10-22  8:32   ` David Marchand
  0 siblings, 1 reply; 3+ messages in thread
From: Bruce Richardson @ 2020-10-22  8:25 UTC (permalink / raw)
  To: David Marchand; +Cc: dev, thomas, stable

On Thu, Oct 22, 2020 at 10:01:43AM +0200, David Marchand wrote:
> There is no CONFIG_RTE_ARCH_X86_64_32.
> The original intention was probably to refer to x32.
> 
> Fixes: 36032e46be40 ("doc: add coding style")
> Cc: stable@dpdk.org
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>  doc/guides/contributing/design.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/doc/guides/contributing/design.rst b/doc/guides/contributing/design.rst
> index 5fe7f63942..54dad08846 100644
> --- a/doc/guides/contributing/design.rst
> +++ b/doc/guides/contributing/design.rst
> @@ -47,7 +47,7 @@ Per Architecture Sources
>  The following config options can be used:
>  
>  * ``CONFIG_RTE_ARCH`` is a string that contains the name of the architecture.
> -* ``CONFIG_RTE_ARCH_I686``, ``CONFIG_RTE_ARCH_X86_64``, ``CONFIG_RTE_ARCH_X86_64_32`` or ``CONFIG_RTE_ARCH_PPC_64`` are defined only if we are building for those architectures.
> +* ``CONFIG_RTE_ARCH_I686``, ``CONFIG_RTE_ARCH_X86_64``, ``CONFIG_RTE_ARCH_X86_X32`` or ``CONFIG_RTE_ARCH_PPC_64`` are defined only if we are building for those architectures.
>  

With make gone, I don't believe that there is an RTE_ARCH_X86_X32 now
either.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [PATCH] doc/guides: fix reference to x32 architecture
  2020-10-22  8:25 ` Bruce Richardson
@ 2020-10-22  8:32   ` David Marchand
  0 siblings, 0 replies; 3+ messages in thread
From: David Marchand @ 2020-10-22  8:32 UTC (permalink / raw)
  To: Bruce Richardson; +Cc: dev, Thomas Monjalon, dpdk stable

On Thu, Oct 22, 2020 at 10:26 AM Bruce Richardson
<bruce.richardson@intel.com> wrote:
> > diff --git a/doc/guides/contributing/design.rst b/doc/guides/contributing/design.rst
> > index 5fe7f63942..54dad08846 100644
> > --- a/doc/guides/contributing/design.rst
> > +++ b/doc/guides/contributing/design.rst
> > @@ -47,7 +47,7 @@ Per Architecture Sources
> >  The following config options can be used:
> >
> >  * ``CONFIG_RTE_ARCH`` is a string that contains the name of the architecture.
> > -* ``CONFIG_RTE_ARCH_I686``, ``CONFIG_RTE_ARCH_X86_64``, ``CONFIG_RTE_ARCH_X86_64_32`` or ``CONFIG_RTE_ARCH_PPC_64`` are defined only if we are building for those architectures.
> > +* ``CONFIG_RTE_ARCH_I686``, ``CONFIG_RTE_ARCH_X86_64``, ``CONFIG_RTE_ARCH_X86_X32`` or ``CONFIG_RTE_ARCH_PPC_64`` are defined only if we are building for those architectures.
> >
>
> With make gone, I don't believe that there is an RTE_ARCH_X86_X32 now
> either.

As Thomas pointed offlist, this should go with Ciara series anyway.
I'll drop this patch.


-- 
David Marchand


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-10-22  8:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-22  8:01 [dpdk-stable] [PATCH] doc/guides: fix reference to x32 architecture David Marchand
2020-10-22  8:25 ` Bruce Richardson
2020-10-22  8:32   ` David Marchand

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git