From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <stable-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8943FA0A0C for <public@inbox.dpdk.org>; Thu, 8 Apr 2021 16:05:12 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7F30C141053; Thu, 8 Apr 2021 16:05:12 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 58EE114101B for <stable@dpdk.org>; Thu, 8 Apr 2021 16:05:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617890709; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WShkWwVNmKN6WtnGZ3jr3EQA7MOt3ojQv5NNlh24yTc=; b=gF9BZBlT/2jxg17Q4lFsG9QoNwoWo7FuN9X7947JDcTOh68Ja4G0rMGTnKi2NKzwWBkMYu zkzBblUJcgoDK42Pc55UwZnzAHbWhGyM/vYKQ1c0x2hiv6gOzQYIJGRKE7QLXZKz0jqmti FQmUuRIA66mzxzHe3uFij1PIAGfbLNs= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-569-qQXVvGaoN0O4hbUPvkcFQg-1; Thu, 08 Apr 2021 10:05:07 -0400 X-MC-Unique: qQXVvGaoN0O4hbUPvkcFQg-1 Received: by mail-lj1-f200.google.com with SMTP id t28so760757ljo.11 for <stable@dpdk.org>; Thu, 08 Apr 2021 07:05:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WShkWwVNmKN6WtnGZ3jr3EQA7MOt3ojQv5NNlh24yTc=; b=rHUakVPiW3WsO8xFLuwdIys1fDGobSg7wc7yBJkpEnb/qtziE3wv0u5+kPDJ4p98yu UxZWZo5kShLDCDIq5P04xisKoTl4DHUGCA8296+cGG6qtTibDZB4+1phgAhm69VY6tMJ QoGrS2gqey0bhnh1rD9ckaMYhduAsZbomqnmcoO9Xq2Jo44oTr+lPuK9Kyx/qBz7Si16 7FevVuIS+ANOyNeKbgPoDXEI1rE29jodnTrICtXZraOUoGW7ve2uHfrxe3Nu/pX683jG Uw6sgm3EBj1S8bHxGWo0fw3sIBLHWNgcGGyxTQxx7JFT7tosjq68/a3IcJtVHw2H0b/D bVzQ== X-Gm-Message-State: AOAM533TPbfXCbr5owjK7scqyhb052jd5QiX7YWSrrEvrxZTACRrSSho uZsL3Oy6QTqEWkCSa6r68C8WEFcgt0ovJgqlkF9OGRAtjU79q9+84P2POAlhaaXaYG53BeRF3Lj SX94h57rCn40R+LEhZ95/mpM= X-Received: by 2002:a2e:a589:: with SMTP id m9mr6104850ljp.134.1617890706193; Thu, 08 Apr 2021 07:05:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyCiWV3mgSG51wftSAiCW3gD26oGC/DkZGKfVFoK1qpUUc8vgBrksOUFnhus5BxDoWUAEN0cXoMLcOCplK4/mI= X-Received: by 2002:a2e:a589:: with SMTP id m9mr6104813ljp.134.1617890705896; Thu, 08 Apr 2021 07:05:05 -0700 (PDT) MIME-Version: 1.0 References: <20210407090656.29176-1-david.marchand@redhat.com> <BYAPR11MB3143848E1C8A3A884BC6D712D7749@BYAPR11MB3143.namprd11.prod.outlook.com> <CAJFAV8x+NUJX7r1j1z=zyB4Wb6EMXJOE+-SKXfkVhZNPmu6zOA@mail.gmail.com> <BYAPR11MB3143B5EF130FFE371BCD61BBD7749@BYAPR11MB3143.namprd11.prod.outlook.com> In-Reply-To: <BYAPR11MB3143B5EF130FFE371BCD61BBD7749@BYAPR11MB3143.namprd11.prod.outlook.com> From: David Marchand <david.marchand@redhat.com> Date: Thu, 8 Apr 2021 16:04:54 +0200 Message-ID: <CAJFAV8zQOL-O_qLJvOtWsqMnWZeNR_7Dh8kE73FJxzYKXO48UQ@mail.gmail.com> To: "Van Haaren, Harry" <harry.van.haaren@intel.com> Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>, Ray Kinsella <mdr@ashroe.eu>, Neil Horman <nhorman@tuxdriver.com>, Dodji Seketeli <dodji@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] [PATCH] service: clean references to removed symbol X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches <stable.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/stable>, <mailto:stable-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/stable/> List-Post: <mailto:stable@dpdk.org> List-Help: <mailto:stable-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/stable>, <mailto:stable-request@dpdk.org?subject=subscribe> Errors-To: stable-bounces@dpdk.org Sender: "stable" <stable-bounces@dpdk.org> On Thu, Apr 8, 2021 at 3:08 PM Van Haaren, Harry <harry.van.haaren@intel.com> wrote: > > > For rte_service.h doc changes I'm all fine. > > > > > > For ABI consistency, this removes a function from the DPDK_21 version map that > > didn't exist in > > > the shared object itself. I'm not sure if that's an ABI break or not... I see ABI > > experts on CC, > > > and will let them comment on that topic. > > > > The symbol is not in the API anymore. > > Applications can't have a reference to this symbol without a definition. > > Agreed, however I'm not familiar enough with linking/ABI stability to > know if removing a symbol (even when not available in the API) could > affect the resulting shared object's ABI. After a discussion with Dodji and looking at binutils, I understand that the versioning is applied for each symbol found in an elf object. So at least with binutils, non-existent nodes in a version script are harmless and have no impact on the generated elf. -- David Marchand