Re: [dpdk-stable] [dpdk-dev] [PATCH v2] app/test: fix build when ring PMD is disabled

[David Marchand <david.marchand@redhat.com>]

On Thu, Oct 17, 2019 at 1:16 PM Reshma Pattan <reshma.pattan@intel.com> wrote:
> diff --git a/app/test/meson.build b/app/test/meson.build
> index 2c23c6347..e221e44f7 100644
> --- a/app/test/meson.build
> +++ b/app/test/meson.build

[snip]

> @@ -282,7 +269,6 @@ driver_test_names = [
>          'eventdev_selftest_octeontx',
>          'eventdev_selftest_sw',
>          'link_bonding_autotest',
> -        'link_bonding_mode4_autotest',

This test was in the driver list.

>          'link_bonding_rssconf_autotest',
>          'rawdev_autotest',
>  ]
> @@ -319,6 +305,20 @@ if dpdk_conf.has('RTE_LIBRTE_BOND_PMD')
>  endif

Interlacing the test names, then inspecting the .c files, I noticed
that the event_eth_tx test is missing:

>  if dpdk_conf.has('RTE_LIBRTE_RING_PMD')
>         test_deps += 'pmd_ring'
> +       test_sources += 'test_pmd_ring_perf.c'
> +       perf_test_names += 'ring_pmd_perf_autotest'


> +       test_sources += 'test_pmd_ring.c'
> +       fast_test_names += 'ring_pmd_autotest'

> +       test_sources += 'test_event_eth_tx_adapter.c'
No associated test.

> +       test_sources += 'sample_packet_forward.c'
> +       test_sources += 'test_bitratestats.c'
> +       fast_test_names += 'bitratestats_autotest'

> +       test_sources += 'test_latencystats.c'
> +       fast_test_names += 'latencystats_autotest'

> +       test_sources += 'test_link_bonding_mode4.c'
Wrong list name, as I mentioned earlier.
> +       fast_test_names += 'link_bonding_mode4_autotest'

> +       test_sources += 'test_pdump.c'
> +       fast_test_names += 'pdump_autotest'


-- 
David Marchand