From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 50D794635B for ; Thu, 6 Mar 2025 14:19:53 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 47B6E40676; Thu, 6 Mar 2025 14:19:53 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 686C040430 for ; Thu, 6 Mar 2025 14:19:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741267191; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=f/nO66CXvfpfQMA3tyjm9VqhamUHEAyqiAe1ZUqvsgc=; b=WcC81yZV91h2rBLKhKME9z01DNuhbjyMWP2Nh/YwtKLOI8J1MUWol7dJIgldbofPT2g2Wm 7z13GgZVf4pTUcHs8x0NFjLwZd+kZKjjIYpTITFiM/FX288qXme0mLj3VUGmDGutu6BTkM QxcG9X6zWFCUJFpTYQ6PYKmxS2DfPYI= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-552-7H0-rhaNM7urkYAdPhmp2Q-1; Thu, 06 Mar 2025 08:19:44 -0500 X-MC-Unique: 7H0-rhaNM7urkYAdPhmp2Q-1 X-Mimecast-MFC-AGG-ID: 7H0-rhaNM7urkYAdPhmp2Q_1741267183 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-30ba102760dso3378201fa.3 for ; Thu, 06 Mar 2025 05:19:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741267183; x=1741871983; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=f/nO66CXvfpfQMA3tyjm9VqhamUHEAyqiAe1ZUqvsgc=; b=arxHiPdFgaM+tNJZ5QVY4Vq7s9tvyr41p5LIRJaC8xtzfJv5vzlvDI3iUyaG9bnvlP oZJCyrPTyLz8IBwbU7edhjeNQWQiFA4xr+uva3f3ioaIDAMDZ8R2G98BwzVb2pTdP9y5 +6RSbhfjkMleTcmcsj509ZBkyFQp/W1UdNtDGnhEALQHOqarmY3zSgWOsf29sZfKWm7+ oV0eJRumRd2gppzANnzD38esGMrnKIVfwK+txBobtZf00hrrGsNJMle8pTU1gE7lUcEA /zvbjF7qnd+bFvuQEMIckJLbOeKo/Uia66eM/YbmTUh29ga8F3K9cyrDMl2eXWNnqOwx kKyA== X-Forwarded-Encrypted: i=1; AJvYcCXE2Txxl2dlE3BN2SSqfbYD9SFVExzgHUjGKdzusuyG3V5j+IBGhR1QCFUy1PG7I3p8gQWqjwE=@dpdk.org X-Gm-Message-State: AOJu0YzHdR28+e7aUBzdSMgdz4g6i60tEQt8qoGF0OThSfEf+mKhmWx3 QL4jjCi+uH09M+SSr3WZJIQJtsd0pfcR1Hbpmxm7gOMNJsf/Pk/J8I1lWZ1vuBXORRHydIEZUav KwNXYJXidStZBhDfzUjpa1iWcHw+dsFXlyKToWzDzKQoOF4qCSn3qp4Ok2Ly9G0g92JNilPokRJ cs/5i+H7tPOIDYhMdZlto= X-Gm-Gg: ASbGnctT7J6s77sTO2M/NjRFYzSQ85MBoH6ZkrIr02iVR+2dlJfimwt8T8kAU7+mljI /uB7R6QsYYUU8s+ZTQff0xgyrGB/YITUY1sTO6f55CJBI9ykpsYI3HrFT7qu4mCLabKW/uSOAkn s= X-Received: by 2002:a2e:b8c9:0:b0:308:efa4:d277 with SMTP id 38308e7fff4ca-30bd7a507f6mr24684061fa.15.1741267183342; Thu, 06 Mar 2025 05:19:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IGqsrEdkdHw5HmK5kH+6MKnmANwRYcqhe4d0cjualm5pwroQK6Xupm8Ud07HOGTAb5wdYsw1Hv0/kYNk/1ai9o= X-Received: by 2002:a2e:b8c9:0:b0:308:efa4:d277 with SMTP id 38308e7fff4ca-30bd7a507f6mr24683981fa.15.1741267182964; Thu, 06 Mar 2025 05:19:42 -0800 (PST) MIME-Version: 1.0 References: <1738632218-5796-1-git-send-email-andremue@linux.microsoft.com> In-Reply-To: <1738632218-5796-1-git-send-email-andremue@linux.microsoft.com> From: David Marchand Date: Thu, 6 Mar 2025 14:19:28 +0100 X-Gm-Features: AQ5f1JochVsqya7mOaeoCAN4ADHti4O9lDfTiOvXuaIwBS1ScB0HHOc-VuWgsJU Message-ID: Subject: Re: [PATCH] stack: occasional crash due to uninitialized variable To: Andre Muezerie Cc: Honnappa Nagarahalli , Olivier Matz , Gage Eads , dev@dpdk.org, stable@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: JejJBjgF4TEjeOpnCR1RYm8MEGxCxEwOizq5JAg5Azk_1741267183 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Tue, Feb 4, 2025 at 2:24=E2=80=AFAM Andre Muezerie wrote: > > Variable "success" was not being initialized and there was a code > path where the last do/while loop in __rte_stack_lf_pop_elems > looked at the value of this variable before it was set to any. > > Compiling with msvc resulted in stack_lf_autotest sometimes crashing. > > The fix is to initialize the variable. This same fix was applied to > stack\rte_stack_lf_generic.h in the past but was missed here. > > Fixes: 7e6e609939a8 ("stack: add C11 atomic implementation") > Cc: stable@dpdk.org > > Signed-off-by: Andre Muezerie Applied, thanks. --=20 David Marchand