patches for DPDK stable branches
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, Yu Jiang <yux.jiang@intel.com>, stable@dpdk.org
Subject: Re: [PATCH v2] eal/unix: support ZSTD compression for firmware
Date: Mon, 13 May 2024 13:47:04 +0200	[thread overview]
Message-ID: <CAJFAV8zX3kJTgKuSGW6ND+exMMeVwhnyUp2BZi64N=1yjJTZig@mail.gmail.com> (raw)
In-Reply-To: <ZkH7ezm_qZ0QqXUd@bricha3-mobl1.ger.corp.intel.com>

Hello Bruce,

On Mon, May 13, 2024 at 1:37 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
> > @@ -16,6 +16,8 @@
> >  #include "eal_firmware.h"
> >  #include "eal_private.h"
> >
> > +static const char * const compression_algorithms[] = { "xz", "zst" };
> Very minor nit: these are the suffixes used to find the files, more than
> they are the compression algorithms. There I'd suggest renaming to
> "compression_suffixes".
> [Perhaps just fix on apply if taking this suggestion]

I'll fix when applying.
Thanks for the review and tests.


-- 
David Marchand


  reply	other threads:[~2024-05-13 11:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20240508095214.2541115-1-david.marchand@redhat.com>
2024-05-13 11:12 ` David Marchand
2024-05-13 11:37   ` Bruce Richardson
2024-05-13 11:47     ` David Marchand [this message]
2024-05-17 17:01     ` David Marchand
2024-07-03  7:12   ` Xueming Li
2024-07-03  7:27     ` David Marchand
2024-07-03  9:03       ` Xueming Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJFAV8zX3kJTgKuSGW6ND+exMMeVwhnyUp2BZi64N=1yjJTZig@mail.gmail.com' \
    --to=david.marchand@redhat.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    --cc=yux.jiang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).