From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 22C56A0547 for ; Fri, 9 Apr 2021 16:34:33 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EF4F54014D; Fri, 9 Apr 2021 16:34:32 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 5E5384014D for ; Fri, 9 Apr 2021 16:34:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617978870; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Alf82q7OKfZJBMXcUOBgH3s2R1EeX+bTlP27yVCfUM0=; b=B6drsj1snloL2Gv6vmOp1BWuHZtJ2uQb43Ue7y7zTEht8+pdlMAOuYcqCRI2vNAV9kYur5 r7pXWSKsRVsn5tXE4oxdG3iFkVKg68AM99U6gw3ezLSWC3oWIcBEqGX3hxZ1khJNC0EeCC RhrWNun3TdxoW738mhymc9MvBQNwX3U= Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-269-FY0F7e6VNdO2hOniwiAalQ-1; Fri, 09 Apr 2021 10:34:26 -0400 X-MC-Unique: FY0F7e6VNdO2hOniwiAalQ-1 Received: by mail-ua1-f69.google.com with SMTP id k21so1312876uag.22 for ; Fri, 09 Apr 2021 07:34:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Alf82q7OKfZJBMXcUOBgH3s2R1EeX+bTlP27yVCfUM0=; b=ZhQklFHedYqChvtR3AqwD5Z5lLudr0+pKGYe3rXPlMpeYdCJ5Y90Bs5aDiTlaS1RfH 72UEF3uKjcZdH4r5NvCYhrpdLhTdc3uazU1YXIf5e02fqPNWqmE5k0oHwW7U325ZrnfL in+ZKRU+ydoeLuAYPjPwbPnNz9S2obtkm+sfyEkWO9WQqSBLxE7rqWMek9qNC+E97Yxb aaauTSGaGm3MH2laJCqEODYg+iCTnKkqPBtP5J4rftQOBuNspE89j9c7p1C7I3LLF47k Jm5moqtRZSNEJfeanopzZJdtnjfWfiAK2qp/p9V5SE3oJfBSXSlZU4IQVdyqNMIM/H+3 pBTA== X-Gm-Message-State: AOAM533rx74grAHMDCb1JhYPeAhHKDpOx0QBS5iG5hKwcjAnwbjLE5yP W9adK6alVRFqZ0FgJM7TXI5zMBifCjaORfxEQlMd0tMoD8p0fpvj5aIRuuGKvdg3PMA+coLHx98 15xEYknZX3UjY1XDxCHk5ZJE= X-Received: by 2002:ac5:ccc4:: with SMTP id j4mr11343202vkn.18.1617978866445; Fri, 09 Apr 2021 07:34:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzLstc+4ss8QvLntgHy/M5N1KR4xvUw55CgNXTEwk5pjBPuynGPGqHxcXtIRsBiHAP76xlq0l74+E1c3NDV91I= X-Received: by 2002:ac5:ccc4:: with SMTP id j4mr11343184vkn.18.1617978866255; Fri, 09 Apr 2021 07:34:26 -0700 (PDT) MIME-Version: 1.0 References: <20210407201603.149234-2-lucp.at.work@gmail.com> In-Reply-To: <20210407201603.149234-2-lucp.at.work@gmail.com> From: David Marchand Date: Fri, 9 Apr 2021 16:34:15 +0200 Message-ID: To: Luc Pelletier Cc: Olivier Matz , Honnappa Nagarahalli , dev , dpdk stable Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] [PATCH 2/2] eal: fix hang in ctrl thread creation error logic X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Wed, Apr 7, 2021 at 10:29 PM Luc Pelletier wrote: > > The affinity of a control thread is set after it has been launched. If > setting the affinity fails, pthread_cancel is called followed by a call > to pthread_join, which can hang forever if the thread's start routine > doesn't call a pthread cancellation point. > > This patch modifies the logic so that the control thread exits > gracefully if the affinity cannot be set successfully and removes the > call to pthread_cancel. > > Fixes: 6383d26 ("eal: set name when creating a control thread") Fixed sha1's while applying. We prefer sha1 on 12 chars, like described in https://doc.dpdk.org/guides/contributing/patches.html#commit-messages-body. > Cc: stable@dpdk.org > > Signed-off-by: Luc Pelletier Acked-by: Olivier Matz Reviewed-by: Honnappa Nagarahalli Series applied, thanks for the fixes. -- David Marchand