From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 00C93A09E1
for <public@inbox.dpdk.org>; Sat, 14 Nov 2020 11:54:59 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id CB548C8CC;
Sat, 14 Nov 2020 11:54:57 +0100 (CET)
Received: from us-smtp-delivery-124.mimecast.com
(us-smtp-delivery-124.mimecast.com [216.205.24.124])
by dpdk.org (Postfix) with ESMTP id DC173C88E
for <stable@dpdk.org>; Sat, 14 Nov 2020 11:54:52 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1605351291;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
in-reply-to:in-reply-to:references:references;
bh=K3lEgwYT0DgbmxP/au1c0LvGBYHTtmOtoIzJRF7N8Mk=;
b=a456QezRhudSA7nRtqQgKAjjYlBOV6GTiyiq2XgQH/v4+ptm/wTrBYQtQRypIxMAC7y0Bu
g7UjudsT6K8WLc6rmU7MyVF4GVecqYLjKzdL7NXT4nXcWDAWAB0LQY/y4CnL1UBdW9mCDd
2/cfY4M91XUbbIdxBwoZl85NWIzOkAE=
Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com
[209.85.221.199]) (Using TLS) by relay.mimecast.com with ESMTP id
us-mta-203-lfW78NT4PmiKpC-8rKlAwA-1; Sat, 14 Nov 2020 05:54:47 -0500
X-MC-Unique: lfW78NT4PmiKpC-8rKlAwA-1
Received: by mail-vk1-f199.google.com with SMTP id s1so3351155vks.6
for <stable@dpdk.org>; Sat, 14 Nov 2020 02:54:47 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to:cc;
bh=K3lEgwYT0DgbmxP/au1c0LvGBYHTtmOtoIzJRF7N8Mk=;
b=O5i5NMJIP3RKlsbuexP5mZrHtsAX3eeuIKUusTjgrqKgcV+6YltuGV+tGvLzPO8CBz
aXBur/5rzr0q8MmfPUiSe4/W3rQ6DSAhq4No3WOiaN47EfZm7kWBq2Lq5Y6BahRYjwqV
PrxKwO9m6y8INNLWg0UokNloR/zhja04McOB0I+dR4DUmZxooLQ0IJhOAJ73KphKe2Es
Qd2SX3F1KOAGpU+O+rPSKZdbHYQJVd757eivgOWsCHdLUV3Dc3RtpAOnlkEgvUW88nlw
nlMAQfJoHaK9kBOympNTU6nKrtIrjzFmrHr2o/kdjMAkK4tjfqr4uZ/Fbdhn961BsQem
RriA==
X-Gm-Message-State: AOAM531IjlEjWQ/sUJwC+WeNX3bYKk1XCBZl7W/6C1AiSNp5CNFUVQqc
/wTTGUt5I9uy47ScgEzvSb6HPqwcqjBeus7NAZuxCv+8AViqQfGriiPwQm2UdOKWLJ2owYq6UXH
ABPLGoJuZhJN4lLAc+iaMA3c=
X-Received: by 2002:a67:f54b:: with SMTP id z11mr3777166vsn.17.1605351287003;
Sat, 14 Nov 2020 02:54:47 -0800 (PST)
X-Google-Smtp-Source: ABdhPJwLiW8IsuSDNMQ7e6Tsmch8KF7L4dfX7h44DcF1D98aamvMfE3mA9txsTY2oDPWazELblQssNJ6sqFHb2Nksck=
X-Received: by 2002:a67:f54b:: with SMTP id z11mr3777159vsn.17.1605351286795;
Sat, 14 Nov 2020 02:54:46 -0800 (PST)
MIME-Version: 1.0
References: <20201113145212.486443-1-maxime.coquelin@redhat.com>
<20201113150523.GA1441@bricha3-MOBL.ger.corp.intel.com>
<11842873.9WOr1mrSjh@thomas> <10682579.uibSL3b33d@thomas>
In-Reply-To: <10682579.uibSL3b33d@thomas>
From: David Marchand <david.marchand@redhat.com>
Date: Sat, 14 Nov 2020 11:54:35 +0100
Message-ID: <CAJFAV8zfuh4U4MsA2Xct-GmYxUFtszwM=dHxwv-rXFhB0TJNqA@mail.gmail.com>
To: Thomas Monjalon <thomas@monjalon.net>, "Yigit,
Ferruh" <ferruh.yigit@intel.com>
Cc: Maxime Coquelin <maxime.coquelin@redhat.com>, dev <dev@dpdk.org>,
dpdk stable <stable@dpdk.org>, Marvin Liu <yong.liu@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>
Authentication-Results: relay.mimecast.com;
auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] config: enable packet
prefetching with Meson
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
Sender: "stable" <stable-bounces@dpdk.org>
On Sat, Nov 14, 2020 at 10:00 AM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 14/11/2020 09:51, Thomas Monjalon:
> > 13/11/2020 16:05, Bruce Richardson:
> > > On Fri, Nov 13, 2020 at 03:52:12PM +0100, Maxime Coquelin wrote:
> > > > With Make build system, RTE_PMD_PACKET_PREFETCH was enabled
> > > > by default. It got lost when transitioning to Meson build
> > > > system.
> > > >
> > > > In order to avoid performance changes, this patch enables
> > > > packet prefetching in rte_config.h.
> > > >
> > > > Reported-by: Marvin Liu <yong.liu@intel.com>
> > > > Suggested-by: David Marchand <david.marchand@redhat.com>
> > > > Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> [...]
> >
> > Applied with backport info, thanks.
>
> Note that it is added back for "compatibility",
> but I am still in favour of dropping this config option,
> replaced by arch decision if any:
> http://inbox.dpdk.org/dev/3677226.MZCibFMyqQ@thomas/
>
> The decision of such optimization should be done in DPDK project,
> not in the hand of the packager.
I am for dropping this too.
And for cleaning more prefetch-related stuff, like:
#if 1
#define RTE_PMD_USE_PREFETCH
#endif
#ifdef RTE_PMD_USE_PREFETCH
#define rte_em_prefetch(p) rte_prefetch0(p)
#else
#define rte_em_prefetch(p) do {} while(0)
#endif
This has been copied into other drivers.
The igc driver forgot(?) to force #define this macro, so it just
copied unused code.
--
David Marchand