From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 41613A04C0 for ; Thu, 8 Oct 2020 12:28:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 224351BED2; Thu, 8 Oct 2020 12:28:50 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id 4D7981BEA1 for ; Thu, 8 Oct 2020 12:28:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602152924; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jxjcYpG0W957FMeoYm8n6e6iEgfZyKI44O0+W4I1HhU=; b=AAVh1NKMo+M1TkfCiUEbR2bSSBI/jXDTQoASe2kOJFYGsKnQBl2RhC4Pk/aGlFWonei5Fo kZvkxerd9GKcdfYUIXV3ZPCNj9ApcCOaRCAADHwo/pw+H/vIPLuVOpiUO3JvNjSXxJDy/t tn+W4xIVPjUr6qJX3G78by+WotJvdbA= Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-188-XOQl-w8hOiyi46h_S4flyw-1; Thu, 08 Oct 2020 06:28:41 -0400 X-MC-Unique: XOQl-w8hOiyi46h_S4flyw-1 Received: by mail-vk1-f197.google.com with SMTP id j134so935267vke.1 for ; Thu, 08 Oct 2020 03:28:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jxjcYpG0W957FMeoYm8n6e6iEgfZyKI44O0+W4I1HhU=; b=RgDnqygDo8qM39NFRsMor5UrbDaDmTI65Gz5FLfjZXmLtbLV0/FDv2737COMeyq31h /Z92AxSXWaUXkSXNrqt3qJ96cA/SOggT7fk1j1FcpkNNz++Afdxn9r8oc0jrdMg1o3xT 5DkBcllzNyuDoKwRmjNKqSZRuY4I3WGMzdRCcrIqdvKENGg18frLoYOeUm+0ZF1LwqHt uZUsZ+I2Fl6+eyaYPiE6/3g5bbs0sEIuZ7Bzc22IFt66n8q5UT5a69/Eyh1JqHEE7W8t PXMZK/E9p3J54bGhRLiD7+84wQ8nVRET9WA8h39aumN+S6QBX1zgcZ5nETtN+cOqdan/ E2iw== X-Gm-Message-State: AOAM532XQAPTebBuXNUWzSjZVZKJNIF6EcLvFLP20WYp0IB7Qepfs0Up XsAOBRB504AvCwTe4kdE7lZE6OWHTJdjnAYS+rz2e2p/r7GjFCaLmJfnOF3hPDeRl+oF5dgolXe NvSyoTberpgpOluWm55pRhfo= X-Received: by 2002:a05:6102:3121:: with SMTP id f1mr4217211vsh.10.1602152920648; Thu, 08 Oct 2020 03:28:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxgIxPX5DnIUxMjFFc4kLc/KqD/q11ir+ZXCvwBNf8FYv5Nu26vuJsUP0RcP+xATwEf4eN9SSUPz8pL0+uA9Bw= X-Received: by 2002:a05:6102:3121:: with SMTP id f1mr4217201vsh.10.1602152920406; Thu, 08 Oct 2020 03:28:40 -0700 (PDT) MIME-Version: 1.0 References: <1599662474-44882-1-git-send-email-erik.g.carrillo@intel.com> <1599662474-44882-2-git-send-email-erik.g.carrillo@intel.com> In-Reply-To: From: David Marchand Date: Thu, 8 Oct 2020 12:28:29 +0200 Message-ID: To: Erik Gabriel Carrillo Cc: "dev@dpdk.org" , "stable@dpdk.org" , nd , Honnappa Nagarahalli , Sarosh Arif Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH 1/1] timer: add limitation note for sync stop and reset X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Thu, Sep 10, 2020 at 3:23 AM Honnappa Nagarahalli wrote: > > If a timer's callback function calls rte_timer_reset_sync() or > > rte_timer_stop_sync() on another timer that is in the RUNNING state and > > owned by the current lcore, the *_sync() calls will loop indefinitely. > > > > Relatedly, if a timer's callback function calls *_sync() on another timer that is > > in the RUNNING state and is owned by a different lcore, but a timer callback > > function runs on that different lcore and calls > > *_sync() on a timer that is in the RUNNING state and owned by the current > > lcore, the two lcores will loop indefinitely. > > > > Add a note in the rte_timer_stop_sync and rte_timer_reset_sync > > documentation that indicates that these APIs should not be used inside > > timer callback functions in order to avoid the hangs described above, and > > suggests an alternative. > > > > Bugzilla ID: 491 > > Cc: stable@dpdk.org > > > > Signed-off-by: Erik Gabriel Carrillo > Reviewed-by: Honnappa Nagarahalli Applied, thanks. Since we go with documenting a limitation, should we mark the original patches [1] and [2] as rejected instead of deferred? 1: https://patches.dpdk.org/patch/75156/ 2: https://patches.dpdk.org/patch/73683/ -- David Marchand