From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 94D27A04BA for ; Mon, 5 Oct 2020 10:12:53 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 777461B650; Mon, 5 Oct 2020 10:12:52 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id 2DDF01B650 for ; Mon, 5 Oct 2020 10:12:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601885567; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=I/odpbAdhNpnB+XXgQS/TjUUCw3Ckl8BJRHZ6m9fJFs=; b=EjxRoLI51pfbjIsLpRwmSsl/5z3e3PShtkhBobGrRWBmrezm9xD5VcHaPEuEtQmislS4By JlWJJHR1ZurEuyZgWzmBN5wPTvtDPI1JEuqPgYfK28LLxlmmgjUZVLp36x4boo7eoY1U16 gw546DNvpzgLSB3eTztMOzg9W7ps9rI= Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-480-ziHX7dR1NQSCVQQpxsbeLg-1; Mon, 05 Oct 2020 04:12:46 -0400 X-MC-Unique: ziHX7dR1NQSCVQQpxsbeLg-1 Received: by mail-vs1-f70.google.com with SMTP id g5so2638609vsg.14 for ; Mon, 05 Oct 2020 01:12:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=I/odpbAdhNpnB+XXgQS/TjUUCw3Ckl8BJRHZ6m9fJFs=; b=Y3Eoz9bpkMBOLRAi5tTXVaNRGr9gJdgrM+38ByIhNnlAGU/6ayDagWSjz4J//F7+HH yUVQ4UkljDh5pA62yWCx5T3Fl+M20ILS12bzzQarHMc1bni+5xsGtHXHm8Bir9noYCo+ fs8106sOm4UvqgkRwsdYYnCUqy/iqSX91lWuLER1upjl7CRtn+l4+wnvqJI6e/ozpkFb LOWxIWz0mTgcM6/pjxZKuYZH2S7BKnL1A7THU1LLDeU0ZKzM2jm5uXwsTGwMO6w9XRKn /QeuHA5JTnLIWg+ElptFOEtCrmDdlM2oMel1scmoWEvk1a6g+AHExZWeK249wnAw1ZRg 7UFA== X-Gm-Message-State: AOAM532m+z+1PsvtjAnYObAcJW2fsdpzHUqGkbgpdfpscusn9na9D+Kj rI++Dt6Z2lcQVzLHD9y12h7OBvLFUruV23GTHK+sTLyMP1/JTmkltzk4f53QM2zo+mYzbO3Qq0K qooCPTUtJ9nYpHsnIaUdi8Uo= X-Received: by 2002:a05:6102:5d:: with SMTP id k29mr2121885vsp.17.1601885565598; Mon, 05 Oct 2020 01:12:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyMtoTy2HdFyLAZlaVPFnP1MxIPeKI7Z3fANV878dCvy6qdWX5VoEEqjtWzJqH2/YdBBsiVx+OPo+WavtCoiI4= X-Received: by 2002:a05:6102:5d:: with SMTP id k29mr2121873vsp.17.1601885565401; Mon, 05 Oct 2020 01:12:45 -0700 (PDT) MIME-Version: 1.0 References: <20200621090800.1AE521C00D@dpdk.org> <1599822484-19100-1-git-send-email-wangyunjian@huawei.com> In-Reply-To: <1599822484-19100-1-git-send-email-wangyunjian@huawei.com> From: David Marchand Date: Mon, 5 Oct 2020 10:12:34 +0200 Message-ID: To: wangyunjian Cc: dev , "Burakov, Anatoly" , "Yigit, Ferruh" , "Lilijun (Jerry)" , xudingke , dpdk stable Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2 RESEND] vfio: fix resource leak when mapping fails X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Fri, Sep 11, 2020 at 1:08 PM wangyunjian wrote: > > From: Yunjian Wang > > Currently, only the 'vfio_dev_fd' is closed in failure path, so > some resources are not released(such as 'vfio_group_fd'). The > rte_vfio_release_device() should be used to avoid this problem. > > Fixes: 33604c31354a ("vfio: refactor PCI BAR mapping") > Cc: stable@dpdk.org > > Signed-off-by: Yunjian Wang Reviewed-by: Anatoly Burakov Applied, thanks. -- David Marchand