From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 52490A0561 for ; Wed, 3 Mar 2021 09:18:10 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3A40A1606DA; Wed, 3 Mar 2021 09:18:10 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mails.dpdk.org (Postfix) with ESMTP id 7DAD040696 for ; Wed, 3 Mar 2021 09:18:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614759487; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HwH6OuxPeneHraAVAa2ZOGfVNrO32wQZ75KbaKy5nOE=; b=MbCQugl028mSfPN27L0ZYdgccw+Jo+wkTpgA6HTqpWvSQLm83QgcLbvY4h6Cm03FoliUlK UsmtyG/ljyw/CJovjmVEEZtBVymix/ryyfSqepOBDnajPJC8S94xuh4T/EZfD23eoK3K5Y kpuPh8rZa5bMlT+yrTMhO17ibXmmqZI= Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com [209.85.217.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-456-y5q0uo4nNpK3Se738PqVjA-1; Wed, 03 Mar 2021 03:18:04 -0500 X-MC-Unique: y5q0uo4nNpK3Se738PqVjA-1 Received: by mail-vs1-f69.google.com with SMTP id v15so2627559vso.17 for ; Wed, 03 Mar 2021 00:18:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HwH6OuxPeneHraAVAa2ZOGfVNrO32wQZ75KbaKy5nOE=; b=ZPx4Z4ussgEamOI4nz6coeQ+wrAOxWwnvjfqATNhW+xh5s7sKr64g7Ypa78bJ4k666 4MCbYwhi1vVtgNp+5rh+BtCRrA3BIjuVEKB8Ht5nLymRgW9/jCQSG53Kp0hyu0ykLSCh 9+MiiX5dpfXZNvBWMQymYnYGudIQc+7uIK54KNi3MkAx96W/Eyve+h1s+pDZHnmuIp90 uDk0oMuHkpNJuoqqklyhoPXX73CmLjZs9DjFda5Mitbzgdiis0O+z296oIxQ05z0LzAN Zg/3MS0zoIbf1oVHokoNsoqQ2TnN6PLlDlYbKeZp7UP9jE68Y5HtrsrrZULwL0L8qnmD 5AQA== X-Gm-Message-State: AOAM533g5fOK/jn0rf8f7E3KeM1TWfSg9u+DWUS8MXdr+0EdxHV9MlC/ MiHNl6hm/GCQgeL29mQvQJSGAdTK93OkGKoI6QoPnFHvDwDWK3sN/jW4gqRRg4kVPH+Psk6gCfx +ljCd7GzyCaGsvAYGGjdTf3g= X-Received: by 2002:ac5:ccc4:: with SMTP id j4mr1088008vkn.18.1614759484002; Wed, 03 Mar 2021 00:18:04 -0800 (PST) X-Google-Smtp-Source: ABdhPJxuqxE7HBQPvXezQk8ta+KazIrzzV0ZKKKOR/EjaCLKBCy8f4vVebhC+L5MsZvSJrWu6XuZpA/IAJdbb3lfSdE= X-Received: by 2002:ac5:ccc4:: with SMTP id j4mr1088000vkn.18.1614759483715; Wed, 03 Mar 2021 00:18:03 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: David Marchand Date: Wed, 3 Mar 2021 09:17:52 +0100 Message-ID: To: Anatoly Burakov , Andrew Rybchenko Cc: dev , dpdk stable Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] fbarray: fix uninitialized variable usage X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Fri, Feb 19, 2021 at 6:55 PM Anatoly Burakov wrote: > > When file truncation fails, the log message attempts to print a path of > file we failed to truncate, but this path was never set to anything and, > what's worse, was uninitialized. Fix it by passing path from the caller. > > Fixes: c44d09811b40 ("eal: add shared indexed file-backed array") > Cc: stable@dpdk.org > Coverity ID: 366122 > > Signed-off-by: Anatoly Burakov Andrew had reported it too, and proposed something close: http://patchwork.dpdk.org/project/dpdk/patch/20201211170615.32827-1-aboyer@pensando.io/ I prefer Anatoly's version. If no one objects, I'll proceed with this one. -- David Marchand