patches for DPDK stable branches
 help / color / mirror / Atom feed
From: David Marchand <>
To: Harry van Haaren <>
Cc: dev <>, Aaron Conole <>,
	dpdk stable <>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] test/service: fix wait for service core
Date: Wed, 27 Nov 2019 22:38:57 +0100
Message-ID: <> (raw)
In-Reply-To: <>

On Wed, Nov 27, 2019 at 2:20 PM Harry van Haaren
<> wrote:
> This commit fixes a sporadic failure of the service_autotest
> unit test, as seen in the DPDK CI. The failure occurs as the main test
> thread did not wait on the service-thread to return, and allowing it
> to read a flag before the service was able to write to it.
> The fix changes the wait API call to specific the service-core ID,
> and this waits for cores with both ROLE_RTE and ROLE_SERVICE.
> The rte_eal_mp_wait_lcore() call does not (and should not) wait
> for service cores, so must not be used to wait on service-cores.
> Fixes: f038a81e1c56 ("service: add unit tests")

> Reported-by: Aaron Conole <>
> Signed-off-by: Harry van Haaren <>

Acked-by: David Marchand <>

Before this patch, reproduced the pb in less than 2 minutes with:
# time (log=/tmp/$$.log; while true; do echo service_autotest |taskset
-c 0-1 build-gcc-static/app/test/dpdk-test --log-level *:8 -l 0-1
>$log 2>&1; grep -q 'Test OK' $log || break; done; cat $log; rm -f

With the patch, this loop has been running for 40 minutes.

Applied, thanks.

David Marchand

      parent reply	other threads:[~2019-11-27 21:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <>
     [not found] ` <>
2019-11-27 14:16   ` [dpdk-stable] " Van Haaren, Harry
2019-11-27 18:11     ` David Marchand
2019-11-27 19:10       ` Aaron Conole
2019-11-27 20:11     ` David Marchand
2019-11-27 21:38 ` David Marchand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ \
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:

AGPL code for this site: git clone