From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by dpdk.space (Postfix) with ESMTP id 917C8A05D3
for <public@inbox.dpdk.org>; Wed, 22 May 2019 14:40:53 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 58628A69;
Wed, 22 May 2019 14:40:53 +0200 (CEST)
Received: from mail-ua1-f66.google.com (mail-ua1-f66.google.com
[209.85.222.66]) by dpdk.org (Postfix) with ESMTP id 5924FA69
for <stable@dpdk.org>; Wed, 22 May 2019 14:40:52 +0200 (CEST)
Received: by mail-ua1-f66.google.com with SMTP id r19so792968uap.5
for <stable@dpdk.org>; Wed, 22 May 2019 05:40:52 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to:cc;
bh=C/X4plxzCYJSqcXbuySM1pGV+ksli7gjkAHqndnRShw=;
b=GRoaGTHRngM1W4CBG3nsT8ttBhr1ytmuxT+WwWhjlLZKLnjxl0+dvMS4YMVxIhP7Px
IlFhHk0GlCGaEeCnFkJSu3MQgB1mThpAKFGBMHxiyrR7YrxWzCYviGAwHX0XHcCNlLMA
NtWRxrxHXHKW2LEXmUyGIOFyMHFElNYRfLM04ZyK6ivA2vdr2moiBt9c3REtn05egnX3
xAc4rWMxJ+vy2yk/ueP+4TSR2WFHz1YmgnWE12zQZVMTBEFTkNYr0D65CYQ8qGS5XlEs
vGa6VLoXYT6dVWPfLeD+iMSPA1vf+9XH0hluO8sW0S1NXKzXSqzwhfjeCeaMGcUQhRZQ
xdjw==
X-Gm-Message-State: APjAAAVtSVNadNMEhhrbdpZjbUviVCldvG34Xd2n915rD4VlLKDOf4tI
pV1H4oCjzS1Jue3P854WM7tLVapBry7blHyxQr2VdQ==
X-Google-Smtp-Source: APXvYqx+Uf119W6GmO6jsFoUqpdUvjqwwyosnI+TXqwSg6xiRaw1Eh5TR2RaP3on905BeKkLAFdhc9ABuWpfRJQEows=
X-Received: by 2002:ab0:2bc6:: with SMTP id s6mr8120622uar.86.1558528851706;
Wed, 22 May 2019 05:40:51 -0700 (PDT)
MIME-Version: 1.0
References: <1557907020-1548-1-git-send-email-david.marchand@redhat.com>
<D2C4A16CA39F7F4E8E384D204491D7A673E9ECBC@ORSMSX104.amr.corp.intel.com>
In-Reply-To: <D2C4A16CA39F7F4E8E384D204491D7A673E9ECBC@ORSMSX104.amr.corp.intel.com>
From: David Marchand <david.marchand@redhat.com>
Date: Wed, 22 May 2019 14:40:40 +0200
Message-ID: <CAJFAV8zs0CuDLtrkEHNobOB4JE9szJ_1LiTmFYUxJ-GrU1gzTQ@mail.gmail.com>
To: "Wang, Yipeng1" <yipeng1.wang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Dharmik Thakkar <Dharmik.Thakkar@arm.com>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"stephen@networkplumber.org" <stephen@networkplumber.org>,
"stable@dpdk.org" <stable@dpdk.org>,
"Gobriel, Sameh" <sameh.gobriel@intel.com>, "Richardson,
Bruce" <bruce.richardson@intel.com>,
"De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-stable] [PATCH 1/2] test/hash: use existing lcore API
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
Sender: "stable" <stable-bounces@dpdk.org>
Hello,
On Wed, May 22, 2019 at 2:16 AM Wang, Yipeng1 <yipeng1.wang@intel.com>
wrote:
> >-----Original Message-----
> >From: David Marchand [mailto:david.marchand@redhat.com]
> >Sent: Wednesday, May 15, 2019 12:57 AM
> >To: dev@dpdk.org
> >Cc: thomas@monjalon.net; stephen@networkplumber.org; stable@dpdk.org;
> Wang, Yipeng1 <yipeng1.wang@intel.com>; Gobriel,
> >Sameh <sameh.gobriel@intel.com>; Richardson, Bruce <
> bruce.richardson@intel.com>; De Lara Guarch, Pablo
> ><pablo.de.lara.guarch@intel.com>
> >Subject: [PATCH 1/2] test/hash: use existing lcore API
> >
> >Prefer the existing apis rather than direct access the configuration
> >structure.
> >
> >Fixes: c7eb0972e74b ("test/hash: add lock-free r/w concurrency")
> >Fixes: 3f9aab961ed3 ("test/hash: check lock-free extendable bucket")
> >Cc: stable@dpdk.org
> >
> >Signed-off-by: David Marchand <david.marchand@redhat.com>
> >---
> > app/test/test_hash_readwrite_lf.c | 29 ++++++++++++++---------------
> > 1 file changed, 14 insertions(+), 15 deletions(-)
> >
>
> [Wang, Yipeng]
>
> Hi, David, I tested the patch and the test case seems now frozen after
> running in the middle. Have you seen same thing?
>
> I include the original author Dharmik for the file for more reviews.
>
>
> Output:
>
> "
> ....
>
> Test: Hash add - key shift, Hash lookup - miss
>
> Number of readers: 1
> Cycles per lookup: 112
>
> Number of readers: 2
> Cycles per lookup: 113
>
> Number of readers: 4
> Cycles per lookup: 116
>
> ** With bulk-lookup **
>
> Number of readers: 1
> Cycles per lookup: 41
>
> Number of readers: 2
> Cycles per lookup: 40
>
> Number of readers: 4
> Cycles per lookup: 40
>
> Test: Multi-add-lookup
>
> Number of writers: 2
> Number of readers: 1
> Cycles per lookup: 166
>
> Number of writers: 2
> Number of readers: 2
> "
> <Freezing here>
>
Thanks for reporting.
I reproduced the issue.
I did not catch it as I was starting the test with 4 cores on my laptop.
I will post a fix and/or an updated patch.
--
David Marchand