* [dpdk-stable] [PATCH v2] net/ena: enable multi segment in Tx offload flags [not found] <20210712170153.11508-1-ghalem.boudour@6wind.com> @ 2021-07-30 8:34 ` Olivier Matz 2021-07-30 9:37 ` Michał Krawczyk 0 siblings, 1 reply; 3+ messages in thread From: Olivier Matz @ 2021-07-30 8:34 UTC (permalink / raw) To: dev; +Cc: ghalem.boudour, evgenys, gtzalik, igorch, mk, mw, stable From: Ghalem Boudour <ghalem.boudour@6wind.com> The DPDK ENA driver does not provide multi-segment tx offload capability. Let's add DEV_TX_OFFLOAD_MULTI_SEGS to ports offload capability by default, and always set it in dev->data->dev_conf.txmode.offload. This flag in not listed in doc/guides/nics/features/default.ini, so ena.ini does not need to be updated. Fixes: 1173fca25af9 ("ena: add polling-mode driver") Cc: stable@dpdk.org Signed-off-by: Ghalem Boudour <ghalem.boudour@6wind.com> Signed-off-by: Olivier Matz <olivier.matz@6wind.com> --- v2 * set DEV_TX_OFFLOAD_MULTI_SEGS in dev->data->dev_conf.txmode.offload * add Fixes and Cc stable drivers/net/ena/ena_ethdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index dfe68279fa..b59451034c 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -1981,6 +1981,7 @@ static int ena_dev_configure(struct rte_eth_dev *dev) if (dev->data->dev_conf.rxmode.mq_mode & ETH_MQ_RX_RSS_FLAG) dev->data->dev_conf.rxmode.offloads |= DEV_RX_OFFLOAD_RSS_HASH; + dev->data->dev_conf.txmode.offloads |= DEV_TX_OFFLOAD_MULTI_SEGS; adapter->tx_selected_offloads = dev->data->dev_conf.txmode.offloads; adapter->rx_selected_offloads = dev->data->dev_conf.rxmode.offloads; @@ -2055,6 +2056,7 @@ static int ena_infos_get(struct rte_eth_dev *dev, DEV_RX_OFFLOAD_TCP_CKSUM; rx_feat |= DEV_RX_OFFLOAD_JUMBO_FRAME; + tx_feat |= DEV_TX_OFFLOAD_MULTI_SEGS; /* Inform framework about available features */ dev_info->rx_offload_capa = rx_feat; -- 2.29.2 ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-stable] [PATCH v2] net/ena: enable multi segment in Tx offload flags 2021-07-30 8:34 ` [dpdk-stable] [PATCH v2] net/ena: enable multi segment in Tx offload flags Olivier Matz @ 2021-07-30 9:37 ` Michał Krawczyk 2021-07-30 10:11 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon 0 siblings, 1 reply; 3+ messages in thread From: Michał Krawczyk @ 2021-07-30 9:37 UTC (permalink / raw) To: Olivier Matz Cc: dev, Ghalem Boudour, Schmeilin, Evgeny, Chauskin, Igor, Marcin Wojtas, stable pt., 30 lip 2021 o 10:35 Olivier Matz <olivier.matz@6wind.com> napisał(a): > > From: Ghalem Boudour <ghalem.boudour@6wind.com> > > The DPDK ENA driver does not provide multi-segment tx offload capability. > Let's add DEV_TX_OFFLOAD_MULTI_SEGS to ports offload capability by > default, and always set it in dev->data->dev_conf.txmode.offload. > > This flag in not listed in doc/guides/nics/features/default.ini, so > ena.ini does not need to be updated. > > Fixes: 1173fca25af9 ("ena: add polling-mode driver") > Cc: stable@dpdk.org > > Signed-off-by: Ghalem Boudour <ghalem.boudour@6wind.com> > Signed-off-by: Olivier Matz <olivier.matz@6wind.com> Acked-by: Michal Krawczyk <mk@semihalf.com> > --- > > v2 > * set DEV_TX_OFFLOAD_MULTI_SEGS in dev->data->dev_conf.txmode.offload > * add Fixes and Cc stable > > drivers/net/ena/ena_ethdev.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c > index dfe68279fa..b59451034c 100644 > --- a/drivers/net/ena/ena_ethdev.c > +++ b/drivers/net/ena/ena_ethdev.c > @@ -1981,6 +1981,7 @@ static int ena_dev_configure(struct rte_eth_dev *dev) > > if (dev->data->dev_conf.rxmode.mq_mode & ETH_MQ_RX_RSS_FLAG) > dev->data->dev_conf.rxmode.offloads |= DEV_RX_OFFLOAD_RSS_HASH; > + dev->data->dev_conf.txmode.offloads |= DEV_TX_OFFLOAD_MULTI_SEGS; > > adapter->tx_selected_offloads = dev->data->dev_conf.txmode.offloads; > adapter->rx_selected_offloads = dev->data->dev_conf.rxmode.offloads; > @@ -2055,6 +2056,7 @@ static int ena_infos_get(struct rte_eth_dev *dev, > DEV_RX_OFFLOAD_TCP_CKSUM; > > rx_feat |= DEV_RX_OFFLOAD_JUMBO_FRAME; > + tx_feat |= DEV_TX_OFFLOAD_MULTI_SEGS; > > /* Inform framework about available features */ > dev_info->rx_offload_capa = rx_feat; > -- > 2.29.2 > ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH v2] net/ena: enable multi segment in Tx offload flags 2021-07-30 9:37 ` Michał Krawczyk @ 2021-07-30 10:11 ` Thomas Monjalon 0 siblings, 0 replies; 3+ messages in thread From: Thomas Monjalon @ 2021-07-30 10:11 UTC (permalink / raw) To: Olivier Matz Cc: dev, Ghalem Boudour, Schmeilin, Evgeny, Chauskin, Igor, Marcin Wojtas, stable, Michał Krawczyk 30/07/2021 11:37, Michał Krawczyk: > pt., 30 lip 2021 o 10:35 Olivier Matz <olivier.matz@6wind.com> napisał(a): > > > > From: Ghalem Boudour <ghalem.boudour@6wind.com> > > > > The DPDK ENA driver does not provide multi-segment tx offload capability. > > Let's add DEV_TX_OFFLOAD_MULTI_SEGS to ports offload capability by > > default, and always set it in dev->data->dev_conf.txmode.offload. > > > > This flag in not listed in doc/guides/nics/features/default.ini, so > > ena.ini does not need to be updated. > > > > Fixes: 1173fca25af9 ("ena: add polling-mode driver") > > Cc: stable@dpdk.org > > > > Signed-off-by: Ghalem Boudour <ghalem.boudour@6wind.com> > > Signed-off-by: Olivier Matz <olivier.matz@6wind.com> > Acked-by: Michal Krawczyk <mk@semihalf.com> Applied, thanks. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-30 10:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20210712170153.11508-1-ghalem.boudour@6wind.com>
2021-07-30 8:34 ` [dpdk-stable] [PATCH v2] net/ena: enable multi segment in Tx offload flags Olivier Matz
2021-07-30 9:37 ` Michał Krawczyk
2021-07-30 10:11 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).