patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Michał Krawczyk <mk@semihalf.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, stable@dpdk.org, Marcin Wojtas <mw@semihalf.com>,
	 Guy Tzalik <gtzalik@amazon.com>,
	Evgeny Schemeilin <evgenys@amazon.com>,
	 Igor Chauskin <igorch@amazon.com>, Rafal Kozik <rk@semihalf.com>,
	 Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [dpdk-stable] [PATCH] net/ena: remove unused macro
Date: Fri, 23 Oct 2020 14:56:08 +0200
Message-ID: <CAJMMOfP+et0GyOpd2WNW+ipn6hEZVKh7AKT+L=0VXXSXCW-0Rg@mail.gmail.com> (raw)
In-Reply-To: <20201023084352.30034-1-david.marchand@redhat.com>

pt., 23 paź 2020 o 10:44 David Marchand <david.marchand@redhat.com> napisał(a):
>
> This assert macro is not called anymore.
> This also fixes an invalid reference to RTE_LOGTYPE_ERR that does not
> exist.
>
> Fixes: 3adcba9a8987 ("net/ena: update HAL to the newer version")
> Fixes: 6f1c9df9e9cc ("net/ena: use dynamic log type for debug logging")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Acked-by: Michal Krawczyk <mk@semihalf.com>
> ---
>  drivers/net/ena/base/ena_plat_dpdk.h | 13 -------------
>  1 file changed, 13 deletions(-)
>
> diff --git a/drivers/net/ena/base/ena_plat_dpdk.h b/drivers/net/ena/base/ena_plat_dpdk.h
> index ae4fd8f868..a6782f3732 100644
> --- a/drivers/net/ena/base/ena_plat_dpdk.h
> +++ b/drivers/net/ena/base/ena_plat_dpdk.h
> @@ -73,19 +73,6 @@ typedef uint64_t dma_addr_t;
>         (rte_get_timer_cycles() * US_PER_S / rte_get_timer_hz())
>
>  extern int ena_logtype_com;
> -#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG
> -#define ENA_ASSERT(cond, format, arg...)                               \
> -       do {                                                            \
> -               if (unlikely(!(cond))) {                                \
> -                       rte_log(RTE_LOGTYPE_ERR, ena_logtype_com,       \
> -                               format, ##arg);                         \
> -                       rte_panic("line %d\tassert \"" #cond "\""       \
> -                                       "failed\n", __LINE__);          \
> -               }                                                       \
> -       } while (0)
> -#else
> -#define ENA_ASSERT(cond, format, arg...) do {} while (0)
> -#endif
>
>  #define ENA_MAX_T(type, x, y) RTE_MAX((type)(x), (type)(y))
>  #define ENA_MAX32(x, y) ENA_MAX_T(uint32_t, (x), (y))
> --
> 2.23.0
>

  reply	other threads:[~2020-10-23 12:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-23  8:43 David Marchand
2020-10-23 12:56 ` Michał Krawczyk [this message]
2020-10-23 14:10   ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJMMOfP+et0GyOpd2WNW+ipn6hEZVKh7AKT+L=0VXXSXCW-0Rg@mail.gmail.com' \
    --to=mk@semihalf.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=evgenys@amazon.com \
    --cc=gtzalik@amazon.com \
    --cc=igorch@amazon.com \
    --cc=mw@semihalf.com \
    --cc=rk@semihalf.com \
    --cc=stable@dpdk.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git