From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 136EC4688E for ; Thu, 5 Jun 2025 16:55:03 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F364140647; Thu, 5 Jun 2025 16:55:02 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id F10A340270 for ; Thu, 5 Jun 2025 16:55:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749135300; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZnKk+602EL50lQjqHpnfoZ8yry54dC+bNkUq0YnNtpE=; b=RzWI9BwhduySVkKbLc3t7d5nhy5yPuOOo8zsNv6C5m60SeEy34s9iY4z26vq+GhGRcI5Cy qR9QajPBR/nFZY/9kXsyvmFvWoTo9+DZ65/eVm38rLFoEdkMn3ImvSC9MW8gbXgbIlYUBB oP/97n06pQwnlmFdbl3RUq6FJPoLKcM= Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-600-8jdlOrI3OtKXJBe4u75q5Q-1; Thu, 05 Jun 2025 10:54:59 -0400 X-MC-Unique: 8jdlOrI3OtKXJBe4u75q5Q-1 X-Mimecast-MFC-AGG-ID: 8jdlOrI3OtKXJBe4u75q5Q_1749135298 Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-73e0094706bso1522182b3a.3 for ; Thu, 05 Jun 2025 07:54:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749135298; x=1749740098; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZnKk+602EL50lQjqHpnfoZ8yry54dC+bNkUq0YnNtpE=; b=nuWjIZ28Tz+NzLUhiNXDHuh3nqx5ncrSrXDeE3dwV/ZZ9JbI0F4SnbRvb9Zhe/x4/N qlaVRVWOWa3o64qAPy9+TFYNn5DfRYt1OWXVOwol43lQSCy53tcHgEBYzmZDtJzmY2zq rTCSOWBDXK+QF/w9ZuMl3Z5XMyV/QHXBkHWoHtVdjXaSeAcEEFJVRYj3XOkThv49nNU/ XUUA53UNbLU/pFMrWDUhccx0CfdhHxzROZ0fosujwSG4PvZUZ+uegMjh8rmY6blDjQNP XdDbYpqPvsdcP2lJuIqI4UocYGjLjQt0WJD0NygBW2AnEZiUfc2TbDSbBki3+D6M3UFC MpHw== X-Forwarded-Encrypted: i=1; AJvYcCVjMnBo90zU+9p6e6tfYj0KHxeYGUfAFZXPm/F2Ep3bnAEpv0a81Bzth1jRZ5iqSa7vMtwUMSY=@dpdk.org X-Gm-Message-State: AOJu0YwrISrmExk8vG3GPniOl0/WurGbipGIu7WuDHiBWM+ZZTQvjAQq u2TvIENHdNufChf9Tlnq0yl7FbEv85/oikjpZO8HjjRkWrjkqP61PtuqbOM09sllusvBphBj6ZJ 5YNGdTBm9cKnN+FrLpuerVWsGLlbeafOZB07BvcJRvWsS0ABSuzmIl256NF93tuPgKWIAJeUDJ+ mRoPJHwQThcDKKJz9IVj+skFI= X-Gm-Gg: ASbGnctEDzsIPq1BwYmmi73mjTyg8Phsboc9UTdAyqFHo2k2o9eacERnTSO4ISMpLn+ 57wuSRSeqrjbM50qt9Mq7yvMnAzMkSLDrLr7fNw7HPQ7Ki7jB01EhO46aKDls/PC0QbM= X-Received: by 2002:a05:6a00:1142:b0:740:5927:bb8b with SMTP id d2e1a72fcca58-74827cfb07fmr130618b3a.0.1749135298077; Thu, 05 Jun 2025 07:54:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGM2w40h/NXnUyD/ngvR+9YD8kHafwawxiGzIPIa5GDxsqeiK/qfqgn76nOy+2Bl371N+3Rx501FQ2yVC5K68k= X-Received: by 2002:a05:6a00:1142:b0:740:5927:bb8b with SMTP id d2e1a72fcca58-74827cfb07fmr130583b3a.0.1749135297647; Thu, 05 Jun 2025 07:54:57 -0700 (PDT) MIME-Version: 1.0 References: <20250605113552.918120-1-eperezma@redhat.com> In-Reply-To: From: Eugenio Perez Martin Date: Thu, 5 Jun 2025 16:54:21 +0200 X-Gm-Features: AX0GCFusnYAWYO-kPlLVmu_2WsDyrb5r8xIzl_5Tbo6ugyBZmbzEwc7IZqgkOss Message-ID: Subject: Re: [PATCH 0/2] Search the split vq desc and avail in RO areas To: David Marchand Cc: dev@dpdk.org, Chenbo Xia , stable@dpdk.org, Maxime Coquelin X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: csBKDcJ4AGUu21eVZRnHVTIXmhGMpQ_zXy2EGe_lOkc_1749135298 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Thu, Jun 5, 2025 at 1:50=E2=80=AFPM David Marchand wrote: > > On Thu, Jun 5, 2025 at 1:36=E2=80=AFPM Eugenio P=C3=A9rez wrote: > > > > QEMU's shadow virtqueue and VDUSE exposes these areas as read-only. If > > we don't change it, vhost_iova_to_vva do not consider them as valid and > > returns that they're not found. > > > > Eugenio P=C3=A9rez (2): > > vhost: search the split vq desc and avail in RO areas > > vhost: search the packed vq driver area in RO areas > > > > lib/vhost/vhost.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > At a quick glance, no need for two patches. > Sure I can respin with both squashed. > Sorry, the implication of this issue is not clear to me. > What is the impact from a user pov? > QEMU maps the CVQ descriptors and avail vring through as read only maps in the case of vDPA. But DPDK is looking for them with RW permissions, so the vhost_iova_to_vva function never selects the right one as valid. Looking for them with RO still picks the map if it is mapped as RW, but the reverse is not true. Let me know if you want me to respin the series with this comment too! > > -- > David Marchand >