* [PATCH v1 1/1] baseband/acc: fix queue setup failure clean up [not found] <20250305182716.773937-1-nicolas.chautru@intel.com> @ 2025-03-05 18:27 ` Nicolas Chautru 2025-03-06 2:59 ` Patrick Robb 2025-03-12 13:48 ` Maxime Coquelin 0 siblings, 2 replies; 4+ messages in thread From: Nicolas Chautru @ 2025-03-05 18:27 UTC (permalink / raw) To: dev, maxime.coquelin; +Cc: hernan.vargas, Nicolas Chautru, stable Incomplete clean up for vrb2 variant when queue setup fails to complete successfully. Fixes: fc65d3dcabe01 ("baseband/acc: refactor queue allocation") Cc: stable@dpdk.org Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com> --- drivers/baseband/acc/rte_vrb_pmd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/baseband/acc/rte_vrb_pmd.c b/drivers/baseband/acc/rte_vrb_pmd.c index 27620ccc10..2c10ef2c94 100644 --- a/drivers/baseband/acc/rte_vrb_pmd.c +++ b/drivers/baseband/acc/rte_vrb_pmd.c @@ -1156,6 +1156,8 @@ vrb_queue_setup(struct rte_bbdev *dev, uint16_t queue_id, free_q: rte_free(q); q = NULL; + if (d->device_variant == VRB2_VARIANT) + d->queue_index[conf->op_type]--; return ret; } -- 2.34.1 ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] baseband/acc: fix queue setup failure clean up 2025-03-05 18:27 ` [PATCH v1 1/1] baseband/acc: fix queue setup failure clean up Nicolas Chautru @ 2025-03-06 2:59 ` Patrick Robb 2025-03-12 13:48 ` Maxime Coquelin 1 sibling, 0 replies; 4+ messages in thread From: Patrick Robb @ 2025-03-06 2:59 UTC (permalink / raw) To: Nicolas Chautru; +Cc: dev, maxime.coquelin, hernan.vargas, stable [-- Attachment #1: Type: text/plain, Size: 166 bytes --] Recheck-request: iol-intel-Performance There was an infra failure with the Arm Grace server about 12 hours ago which caused this failure - sending a retest request. [-- Attachment #2: Type: text/html, Size: 204 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] baseband/acc: fix queue setup failure clean up 2025-03-05 18:27 ` [PATCH v1 1/1] baseband/acc: fix queue setup failure clean up Nicolas Chautru 2025-03-06 2:59 ` Patrick Robb @ 2025-03-12 13:48 ` Maxime Coquelin 2025-03-12 15:27 ` Maxime Coquelin 1 sibling, 1 reply; 4+ messages in thread From: Maxime Coquelin @ 2025-03-12 13:48 UTC (permalink / raw) To: Nicolas Chautru, dev; +Cc: hernan.vargas, stable On 3/5/25 7:27 PM, Nicolas Chautru wrote: > Incomplete clean up for vrb2 variant when queue setup fails > to complete successfully. > > Fixes: fc65d3dcabe01 ("baseband/acc: refactor queue allocation") > Cc: stable@dpdk.org > > Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com> > --- > drivers/baseband/acc/rte_vrb_pmd.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/baseband/acc/rte_vrb_pmd.c b/drivers/baseband/acc/rte_vrb_pmd.c > index 27620ccc10..2c10ef2c94 100644 > --- a/drivers/baseband/acc/rte_vrb_pmd.c > +++ b/drivers/baseband/acc/rte_vrb_pmd.c > @@ -1156,6 +1156,8 @@ vrb_queue_setup(struct rte_bbdev *dev, uint16_t queue_id, > free_q: > rte_free(q); > q = NULL; > + if (d->device_variant == VRB2_VARIANT) > + d->queue_index[conf->op_type]--; > > return ret; > } Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com> Thanks, Maxime ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] baseband/acc: fix queue setup failure clean up 2025-03-12 13:48 ` Maxime Coquelin @ 2025-03-12 15:27 ` Maxime Coquelin 0 siblings, 0 replies; 4+ messages in thread From: Maxime Coquelin @ 2025-03-12 15:27 UTC (permalink / raw) To: Nicolas Chautru, dev; +Cc: hernan.vargas, stable On 3/12/25 2:48 PM, Maxime Coquelin wrote: > > > On 3/5/25 7:27 PM, Nicolas Chautru wrote: >> Incomplete clean up for vrb2 variant when queue setup fails >> to complete successfully. >> >> Fixes: fc65d3dcabe01 ("baseband/acc: refactor queue allocation") >> Cc: stable@dpdk.org >> >> Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com> >> --- >> drivers/baseband/acc/rte_vrb_pmd.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/baseband/acc/rte_vrb_pmd.c b/drivers/baseband/ >> acc/rte_vrb_pmd.c >> index 27620ccc10..2c10ef2c94 100644 >> --- a/drivers/baseband/acc/rte_vrb_pmd.c >> +++ b/drivers/baseband/acc/rte_vrb_pmd.c >> @@ -1156,6 +1156,8 @@ vrb_queue_setup(struct rte_bbdev *dev, uint16_t >> queue_id, >> free_q: >> rte_free(q); >> q = NULL; >> + if (d->device_variant == VRB2_VARIANT) >> + d->queue_index[conf->op_type]--; >> return ret; >> } > > Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com> > > Thanks, > Maxime > Applied to next-baseband. Thanks, Maxime ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-03-12 15:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20250305182716.773937-1-nicolas.chautru@intel.com>
2025-03-05 18:27 ` [PATCH v1 1/1] baseband/acc: fix queue setup failure clean up Nicolas Chautru
2025-03-06 2:59 ` Patrick Robb
2025-03-12 13:48 ` Maxime Coquelin
2025-03-12 15:27 ` Maxime Coquelin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).