From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 36F56A04BA for ; Mon, 5 Oct 2020 11:41:05 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2D3B72BA8; Mon, 5 Oct 2020 11:41:04 +0200 (CEST) Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67]) by dpdk.org (Postfix) with ESMTP id D96CB2BA8; Mon, 5 Oct 2020 11:41:01 +0200 (CEST) Received: by mail-io1-f67.google.com with SMTP id 67so5069062iob.8; Mon, 05 Oct 2020 02:41:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EvjIwsT2MYwIYCnLKsrMfHIDbj2vhHAsVEDWhxXBX4g=; b=GFAdXXVc9VRBEe2WyBtf459Z/xW96P/syB4NKCklYRFglfyD4B/93oeCvhtvEu9iVP GYFVu7+5uc9N4nk/BhJ1IxeOB+N59+WUTM89w3Vfp0L4T/oO2fk0cEe6TiJHEJndq7IL rbmao0kUN1JqjR6XYFPw9jpFUByBspXOn5GxZOrpmll8B4Yui6B9mrxZs0mV6gwdxhb5 iq1RvDv9HxW9zv2laut4PQxvx43IR/njtzbWrgPtXuvB1KqU1zTU2AH4O4wKwfvGa/RE GKuJ+VEvIu5HOKPSmaAZwq1+Z4wjbMS3H8YUoD+4J/cAJyBxQyUUZvlNdRnehOlKCxeB 4Maw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EvjIwsT2MYwIYCnLKsrMfHIDbj2vhHAsVEDWhxXBX4g=; b=KnV7Ooxt0jG4fFF8GJdFzN/nHoY8fs9XNcpQca9+Xev4Fznm5xmvlWkUtc+2IRc0uZ cUWKnQ44mXi8wC48fyvWTvO7XiU9ztN41dJ129Umr3StVxBifeIGF4G4H7fu3fF30TIA uCGGc2OOC3rW70NMOmjBFy6Ysb7z37FPVj7wJnV5ay/44N/gUe3sEfvPmbpXCrqp/xQp juw1cCFyBhRDr2U3kVFiXFwwmELiSqvhy3hFxQZICeF/tYHyjTQrH/ypHSm12jc3cW/0 umn5NMuFQ8++PEMMoniJ8aAepV0cKIEd/FSwDo+Fy5hTKZfnM00m4arTLwgcM1g8oTGK PHlQ== X-Gm-Message-State: AOAM530jRX0v0Z3ZcoRDCq7ePy/vzcGigGyqxgMFxfh8za0x6KgnSLCB qtGwCxBUyd0lZaASybIVyuNZ3EMXf3jbNtg2Xy47bJacorQo4w== X-Google-Smtp-Source: ABdhPJzxwXFjYJlBZeKx3EFqXUuKE5i1MZy4+HtcYntqDUPEsRpG0mCajveFjmdcPzTFn4refqB3wpM8G9s6+t0KbMk= X-Received: by 2002:a05:6638:16c5:: with SMTP id g5mr12409994jat.112.1601890860168; Mon, 05 Oct 2020 02:41:00 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Jerin Jacob Date: Mon, 5 Oct 2020 15:10:44 +0530 Message-ID: To: Nipun Gupta Cc: wangyunjian , "dev@dpdk.org" , Hemant Agrawal , "jerry.lilijun@huawei.com" , "xudingke@huawei.com" , "stable@dpdk.org" Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] event/dpaa2: fix dereference before null check X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Sun, Oct 4, 2020 at 4:23 PM Nipun Gupta wrote: > > Acked-by: Nipun Gupta Applied to dpdk-next-eventdev/for-main. Thanks. > > > -----Original Message----- > > From: wangyunjian > > Sent: Wednesday, August 26, 2020 6:38 PM > > To: dev@dpdk.org; Hemant Agrawal ; Nipun Gupta > > > > Cc: jerry.lilijun@huawei.com; xudingke@huawei.com; Yunjian Wang > > ; stable@dpdk.org > > Subject: [dpdk-dev] [PATCH] event/dpaa2: fix dereference before null check > > > > From: Yunjian Wang > > > > Coverity flags that 'portal' variable is used before > > it's checked for NULL. This patch fixes this issue. > > > > Coverity issue: 323516 > > Fixes: 4ab57b042e7c ("event/dpaa2: affine portal at runtime during I/O") > > Cc: stable@dpdk.org > > > > Signed-off-by: Yunjian Wang > > --- > > drivers/event/dpaa2/dpaa2_eventdev.c | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c > > b/drivers/event/dpaa2/dpaa2_eventdev.c > > index 3ae4441ee..f7383ca73 100644 > > --- a/drivers/event/dpaa2/dpaa2_eventdev.c > > +++ b/drivers/event/dpaa2/dpaa2_eventdev.c > > @@ -569,14 +569,14 @@ dpaa2_eventdev_port_release(void *port) > > > > EVENTDEV_INIT_FUNC_TRACE(); > > > > + if (portal == NULL) > > + return; > > + > > /* TODO: Cleanup is required when ports are in linked state. */ > > if (portal->is_port_linked) > > DPAA2_EVENTDEV_WARN("Event port must be unlinked before > > release"); > > > > - if (portal) > > - rte_free(portal); > > - > > - portal = NULL; > > + rte_free(portal); > > } > > > > static int > > -- > > 2.23.0 > > >