* [dpdk-stable] [PATCH 1/5] event/dpaa2: fix def queue conf
[not found] <20190906103410.14996-1-hemant.agrawal@nxp.com>
@ 2019-09-06 10:34 ` Hemant Agrawal
[not found] ` <20190907064209.30686-1-hemant.agrawal@nxp.com>
1 sibling, 0 replies; 9+ messages in thread
From: Hemant Agrawal @ 2019-09-06 10:34 UTC (permalink / raw)
To: dev; +Cc: jerinj, stable, Hemant Agrawal
Test vector expect only one type of scheduling as default.
The old code is provide support scheduling types instead of default.
Fixes: 13370a3877a5 ("eventdev: fix inconsistency in queue config")
Cc: stable@dpdk.org
Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
drivers/event/dpaa2/dpaa2_eventdev.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c b/drivers/event/dpaa2/dpaa2_eventdev.c
index 926b7edd8..b8cb437a0 100644
--- a/drivers/event/dpaa2/dpaa2_eventdev.c
+++ b/drivers/event/dpaa2/dpaa2_eventdev.c
@@ -1,7 +1,5 @@
/* SPDX-License-Identifier: BSD-3-Clause
- *
- * Copyright 2017 NXP
- *
+ * Copyright 2017,2019 NXP
*/
#include <assert.h>
@@ -470,8 +468,7 @@ dpaa2_eventdev_queue_def_conf(struct rte_eventdev *dev, uint8_t queue_id,
RTE_SET_USED(queue_conf);
queue_conf->nb_atomic_flows = DPAA2_EVENT_QUEUE_ATOMIC_FLOWS;
- queue_conf->schedule_type = RTE_SCHED_TYPE_ATOMIC |
- RTE_SCHED_TYPE_PARALLEL;
+ queue_conf->schedule_type = RTE_SCHED_TYPE_PARALLEL;
queue_conf->priority = RTE_EVENT_DEV_PRIORITY_NORMAL;
}
--
2.17.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* [dpdk-stable] [PATCH v2 1/5] event/dpaa2: fix def queue conf
[not found] ` <20190907064209.30686-1-hemant.agrawal@nxp.com>
@ 2019-09-07 6:42 ` Hemant Agrawal
2019-09-13 6:24 ` [dpdk-stable] [dpdk-dev] " Jerin Jacob
[not found] ` <20190927075841.21841-1-hemant.agrawal@nxp.com>
1 sibling, 1 reply; 9+ messages in thread
From: Hemant Agrawal @ 2019-09-07 6:42 UTC (permalink / raw)
To: dev; +Cc: jerinj, stable, Hemant Agrawal
Test vector expect only one type of scheduling as default.
The old code is provide support scheduling types instead of default.
Fixes: 13370a3877a5 ("eventdev: fix inconsistency in queue config")
Cc: stable@dpdk.org
Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
drivers/event/dpaa2/dpaa2_eventdev.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c b/drivers/event/dpaa2/dpaa2_eventdev.c
index 926b7edd8..b8cb437a0 100644
--- a/drivers/event/dpaa2/dpaa2_eventdev.c
+++ b/drivers/event/dpaa2/dpaa2_eventdev.c
@@ -1,7 +1,5 @@
/* SPDX-License-Identifier: BSD-3-Clause
- *
- * Copyright 2017 NXP
- *
+ * Copyright 2017,2019 NXP
*/
#include <assert.h>
@@ -470,8 +468,7 @@ dpaa2_eventdev_queue_def_conf(struct rte_eventdev *dev, uint8_t queue_id,
RTE_SET_USED(queue_conf);
queue_conf->nb_atomic_flows = DPAA2_EVENT_QUEUE_ATOMIC_FLOWS;
- queue_conf->schedule_type = RTE_SCHED_TYPE_ATOMIC |
- RTE_SCHED_TYPE_PARALLEL;
+ queue_conf->schedule_type = RTE_SCHED_TYPE_PARALLEL;
queue_conf->priority = RTE_EVENT_DEV_PRIORITY_NORMAL;
}
--
2.17.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH v2 1/5] event/dpaa2: fix def queue conf
2019-09-07 6:42 ` [dpdk-stable] [PATCH v2 " Hemant Agrawal
@ 2019-09-13 6:24 ` Jerin Jacob
2019-09-26 17:55 ` Jerin Jacob
0 siblings, 1 reply; 9+ messages in thread
From: Jerin Jacob @ 2019-09-13 6:24 UTC (permalink / raw)
To: Hemant Agrawal; +Cc: dev, Jerin Jacob, stable
On Sat, Sep 7, 2019 at 12:14 PM Hemant Agrawal <hemant.agrawal@nxp.com> wrote:
>
> Test vector expect only one type of scheduling as default.
> The old code is provide support scheduling types instead of default.
>
> Fixes: 13370a3877a5 ("eventdev: fix inconsistency in queue config")
> Cc: stable@dpdk.org
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
Please fix the clang build issue
http://mails.dpdk.org/archives/test-report/2019-September/096533.html
> drivers/event/dpaa2/dpaa2_eventdev.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c b/drivers/event/dpaa2/dpaa2_eventdev.c
> index 926b7edd8..b8cb437a0 100644
> --- a/drivers/event/dpaa2/dpaa2_eventdev.c
> +++ b/drivers/event/dpaa2/dpaa2_eventdev.c
> @@ -1,7 +1,5 @@
> /* SPDX-License-Identifier: BSD-3-Clause
> - *
> - * Copyright 2017 NXP
> - *
> + * Copyright 2017,2019 NXP
> */
>
> #include <assert.h>
> @@ -470,8 +468,7 @@ dpaa2_eventdev_queue_def_conf(struct rte_eventdev *dev, uint8_t queue_id,
> RTE_SET_USED(queue_conf);
>
> queue_conf->nb_atomic_flows = DPAA2_EVENT_QUEUE_ATOMIC_FLOWS;
> - queue_conf->schedule_type = RTE_SCHED_TYPE_ATOMIC |
> - RTE_SCHED_TYPE_PARALLEL;
> + queue_conf->schedule_type = RTE_SCHED_TYPE_PARALLEL;
> queue_conf->priority = RTE_EVENT_DEV_PRIORITY_NORMAL;
> }
>
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH v2 1/5] event/dpaa2: fix def queue conf
2019-09-13 6:24 ` [dpdk-stable] [dpdk-dev] " Jerin Jacob
@ 2019-09-26 17:55 ` Jerin Jacob
2019-09-27 6:02 ` Hemant Agrawal
0 siblings, 1 reply; 9+ messages in thread
From: Jerin Jacob @ 2019-09-26 17:55 UTC (permalink / raw)
To: Hemant Agrawal; +Cc: dpdk-dev, Jerin Jacob, stable
On Fri, Sep 13, 2019 at 11:54 AM Jerin Jacob <jerinjacobk@gmail.com> wrote:
>
> On Sat, Sep 7, 2019 at 12:14 PM Hemant Agrawal <hemant.agrawal@nxp.com> wrote:
> >
> > Test vector expect only one type of scheduling as default.
> > The old code is provide support scheduling types instead of default.
> >
> > Fixes: 13370a3877a5 ("eventdev: fix inconsistency in queue config")
> > Cc: stable@dpdk.org
> > Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
>
> Please fix the clang build issue
> http://mails.dpdk.org/archives/test-report/2019-September/096533.html
Waiting for the next version to merge for RC1.
>
>
>
> > drivers/event/dpaa2/dpaa2_eventdev.c | 7 ++-----
> > 1 file changed, 2 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c b/drivers/event/dpaa2/dpaa2_eventdev.c
> > index 926b7edd8..b8cb437a0 100644
> > --- a/drivers/event/dpaa2/dpaa2_eventdev.c
> > +++ b/drivers/event/dpaa2/dpaa2_eventdev.c
> > @@ -1,7 +1,5 @@
> > /* SPDX-License-Identifier: BSD-3-Clause
> > - *
> > - * Copyright 2017 NXP
> > - *
> > + * Copyright 2017,2019 NXP
> > */
> >
> > #include <assert.h>
> > @@ -470,8 +468,7 @@ dpaa2_eventdev_queue_def_conf(struct rte_eventdev *dev, uint8_t queue_id,
> > RTE_SET_USED(queue_conf);
> >
> > queue_conf->nb_atomic_flows = DPAA2_EVENT_QUEUE_ATOMIC_FLOWS;
> > - queue_conf->schedule_type = RTE_SCHED_TYPE_ATOMIC |
> > - RTE_SCHED_TYPE_PARALLEL;
> > + queue_conf->schedule_type = RTE_SCHED_TYPE_PARALLEL;
> > queue_conf->priority = RTE_EVENT_DEV_PRIORITY_NORMAL;
> > }
> >
> > --
> > 2.17.1
> >
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH v2 1/5] event/dpaa2: fix def queue conf
2019-09-26 17:55 ` Jerin Jacob
@ 2019-09-27 6:02 ` Hemant Agrawal
0 siblings, 0 replies; 9+ messages in thread
From: Hemant Agrawal @ 2019-09-27 6:02 UTC (permalink / raw)
To: Jerin Jacob; +Cc: dpdk-dev, Jerin Jacob, stable
I will send the RC2 today.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [dpdk-stable] [PATCH 1/6] event/dpaa2: fix def queue conf
[not found] ` <20190927075841.21841-1-hemant.agrawal@nxp.com>
@ 2019-09-27 7:58 ` Hemant Agrawal
2019-09-30 6:43 ` [dpdk-stable] [dpdk-dev] " Jerin Jacob
[not found] ` <20190930083215.8241-1-hemant.agrawal@nxp.com>
1 sibling, 1 reply; 9+ messages in thread
From: Hemant Agrawal @ 2019-09-27 7:58 UTC (permalink / raw)
To: dev; +Cc: jerinj, stable
Test vector expect only one type of scheduling as default.
The old code is provide support scheduling types instead of default.
Fixes: 13370a3877a5 ("eventdev: fix inconsistency in queue config")
Cc: stable@dpdk.org
Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
drivers/event/dpaa2/dpaa2_eventdev.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c b/drivers/event/dpaa2/dpaa2_eventdev.c
index 926b7edd8..b8cb437a0 100644
--- a/drivers/event/dpaa2/dpaa2_eventdev.c
+++ b/drivers/event/dpaa2/dpaa2_eventdev.c
@@ -1,7 +1,5 @@
/* SPDX-License-Identifier: BSD-3-Clause
- *
- * Copyright 2017 NXP
- *
+ * Copyright 2017,2019 NXP
*/
#include <assert.h>
@@ -470,8 +468,7 @@ dpaa2_eventdev_queue_def_conf(struct rte_eventdev *dev, uint8_t queue_id,
RTE_SET_USED(queue_conf);
queue_conf->nb_atomic_flows = DPAA2_EVENT_QUEUE_ATOMIC_FLOWS;
- queue_conf->schedule_type = RTE_SCHED_TYPE_ATOMIC |
- RTE_SCHED_TYPE_PARALLEL;
+ queue_conf->schedule_type = RTE_SCHED_TYPE_PARALLEL;
queue_conf->priority = RTE_EVENT_DEV_PRIORITY_NORMAL;
}
--
2.17.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH 1/6] event/dpaa2: fix def queue conf
2019-09-27 7:58 ` [dpdk-stable] [PATCH 1/6] " Hemant Agrawal
@ 2019-09-30 6:43 ` Jerin Jacob
0 siblings, 0 replies; 9+ messages in thread
From: Jerin Jacob @ 2019-09-30 6:43 UTC (permalink / raw)
To: Hemant Agrawal; +Cc: dpdk-dev, Jerin Jacob, stable
On Fri, Sep 27, 2019 at 1:31 PM Hemant Agrawal <hemant.agrawal@nxp.com> wrote:
>
> Test vector expect only one type of scheduling as default.
> The old code is provide support scheduling types instead of default.
>
> Fixes: 13370a3877a5 ("eventdev: fix inconsistency in queue config")
> Cc: stable@dpdk.org
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
1) Patch version is missing
2) Shared library build failure.
http://mails.dpdk.org/archives/test-report/2019-September/099288.html
Please send the next version with fixes.
/usr/bin/ld: dpaa2_eventdev_selftest.o: in function `rte_mempool_get_ops':
dpaa2_eventdev_selftest.c:(.text+0x224): undefined reference to
`rte_mempool_ops_table'
/usr/bin/ld: dpaa2_eventdev_selftest.o: in function `rte_mbuf_raw_alloc':
dpaa2_eventdev_selftest.c:(.text+0x8d4): undefined reference to
`rte_mempool_check_cookies'
/usr/bin/ld: dpaa2_eventdev_selftest.c:(.text+0x8f5): undefined
reference to `rte_mbuf_sanity_check'
/usr/bin/ld: dpaa2_eventdev_selftest.o: in function `rte_pktmbuf_reset':
dpaa2_eventdev_selftest.c:(.text+0xa26): undefined reference to
`rte_mbuf_sanity_check'
/usr/bin/ld: dpaa2_eventdev_selftest.o: in function `__rte_pktmbuf_free_direct':
dpaa2_eventdev_selftest.c:(.text+0xb47): undefined reference to
`rte_mbuf_sanity_check'
/usr/bin/ld: dpaa2_eventdev_selftest.c:(.text+0xc15): undefined
reference to `rte_mempool_check_cookies'
/usr/bin/ld: dpaa2_eventdev_selftest.o: in function `rte_pktmbuf_free':
dpaa2_eventdev_selftest.c:(.text+0x23cf): undefined reference to
`rte_mbuf_sanity_check'
/usr/bin/ld: dpaa2_eventdev_selftest.c:(.text+0x2408): undefined
reference to `rte_mbuf_sanity_check'
/usr/bin/ld: dpaa2_eventdev_selftest.c:(.text+0x2535): undefined
reference to `rte_mbuf_sanity_check'
/usr/bin/ld: dpaa2_eventdev_selftest.c:(.text+0x2603): undefined
reference to `rte_mempool_check_cookies'
/usr/bin/ld: dpaa2_eventdev_selftest.o: in function `_eventdev_setup':
dpaa2_eventdev_selftest.c:(.text+0x4142): undefined reference to
`rte_pktmbuf_pool_create'
/usr/bin/ld: dpaa2_eventdev_selftest.o: in function `eventdev_teardown':
dpaa2_eventdev_selftest.c:(.text+0x465d): undefined reference to
`rte_mempool_free'
collect2: error: ld returned 1 exit status
> ---
> drivers/event/dpaa2/dpaa2_eventdev.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c b/drivers/event/dpaa2/dpaa2_eventdev.c
> index 926b7edd8..b8cb437a0 100644
> --- a/drivers/event/dpaa2/dpaa2_eventdev.c
> +++ b/drivers/event/dpaa2/dpaa2_eventdev.c
> @@ -1,7 +1,5 @@
> /* SPDX-License-Identifier: BSD-3-Clause
> - *
> - * Copyright 2017 NXP
> - *
> + * Copyright 2017,2019 NXP
> */
>
> #include <assert.h>
> @@ -470,8 +468,7 @@ dpaa2_eventdev_queue_def_conf(struct rte_eventdev *dev, uint8_t queue_id,
> RTE_SET_USED(queue_conf);
>
> queue_conf->nb_atomic_flows = DPAA2_EVENT_QUEUE_ATOMIC_FLOWS;
> - queue_conf->schedule_type = RTE_SCHED_TYPE_ATOMIC |
> - RTE_SCHED_TYPE_PARALLEL;
> + queue_conf->schedule_type = RTE_SCHED_TYPE_PARALLEL;
> queue_conf->priority = RTE_EVENT_DEV_PRIORITY_NORMAL;
> }
>
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [dpdk-stable] [PATCH v4 1/6] event/dpaa2: fix def queue conf
[not found] ` <20190930083215.8241-1-hemant.agrawal@nxp.com>
@ 2019-09-30 8:32 ` Hemant Agrawal
2019-09-30 14:17 ` [dpdk-stable] [dpdk-dev] " Jerin Jacob
0 siblings, 1 reply; 9+ messages in thread
From: Hemant Agrawal @ 2019-09-30 8:32 UTC (permalink / raw)
To: dev; +Cc: jerinj, stable
Test vector expect only one type of scheduling as default.
The old code is provide support scheduling types instead of default.
Fixes: 13370a3877a5 ("eventdev: fix inconsistency in queue config")
Cc: stable@dpdk.org
Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
drivers/event/dpaa2/dpaa2_eventdev.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c b/drivers/event/dpaa2/dpaa2_eventdev.c
index 926b7edd8..b8cb437a0 100644
--- a/drivers/event/dpaa2/dpaa2_eventdev.c
+++ b/drivers/event/dpaa2/dpaa2_eventdev.c
@@ -1,7 +1,5 @@
/* SPDX-License-Identifier: BSD-3-Clause
- *
- * Copyright 2017 NXP
- *
+ * Copyright 2017,2019 NXP
*/
#include <assert.h>
@@ -470,8 +468,7 @@ dpaa2_eventdev_queue_def_conf(struct rte_eventdev *dev, uint8_t queue_id,
RTE_SET_USED(queue_conf);
queue_conf->nb_atomic_flows = DPAA2_EVENT_QUEUE_ATOMIC_FLOWS;
- queue_conf->schedule_type = RTE_SCHED_TYPE_ATOMIC |
- RTE_SCHED_TYPE_PARALLEL;
+ queue_conf->schedule_type = RTE_SCHED_TYPE_PARALLEL;
queue_conf->priority = RTE_EVENT_DEV_PRIORITY_NORMAL;
}
--
2.17.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH v4 1/6] event/dpaa2: fix def queue conf
2019-09-30 8:32 ` [dpdk-stable] [PATCH v4 " Hemant Agrawal
@ 2019-09-30 14:17 ` Jerin Jacob
0 siblings, 0 replies; 9+ messages in thread
From: Jerin Jacob @ 2019-09-30 14:17 UTC (permalink / raw)
To: Hemant Agrawal; +Cc: dpdk-dev, Jerin Jacob, stable
On Mon, Sep 30, 2019 at 2:04 PM Hemant Agrawal <hemant.agrawal@nxp.com> wrote:
>
> Test vector expect only one type of scheduling as default.
> The old code is provide support scheduling types instead of default.
>
> Fixes: 13370a3877a5 ("eventdev: fix inconsistency in queue config")
> Cc: stable@dpdk.org
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
Series applied to dpdk-next-eventdev/master. Thanks.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2019-09-30 14:17 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20190906103410.14996-1-hemant.agrawal@nxp.com>
2019-09-06 10:34 ` [dpdk-stable] [PATCH 1/5] event/dpaa2: fix def queue conf Hemant Agrawal
[not found] ` <20190907064209.30686-1-hemant.agrawal@nxp.com>
2019-09-07 6:42 ` [dpdk-stable] [PATCH v2 " Hemant Agrawal
2019-09-13 6:24 ` [dpdk-stable] [dpdk-dev] " Jerin Jacob
2019-09-26 17:55 ` Jerin Jacob
2019-09-27 6:02 ` Hemant Agrawal
[not found] ` <20190927075841.21841-1-hemant.agrawal@nxp.com>
2019-09-27 7:58 ` [dpdk-stable] [PATCH 1/6] " Hemant Agrawal
2019-09-30 6:43 ` [dpdk-stable] [dpdk-dev] " Jerin Jacob
[not found] ` <20190930083215.8241-1-hemant.agrawal@nxp.com>
2019-09-30 8:32 ` [dpdk-stable] [PATCH v4 " Hemant Agrawal
2019-09-30 14:17 ` [dpdk-stable] [dpdk-dev] " Jerin Jacob
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).