patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Jerin Jacob <jerinjacobk@gmail.com>
To: Pavan Nikhilesh <pbhagavatula@marvell.com>
Cc: Jerin Jacob <jerinj@marvell.com>, dpdk-dev <dev@dpdk.org>,
	dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] app/eventdev: fix unchecked function return values
Date: Thu, 14 May 2020 18:47:11 +0530	[thread overview]
Message-ID: <CALBAE1MbZSfVowqwMaRtMZTWxD=0mgwdvoXycZ6Ayx-KcM-2mg@mail.gmail.com> (raw)
In-Reply-To: <20200513202249.6295-1-pbhagavatula@marvell.com>

On Thu, May 14, 2020 at 1:53 AM <pbhagavatula@marvell.com> wrote:
>
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> Fix unchecked return values reported by coverity.
>
> Coverity issue: 357755
> Fixes: 032a965a8f1d ("app/eventdev: support Tx adapter")
> Cc: stable@dpdk.org
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> ---
>  app/test-eventdev/test_pipeline_common.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/app/test-eventdev/test_pipeline_common.c b/app/test-eventdev/test_pipeline_common.c
> index 84c42b33c..f1c227941 100644
> --- a/app/test-eventdev/test_pipeline_common.c
> +++ b/app/test-eventdev/test_pipeline_common.c
> @@ -392,8 +392,12 @@ pipeline_event_tx_adapter_setup(struct evt_options *opt,
>                 if (!(cap & RTE_EVENT_ETH_TX_ADAPTER_CAP_INTERNAL_PORT)) {
>                         uint32_t service_id = -1U;
>
> -                       rte_event_eth_tx_adapter_service_id_get(consm,
> -                                       &service_id);
> +                       ret = rte_event_eth_tx_adapter_service_id_get(consm,
> +                                                                  &service_id);
> +                       if (ret != -ESRCH && ret != 0) {
> +                               evt_err("Failed to get Tx adptr service ID\n");

\n is not required as evt_err has it.

Acked-by: Jerin Jacob <jerinj@marvell.com>

Fixed and Applied to dpdk-next-eventdev/master. Thanks.



> +                               return ret;
> +                       }

      reply	other threads:[~2020-05-14 13:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-13 20:22 pbhagavatula
2020-05-14 13:17 ` Jerin Jacob [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALBAE1MbZSfVowqwMaRtMZTWxD=0mgwdvoXycZ6Ayx-KcM-2mg@mail.gmail.com' \
    --to=jerinjacobk@gmail.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=pbhagavatula@marvell.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).