From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B99F6A0352 for ; Thu, 14 May 2020 15:17:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8627B1D8C9; Thu, 14 May 2020 15:17:30 +0200 (CEST) Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67]) by dpdk.org (Postfix) with ESMTP id 0F9651D6A5; Thu, 14 May 2020 15:17:28 +0200 (CEST) Received: by mail-io1-f67.google.com with SMTP id j8so1831314iog.13; Thu, 14 May 2020 06:17:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eHK4XU870CFfydjkugKmU4uM3S7fzeGvblwnT99MtKk=; b=vZGH5v1KuNMySO4vM8/ML4zURLnR1EUhvYD7b63sN+zxpRrncLH65w7PHkYWKCoSc9 LSak8XW0XwuJB6JiIbRj3hSBVbjmr+peno0z4/Ot4pygiqWotfl5xFdGhXs7ItaX/6/H y8+oGQIgwAG9n0+D2+XS9WPgGSqC0tGwn4DFrkefv7ihsJCwYCfnvC2Fb5u/aKbUKNi8 IyXA2CEWi51tExnUKXWChDHAncOor0TQCNLxrlOYMByLuVKU23/UODI2ruYuKeP3Oanq c/b2o9joHS2d8vzIagK/Gdnul5zyNDX/LGndEtLwut9ExHFu18yFuKucmezRXO+6pNFE OfZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eHK4XU870CFfydjkugKmU4uM3S7fzeGvblwnT99MtKk=; b=FSfPx3L2okc4qaln5H1+KnymgmHK0SAazNZsEsNtnAiR6kFl4eKbBE70ln3AxEaHmg 3MzdAGowD8RQX0iV4Vq9mYG7mEqzCGANCyiWeRo54vEf58f+lvPW3LWPOtumvE0QNkgs 0BSKI/MUKb7yJhPX9VlXE/Wbi552erLraAy3b6Z/zwiXwNsyouqzs9BRYcpLMdtlhmpO om7lbn+2hkfDBr3xMBqVWIi2Tm2Ts3oqvodO9Gtqt02uxK04KutzO+bgVxcnh5QSJbIk RKbgJm2vyv3RpCPBoJ43pYGbI8G1c2lgMM7k8zcgJMZaB0HgYS8W2O9xF9pr+MWrwVqa VQTw== X-Gm-Message-State: AGi0PubEC4G228tHf4QeNw/QzwRFDdzYFX3O2o4pja8tURRQwaZpEBKO a3UXKmXSsoK2Lf9LGqUNZlsoX8jYX/qaKcwhQMtnZoPGIqI= X-Google-Smtp-Source: APiQypIgsGIbXf9DggUr87mQF8rmsc8RYpn/DDw6jQzMyO2Q0svESpLdudS7p3ngkfSyPPzh9DT71wPtsoivvRSXVN0= X-Received: by 2002:a02:c6c5:: with SMTP id r5mr4278638jan.133.1589462247234; Thu, 14 May 2020 06:17:27 -0700 (PDT) MIME-Version: 1.0 References: <20200513202249.6295-1-pbhagavatula@marvell.com> In-Reply-To: <20200513202249.6295-1-pbhagavatula@marvell.com> From: Jerin Jacob Date: Thu, 14 May 2020 18:47:11 +0530 Message-ID: To: Pavan Nikhilesh Cc: Jerin Jacob , dpdk-dev , dpdk stable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] app/eventdev: fix unchecked function return values X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Thu, May 14, 2020 at 1:53 AM wrote: > > From: Pavan Nikhilesh > > Fix unchecked return values reported by coverity. > > Coverity issue: 357755 > Fixes: 032a965a8f1d ("app/eventdev: support Tx adapter") > Cc: stable@dpdk.org > > Signed-off-by: Pavan Nikhilesh > --- > app/test-eventdev/test_pipeline_common.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/app/test-eventdev/test_pipeline_common.c b/app/test-eventdev/test_pipeline_common.c > index 84c42b33c..f1c227941 100644 > --- a/app/test-eventdev/test_pipeline_common.c > +++ b/app/test-eventdev/test_pipeline_common.c > @@ -392,8 +392,12 @@ pipeline_event_tx_adapter_setup(struct evt_options *opt, > if (!(cap & RTE_EVENT_ETH_TX_ADAPTER_CAP_INTERNAL_PORT)) { > uint32_t service_id = -1U; > > - rte_event_eth_tx_adapter_service_id_get(consm, > - &service_id); > + ret = rte_event_eth_tx_adapter_service_id_get(consm, > + &service_id); > + if (ret != -ESRCH && ret != 0) { > + evt_err("Failed to get Tx adptr service ID\n"); \n is not required as evt_err has it. Acked-by: Jerin Jacob Fixed and Applied to dpdk-next-eventdev/master. Thanks. > + return ret; > + }