From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 73317A0C50 for ; Mon, 12 Jul 2021 11:09:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 66A8B41194; Mon, 12 Jul 2021 11:09:41 +0200 (CEST) Received: from mail-io1-f42.google.com (mail-io1-f42.google.com [209.85.166.42]) by mails.dpdk.org (Postfix) with ESMTP id 2945840685; Mon, 12 Jul 2021 11:09:39 +0200 (CEST) Received: by mail-io1-f42.google.com with SMTP id h6so21724352iok.6; Mon, 12 Jul 2021 02:09:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=66/czdQ/IxKTzpbb3oH3PxKw97QahXrt3N+/qMexoXI=; b=N6wtLNefHP/UP2/ByOOlfU4aialKPtK+wD9AWcexH0Bg9iFZbNnfZYYeoW6V9thPGX hW5EvsdCoCA1kEqciwKtWByL5vZ7F6BUQQngNuimWq+YbREnufxZ6L1ptTZ7QL/ZrU5Y xVnpvzWFc2mmt7Rd58RpSdYmQrpWQn7n0mk8BbIcavZ4OBnnlGh7TQ7zZK/452K8l952 o1tXM/6HV8LzpZsd21lJ5NxNxjlIkYQNopUu4sE6UWy7JPYo0axZvLqBOdqVh89FM3k5 xYzib6b04je9g3Q3JztBLflWxhnG8VtcSixkR/s5jDwzSxjRTcAcnBXaZQP9sTTCw7kl vU3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=66/czdQ/IxKTzpbb3oH3PxKw97QahXrt3N+/qMexoXI=; b=rFnYqMqba2wRkd8RH5eszFLxfkgnNB6x+fWFwGapVKJGw47AAIKRwGv5W5HKoqp2qD f84eS5FT0Iwi0lXRrONbmms4veMGywyr8QcclEBqejAQ7Zjjx3T4WXVpXIVEA3uHAu9U W6pCp4lXVGwsXjKgzxTVFpzbgPm6uVbZJKW1r0wvplW3p8BH0eJBL8HCk+SQ81taXIrg 8wYLsMcJfrpy0tGgkxoSicHS/DYuwjq1xtmytUTGuoOdjTmmB72NfGL6F8L0TjZo5Qbp EsCllhPq+C1Rf3qEDP25A/+4MMvVMSTWH+o8G2af7z6VkYffBlRoW9pMRoaPsmeh91Ez +hjw== X-Gm-Message-State: AOAM53339lFY+Jizko0uKk6kXo0m+EoPXsJ/LHQ5IUTbvHb5Onljj7KE +/DBWnbHsztGpU0cDYky7qUyIF5dF7tmED0hwrc= X-Google-Smtp-Source: ABdhPJz1FDV5fppWc/wyKFWgrijemeTS67FWZCpveVyrACaubeW/j6LPd/DNDscKAs6M1+vY1W13W7VDc2CalQATKnQ= X-Received: by 2002:a6b:d20c:: with SMTP id q12mr37810395iob.59.1626080978554; Mon, 12 Jul 2021 02:09:38 -0700 (PDT) MIME-Version: 1.0 References: <20210711131314.11985-1-danat@marvell.com> In-Reply-To: <20210711131314.11985-1-danat@marvell.com> From: Jerin Jacob Date: Mon, 12 Jul 2021 14:39:12 +0530 Message-ID: To: Dana Vardi Cc: Jerin Jacob , dpdk-dev , Liron Himi , Meir Levi , dpdk stable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/mvpp2: fix declare unsupported vlan offload features X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Sun, Jul 11, 2021 at 6:43 PM wrote: > > From: Meir Levi > > vlan_strip and vlan_extend features need to return "unsupported" > error value. > > Fixes: ff0b8b10dc4 ("net/mvpp2: support VLAN offload") > Cc: stable@dpdk.org > > Signed-off-by: Meir Levi > Reviewed-by: Liron Himi Changed the subject to net/mvpp2: fix VLAN ops return code Applied to dpdk-next-net-mrvl/for-next-net. Thanks > --- > drivers/net/mvpp2/mrvl_ethdev.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethdev.c > index 1802695a0e..078aefbb8d 100644 > --- a/drivers/net/mvpp2/mrvl_ethdev.c > +++ b/drivers/net/mvpp2/mrvl_ethdev.c > @@ -1873,8 +1873,10 @@ static int mrvl_vlan_offload_set(struct rte_eth_dev *dev, int mask) > uint64_t rx_offloads = dev->data->dev_conf.rxmode.offloads; > int ret; > > - if (mask & ETH_VLAN_STRIP_MASK) > + if (mask & ETH_VLAN_STRIP_MASK) { > MRVL_LOG(ERR, "VLAN stripping is not supported\n"); > + return -ENOTSUP; > + } > > if (mask & ETH_VLAN_FILTER_MASK) { > if (rx_offloads & DEV_RX_OFFLOAD_VLAN_FILTER) > @@ -1886,8 +1888,10 @@ static int mrvl_vlan_offload_set(struct rte_eth_dev *dev, int mask) > return ret; > } > > - if (mask & ETH_VLAN_EXTEND_MASK) > + if (mask & ETH_VLAN_EXTEND_MASK) { > MRVL_LOG(ERR, "Extend VLAN not supported\n"); > + return -ENOTSUP; > + } > > return 0; > } > -- > 2.17.1 >