Stopping an already disabled vport leads to firmware assert. Stop the vport only if it was started. Fixes: 2ea6f76aff40 ("qede: add core driver") Cc: stable@dpdk.org Signed-off-by: Manish Chopra <manishc@marvell.com> Signed-off-by: Rasesh Mody <rmody@marvell.com> --- drivers/net/qede/qede_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c index 500440c2c..74dfe895a 100644 --- a/drivers/net/qede/qede_ethdev.c +++ b/drivers/net/qede/qede_ethdev.c @@ -1509,7 +1509,8 @@ static void qede_dev_close(struct rte_eth_dev *eth_dev) if (eth_dev->data->dev_started) qede_dev_stop(eth_dev); - qede_stop_vport(edev); + if (qdev->vport_started) + qede_stop_vport(edev); qdev->vport_started = false; qede_fdir_dealloc_resc(eth_dev); qede_dealloc_fp_resc(eth_dev); -- 2.17.1
+Jerin >From: dev <dev-bounces@dpdk.org> On Behalf Of Manish Chopra >Sent: Thursday, February 06, 2020 12:02 PM > >On ungraceful termination of DPDK application, PMD VF driver fails to re-load >due to PF seeing the VF in unexpected state during VF acquisition handshake. > >This patch fixes it by allowing VF to request the PF for soft FLR during the load >in such cases so that it can get cleanly re-loaded. > >Fixes: 2ea6f76aff40 ("qede: add core driver") Cc: stable@dpdk.org > >Signed-off-by: Manish Chopra <manishc@marvell.com> >Signed-off-by: Shahed Shaikh <shshaikh@marvell.com> >Signed-off-by: Rasesh Mody <rmody@marvell.com> >--- Acked-by: Rasesh Mody <rmody@marvell.com>
On Fri, Feb 7, 2020 at 11:52 AM Rasesh Mody <rmody@marvell.com> wrote: > > +Jerin > > >From: dev <dev-bounces@dpdk.org> On Behalf Of Manish Chopra > >Sent: Thursday, February 06, 2020 12:02 PM > > > >On ungraceful termination of DPDK application, PMD VF driver fails to re-load > >due to PF seeing the VF in unexpected state during VF acquisition handshake. > > > >This patch fixes it by allowing VF to request the PF for soft FLR during the load > >in such cases so that it can get cleanly re-loaded. > > > >Fixes: 2ea6f76aff40 ("qede: add core driver") > > Cc: stable@dpdk.org > > > > >Signed-off-by: Manish Chopra <manishc@marvell.com> > >Signed-off-by: Shahed Shaikh <shshaikh@marvell.com> > >Signed-off-by: Rasesh Mody <rmody@marvell.com> > >--- > > Acked-by: Rasesh Mody <rmody@marvell.com> Fixed following check-git-log.sh warnings[1] Series applied to dpdk-next-net-mrvl/master. Thanks. [1] check-git-log failed Wrong headline format: net/qede: Do not stop vport if not started. Wrong headline uppercase: net/qede: Fix VF re-load failure after ungraceful termination of DPDK net/qede: Do not stop vport if not started. Headline too long: net/qede: Fix VF re-load failure after ungraceful termination of DPDK Is it candidate for Cc: stable@dpdk.org backport? net/qede: Fix VF re-load failure after ungraceful termination of DPDK] >