Re: [dpdk-dev] [PATCH v1] doc: remove warning with doxygen 1.9.7

[Jerin Jacob <jerinjacobk@gmail.com>]

On Fri, Jun 2, 2023 at 2:11 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> On Fri, Jun 02, 2023 at 02:00:32PM +0530, jerinj@marvell.com wrote:
> > From: Jerin Jacob <jerinj@marvell.com>
> >
> > Since doxygen 1.9.7 version, HTML_TIMESTAMP configuration option
> > changed to TIMESTAMP [2]. Fixed the following warning[1] by providing
> > the correct configuration option based on doxygen version.
> >
> > [1]
> > Warning: Tag 'HTML_TIMESTAMP' at line 115 of file 'doc/api/doxy-api.conf'
> > has become obsolete.
> >
> > [2]
> > https://www.doxygen.nl/manual/config.html#cfg_timestamp
> >
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> > ---
> > v2:
> > - use run_command() as https://mesonbuild.com/Reference-manual_returned_external_program.html#external_programversion
> > introduced in 0.62 version and DPDK min meson version is 0.53.2
> >
> >  doc/api/doxy-api.conf.in | 2 +-
> >  doc/api/meson.build      | 7 +++++++
> >  2 files changed, 8 insertions(+), 1 deletion(-)
> >
> > diff --git a/doc/api/doxy-api.conf.in b/doc/api/doxy-api.conf.in
> > index d230a19e1f..60e582d8fc 100644
> > --- a/doc/api/doxy-api.conf.in
> > +++ b/doc/api/doxy-api.conf.in
> > @@ -111,7 +111,7 @@ GENERATE_DEPRECATEDLIST = YES
> >  VERBATIM_HEADERS        = NO
> >  ALPHABETICAL_INDEX      = NO
> >
> > -HTML_TIMESTAMP          = NO
> > +@TS_PREFIX@TIMESTAMP   = NO
>
> As explained in previous email, belately sent in reply to v1, I think we
> should just drop this line, and not worry about version checks.

Yes. I think that is better. I will send new version to remove it.

>
> /Bruce
>