From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C4787A09FF for ; Mon, 11 Jan 2021 15:38:57 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B44B3140E51; Mon, 11 Jan 2021 15:38:57 +0100 (CET) Received: from mail-il1-f173.google.com (mail-il1-f173.google.com [209.85.166.173]) by mails.dpdk.org (Postfix) with ESMTP id 82B18140D1D; Mon, 11 Jan 2021 15:38:55 +0100 (CET) Received: by mail-il1-f173.google.com with SMTP id q5so18581526ilc.10; Mon, 11 Jan 2021 06:38:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QiKoJ/KKA5NAyKVO02YvQGJeD70Y2ySNd51Bfta85W8=; b=X3B9z7daSeO3CVUhxr0XhgNXxbzKWoC5GoAGjlb7wIFy9gVymXQxauCqhHUyF3Y7bQ KrbaUGC1LA7jwwzfJk4HQuJEzKgDRznvnUpeiU3uyI9HcY/UYSSrwEMO37Z1U+Z3rlPS w/WSsaVwq0s8sIPFurjGmrBiMkhZy6BaL6ytKTvxntMSGKBGE1r+mSsN4Cmd+l5DAkG2 TU+l5ockL8zw1YEIZtGdabCj/l9x5tLcVqMBUci681cujVyWWGt2zKtxc0OcSeYUdIpi Id85qQbjasQL47+UYvNWB8xYguq8f5pw84A+2TNYeWfKNdxgK26WWrL35UJ1LO/4asdj bTQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QiKoJ/KKA5NAyKVO02YvQGJeD70Y2ySNd51Bfta85W8=; b=tYJMvmxAl37RjSKWW/mQdXQENx50HEoTm0eVC/PxDNa6F1mJLFXkEfM/VeDyAgreGi WrV+fSr9O6Wn8LkN+HI32s4MprZ+jVWMYMaWVH/WWozpsQBPJAuvkzp0nuxNSmwQt3Mc lltao9SDTNFcBJ/8x+KviEPDMYgii549fOUOhIAN5fCuSZtGT4eooONcgUFOwL0qD4xG W7A1JBy71+WdGt0zU+OorzxX8aKGmk8y565eMxyw9cU9XNT/7xucRXCwms+QrZa1sE8G ZE+AcTG5tXPoRaOrlclzd00M8WF3V1YCXwcE4JGDS0wl2oDzZt/eAQnvxDkKKnDbcUkm FHEA== X-Gm-Message-State: AOAM531YWRSnx+YcHwyVzduyYZP3My26yMDjW2p8FHbRfQg9ZkOp0ujd S84z86ByqLPMg2jVjS3s8Gext2T/+6QsfR/dROQ= X-Google-Smtp-Source: ABdhPJxkGAXemCK9SI5yuPxZwZucpxAfYzh5x9WfZZUtInujJ1znnC5s6i1JeRpNAcn9uQhabEL8qQRwAQQMeaGTzDk= X-Received: by 2002:a92:5802:: with SMTP id m2mr15372131ilb.271.1610375934935; Mon, 11 Jan 2021 06:38:54 -0800 (PST) MIME-Version: 1.0 References: <20201202101212.4717-1-lironh@marvell.com> <20201202101212.4717-5-lironh@marvell.com> In-Reply-To: From: Jerin Jacob Date: Mon, 11 Jan 2021 20:08:38 +0530 Message-ID: To: Michael Shamis Cc: Liron Himi , Jerin Jacob Kollanukkaran , "dev@dpdk.org" , "stable@dpdk.org" Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v1 04/38] net/mvpp2: skip vlan flush X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Wed, Dec 23, 2020 at 3:15 PM Michael Shamis wrote: > > Reviewed-by: Michael Shamis > > -----Original Message----- > From: dev On Behalf Of lironh@marvell.com > Sent: Wednesday, December 2, 2020 12:12 PM > To: Jerin Jacob Kollanukkaran > Cc: dev@dpdk.org; Liron Himi ; stable@dpdk.org > Subject: [dpdk-dev] [PATCH v1 04/38] net/mvpp2: skip vlan flush > > From: Liron Himi > > vlan-flush in MUSDK is not supported yet. > until it does, the code should be skipped as currently an redundant error message is displayed. > > Fixes: a8f3d6783 ("net/mrvl: support VLAN filtering") > Cc: stable@dpdk.org > > Signed-off-by: Liron Himi > Reviewed-by: Liron Himi > --- > drivers/net/mvpp2/mrvl_ethdev.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethdev.c index ebd2bb1c8..0985ccebe 100644 > --- a/drivers/net/mvpp2/mrvl_ethdev.c > +++ b/drivers/net/mvpp2/mrvl_ethdev.c > @@ -672,15 +672,15 @@ mrvl_dev_start(struct rte_eth_dev *dev) > } > > if (!priv->vlan_flushed) { > - ret = pp2_ppio_flush_vlan(priv->ppio); > - if (ret) { > - MRVL_LOG(ERR, "Failed to flush vlan list"); > - /* > - * TODO > - * once pp2_ppio_flush_vlan() is supported jump to out > - * goto out; > - */ > - } > + /* > + * TODO > + * once pp2_ppio_flush_vlan() is supported call it > + * ret = pp2_ppio_flush_vlan(priv->ppio); > + * if (ret) { > + * MRVL_LOG(ERR, "Failed to flush vlan list"); > + * goto out; > + * } > + */ This kind of TODO is no go in upstream code. I think, MUSDK can be updated to skip the error and have an API detect the feature is present or not? so that drivers can make intelligent decisions and have clean code. > priv->vlan_flushed = 1; > } > ret = mrvl_mtu_set(dev, dev->data->mtu); > -- > 2.28.0 >