From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4BB6DA0567 for ; Tue, 9 Mar 2021 13:54:42 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 37E3122A4D3; Tue, 9 Mar 2021 13:54:42 +0100 (CET) Received: from mail-il1-f182.google.com (mail-il1-f182.google.com [209.85.166.182]) by mails.dpdk.org (Postfix) with ESMTP id 8A4EA22A32F; Tue, 9 Mar 2021 13:54:39 +0100 (CET) Received: by mail-il1-f182.google.com with SMTP id e2so12101676ilu.0; Tue, 09 Mar 2021 04:54:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Vw7T/UANk95UgOP5jo8R1qddr0tJmUKWLAWdlLpLRgk=; b=A3SIhT4mwXJf+k3n6fu48GT8MH8iJ3ehKnRP6YS6AG2JaqoxOr8CNUYu9MjWCvs4jt OcIRqKd1AGWYa6xjy+nT1v0DnLdRLtVBHUlI5p5ajODTslmChRwumpN9ozGnGsoFtlDe NwWNv0Wt9ZVyiqc5Eg7APMXfXBtRd1uptfBWD/6NHRGbjOS/8eIwCpNuWPQ+uAamFwft tdDwqAi0shi3BN6CVQJIrs2vT/Z7qNg+YdZUTZd7j8qaEDYZE+bBmNd3WAR5a4OaFyeA uf0iBFRa7Kxfo241oKdMCvVpc6P+t4kRKlBiE+o9rF96BVDIuXoOW365VgiALK6SHIq8 jJsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Vw7T/UANk95UgOP5jo8R1qddr0tJmUKWLAWdlLpLRgk=; b=rNj22ql6HAlZ00tLSQ0OwfvUamvergzX9gzRZGcv9zFHVVKwq1u7YIy8afNI5RVWic XUhIO6WOGFQLOO6XuCa7rFd0S6vExhe1dGu6RNcBVJ8BTJkOfCnVpC+Wo1ZGKZvuNXy9 1scXZVPMtQyK3MXJmTeNu2UrimmLsB1cswHaR0UVnlwfImhHJuxNFXuPbixRlQS3uTgO 0lVWiko6HMyE1y8BNBCnJaNg3zQQ6DMjp1as1QmcjYbQt+cK2ZeSxYiFZI/Gqb1vtk5c LXEeYA8khQ/iDVJskbJ4CiwDYkKGQ3aDr2oRxGtpg49oFTxTkNmvtCIyAuBVtEzJyQ2j V6Vw== X-Gm-Message-State: AOAM533fPxKMiL1cGopoUUhDhrrbnD0EAXET8SVPSeGhPgsx4diBFB2L tiXPfC31+PoOvHZ3Hh0jceOVY1bR4UtpGT4bHBE= X-Google-Smtp-Source: ABdhPJwkSJ4eqo5PNpZv7qMUkaNybubb3TqNvjFbWc64H4gqBXmgiyW2W7KKUBY0C8qZo9tQsrABExmon/Fe8LNswSM= X-Received: by 2002:a92:d18e:: with SMTP id z14mr25043856ilz.130.1615294478736; Tue, 09 Mar 2021 04:54:38 -0800 (PST) MIME-Version: 1.0 References: <20210225093213.2811627-1-feifei.wang2@arm.com> <20210225093213.2811627-2-feifei.wang2@arm.com> In-Reply-To: From: Jerin Jacob Date: Tue, 9 Mar 2021 18:24:22 +0530 Message-ID: To: Feifei Wang Cc: "jerinj@marvell.com" , Sunil Kumar Kori , David Marchand , "dev@dpdk.org" , nd , "stable@dpdk.org" , Honnappa Nagarahalli , Ruifeng Wang Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-stable] =?utf-8?b?W2RwZGstZGV2XSDlm57lpI06IFtQQVRDSCB2MiAx?= =?utf-8?q?/1=5D_app/test=3A_collect_perf_data_after_worker_threads?= =?utf-8?q?_exit?= X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Tue, Mar 9, 2021 at 2:36 PM Feifei Wang wrote: > > Hi, Jerin > > Sorry to disturb you. Would you please help review this patch when you ar= e free? Sure. See below. > Thanks very much. > > Best Regards > Feifei > > > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > > =E5=8F=91=E4=BB=B6=E4=BA=BA: Feifei Wang > > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2021=E5=B9=B42=E6=9C=8825=E6=97= =A5 17:32 > > =E6=94=B6=E4=BB=B6=E4=BA=BA: jerinj@marvell.com; Sunil Kumar Kori ; David > > Marchand > > =E6=8A=84=E9=80=81: dev@dpdk.org; nd ; Feifei Wang > > ; stable@dpdk.org; Honnappa Nagarahalli > > ; Honnappa Nagarahalli > > ; Ruifeng Wang > > > > =E4=B8=BB=E9=A2=98: [PATCH v2 1/1] app/test: collect perf data after wo= rker threads exit > > > > The measure_perf function should be executed after worker threads exit = to > > collect correct perf data. Otherwise, while workers are running, the ma= in > > thread may get incomplete data from workers. > > > > In the meanwhile, remove unnecessary barrier in the test. > > For signal variables "ldata.done" and "ldata.start", no operations shou= ld keep > > the order that being executed after them. So the wmb after them can be > > moved. > > > > Fixes: 16a277a24c9f ("test/trace: add performance test cases") > > Cc: jerinj@marvell.com > > Cc: stable@dpdk.org > > > > Suggested-by: Honnappa Nagarahalli > > Signed-off-by: Feifei Wang > > Reviewed-by: Honnappa Nagarahalli > > Reviewed-by: Ruifeng Wang Please change to test/trace: .... The rest looks good to me. Acked-by: Jerin Jacob > > --- > > app/test/test_trace_perf.c | 5 ++--- > > 1 file changed, 2 insertions(+), 3 deletions(-) > > > > diff --git a/app/test/test_trace_perf.c b/app/test/test_trace_perf.c in= dex > > e1ad8e6f5..46ae7d807 100644 > > --- a/app/test/test_trace_perf.c > > +++ b/app/test/test_trace_perf.c > > @@ -79,7 +79,6 @@ signal_workers_to_finish(struct test_data *data) > > > > for (workers =3D 0; workers < data->nb_workers; workers++) { > > data->ldata[workers].done =3D 1; > > - rte_smp_wmb(); > > } > > } > > > > @@ -102,7 +101,6 @@ worker_fn_##func(void *arg) \ { \ > > struct lcore_data *ldata =3D arg; \ > > ldata->started =3D 1; \ > > - rte_smp_wmb(); \ > > __worker_##func(ldata); \ > > return 0; \ > > } > > @@ -137,11 +135,12 @@ run_test(const char *str, lcore_function_t f, str= uct > > test_data *data, size_t sz) > > > > wait_till_workers_are_ready(data); > > rte_delay_ms(100); /* Wait for some time to accumulate the stats = */ > > - measure_perf(str, data); > > signal_workers_to_finish(data); > > > > RTE_LCORE_FOREACH_WORKER(id) > > rte_eal_wait_lcore(id); > > + > > + measure_perf(str, data); > > } > > > > static int > > -- > > 2.25.1 >